Merged
Conversation
rust-highfive
added
the
S-waiting-on-review
Member
|
LGTM, thanks! @bors r+ rollup |
Collaborator
|
📌 Commit bf4d0ad has been approved by |
bors
added
S-waiting-on-bors
davidtwco
approved these changes
May 2, 2019
Centril
added a commit
to Centril/rust
that referenced
this pull request
May 2, 2019
Rename `RUST_LOG` to `RUSTC_LOG` cc: rust-lang#57985 I think we should also change these submodules: - rustc-guide - Cargo (rename to `CARGO_LOG`, cc: rust-lang/cargo#6605) - miri - rls - rustfmt r? @davidtwco
Centril
added a commit
to Centril/rust
that referenced
this pull request
May 3, 2019
Rename `RUST_LOG` to `RUSTC_LOG` cc: rust-lang#57985 I think we should also change these submodules: - rustc-guide - Cargo (rename to `CARGO_LOG`, cc: rust-lang/cargo#6605, rust-lang/cargo#6189) - miri - rls - rustfmt r? @davidtwco
bors
added a commit
that referenced
this pull request
May 3, 2019
Rollup of 12 pull requests Successful merges: - #59928 (Make deprecation lint `ambiguous_associated_items` deny-by-default) - #60220 (report fatal errors during doctest parsing) - #60373 (Tidy: ensure lang features are sorted by since) - #60388 (Disallow non-explicit elided lifetimes in async fn) - #60393 ( Do not suggest incorrect syntax on pattern type error due to borrow) - #60401 (Rename `RUST_LOG` to `RUSTC_LOG`) - #60409 (Require a trait in the bounds of existential types) - #60455 (Resolve match arm ty when arms diverge) - #60457 (Const prop refactoring) - #60467 (Avoid repeated interning of static strings.) - #60478 (minor compiler doc tweaks) - #60501 (Propagate mutability from arguments to local bindings in async fn) Failed merges: r? @ghost
This was referenced May 3, 2019
bors
added a commit
to rust-lang/cargo
that referenced
this pull request
May 8, 2019
Changed RUST_LOG usage to CARGO_LOG to avoid confusion. This is a repost of #6605 now that rust-lang/rust#60401 has been merged. This also includes a fix in `TargetInfo::new` to remove the **RUSTC_LOG** var.
Member
|
Should this be relnotes? I just lost a lot of time trying to figure out why my logging commands suddenly wouldn't work any more... |
Member
Miri is listed in there but did not get changed (I'll take care of that now). Did someone go through the others in that list? |
Member
Author
Yes, I agree with. Some may be confused without notes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cc: #57985
I think we should also change these submodules:
CARGO_LOG, cc: Changed RUST_LOG usage to CARGO_LOG to avoid confusion. cargo#6605, Cargo should use a variable other than RUST_LOG for env_logger. cargo#6189)r? @davidtwco