Merged
Conversation
rust-highfive
added
the
S-waiting-on-review
oli-obk
reviewed
May 2, 2019
Contributor
oli-obk
left a comment
oli-obk
left a comment
There was a problem hiding this comment.
r=me with nit fixed, rebased and CI passing
wesleywiser
force-pushed
the
const_prop_refactoring
branch
from
43c4abf to
0e9aeb0
Compare
wesleywiser
force-pushed
the
const_prop_refactoring
branch
from
0e9aeb0 to
16fe8cc
Compare
This comment has been minimized.
This comment has been minimized.
Contributor
|
You need an additional rust/src/test/ui/consts/const-err.rs Lines 14 to 15 in 16fe8cc |
Contributor
|
@bors r+ |
Collaborator
|
📌 Commit cac07eb has been approved by |
bors
added
S-waiting-on-bors
Centril
added a commit
to Centril/rust
that referenced
this pull request
May 2, 2019
… r=oli-obk Const prop refactoring This is rebased on top of rust-lang#60428 so only the top commit is new. This is the refactoring to remove the `mir` field from `ConstPropagator` which is necessary before we can begin to actually propagate constants. r? @oli-obk
Centril
added a commit
to Centril/rust
that referenced
this pull request
May 3, 2019
… r=oli-obk Const prop refactoring This is rebased on top of rust-lang#60428 so only the top commit is new. This is the refactoring to remove the `mir` field from `ConstPropagator` which is necessary before we can begin to actually propagate constants. r? @oli-obk
bors
added a commit
that referenced
this pull request
May 3, 2019
Rollup of 12 pull requests Successful merges: - #59928 (Make deprecation lint `ambiguous_associated_items` deny-by-default) - #60220 (report fatal errors during doctest parsing) - #60373 (Tidy: ensure lang features are sorted by since) - #60388 (Disallow non-explicit elided lifetimes in async fn) - #60393 ( Do not suggest incorrect syntax on pattern type error due to borrow) - #60401 (Rename `RUST_LOG` to `RUSTC_LOG`) - #60409 (Require a trait in the bounds of existential types) - #60455 (Resolve match arm ty when arms diverge) - #60457 (Const prop refactoring) - #60467 (Avoid repeated interning of static strings.) - #60478 (minor compiler doc tweaks) - #60501 (Propagate mutability from arguments to local bindings in async fn) Failed merges: r? @ghost
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is rebased on top of #60428 so only the top commit is new.
This is the refactoring to remove the
mirfield fromConstPropagatorwhich is necessary before we can begin to actually propagate constants.r? @oli-obk