Undo an assert causing an ICE until we fix the underlying problem#66250
Merged
bors merged 1 commit intorust-lang:masterfrom Nov 11, 2019
Merged
Undo an assert causing an ICE until we fix the underlying problem#66250bors merged 1 commit intorust-lang:masterfrom
bors merged 1 commit intorust-lang:masterfrom
Conversation
rust-highfive
added
the
S-waiting-on-review
oli-obk
added
the
beta-nominated
oli-obk
force-pushed
the
no_fields_in_empty_unions
branch
from
61a59de to
875f550
Compare
oli-obk
force-pushed
the
no_fields_in_empty_unions
branch
from
875f550 to
39fb820
Compare
oli-obk
changed the title
Member
|
@bors r+ |
Collaborator
|
📌 Commit 39fb820 has been approved by |
bors
added
S-waiting-on-bors
Collaborator
Collaborator
|
☀️ Test successful - checks-azure |
Contributor
rust-highfive
added a commit
to rust-lang-nursery/rust-toolstate
that referenced
this pull request
Nov 11, 2019
Tested on commit rust-lang/rust@1062b69. Direct link to PR: <rust-lang/rust#66250> 💔 rustc-guide on linux: test-pass → test-fail (cc @amanjeev @spastorino @mark-i-m, @rust-lang/infra).
pnkfelix
added
the
T-compiler
Member
|
Leaving a note here that if we don't beta accept this PR we should make sure to open an issue tracking this regression so we don't forget about it. |
Contributor
|
beta-accepted (last week, sorry for delay!) |
pnkfelix
added
the
beta-accepted
Merged
Mark-Simulacrum
removed
the
beta-nominated
bors
added a commit
that referenced
this pull request
Dec 7, 2019
[beta] backports This pull request backports the following pull requests, which have all been beta-accepted by the compiler team. * Handle non_exhaustive in borrow checking #66722 * Do not ICE on trait aliases with missing obligations #66392 * Do not ICE in `if` without `else` in `async fn` #66391 * Fix ICE when trying to suggest `Type<>` instead of `Type()` #66390 * Do not ICE on recovery from unmet associated type bound obligation #66388 * find_deprecation: deprecation attr may be ill-formed meta. #66381 * parser: don't use `unreachable!()` in `fn unexpected`. #66361 * Undo an assert causing an ICE until we fix the underlying problem #66250 * Do not ICE with a precision flag in formatting str and no format arguments #66093 * Fix two OOM issues related to `ConstProp` #66394
bors
added a commit
that referenced
this pull request
Dec 8, 2019
[beta] backports This pull request backports the following pull requests, which have all been beta-accepted by the compiler team. * Handle non_exhaustive in borrow checking #66722 * Do not ICE on trait aliases with missing obligations #66392 * Do not ICE in `if` without `else` in `async fn` #66391 * Fix ICE when trying to suggest `Type<>` instead of `Type()` #66390 * Do not ICE on recovery from unmet associated type bound obligation #66388 * find_deprecation: deprecation attr may be ill-formed meta. #66381 * parser: don't use `unreachable!()` in `fn unexpected`. #66361 * Undo an assert causing an ICE until we fix the underlying problem #66250 * Do not ICE with a precision flag in formatting str and no format arguments #66093 * Fix two OOM issues related to `ConstProp` #66394
This was referenced Mar 6, 2020
RalfJung
reviewed
Mar 6, 2020
Comment on lines
-698
to
-699
| assert!(i < count, | ||
| "Tried to access field {} of union with {} fields", i, count); |
Member
There was a problem hiding this comment.
Would have been good to at least leave a FIXME in place here so that future readers of this code know there should be an assertion. I just had to rediscover this by browsing the rustc source starting somewhere in codegen.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
r? @eddyb
fixes #65462