Conversation
review comment
|
@bors r+ p=1 |
|
📌 Commit 9f7420ba8df3b428ca26984ee2e63ed00d2ba0dc has been approved by |
|
⌛ Testing commit 9f7420ba8df3b428ca26984ee2e63ed00d2ba0dc with merge dadb03032a6d499c74cdc033285d22d9924f1eeb... |
|
The job Click to expand the log.I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
|
💔 Test failed - checks-azure |
|
Any chance to get #66983 in here? |
|
I've beta-nominated that PR but if it doesn't get approved in time by the compiler team, it'll likely slip into stable. I expect we'll be doing at least one more round of backports, though, so I wouldn't worry too much -- as long as that PR is approved (r+), it should get in I imagine (though it's ultimately up to the compiler team). |
|
👍 |
9f7420b to
628dc27
Compare
|
@bors r+ Looks like a rebase failure was the cause of the test failure. |
|
📌 Commit 628dc274607ecf30d7db523f1672c4ce1296042a has been approved by |
|
⌛ Testing commit 628dc274607ecf30d7db523f1672c4ce1296042a with merge abb92a3a417471bc93da7a76787bcccad50bf0fe... |
|
The job Click to expand the log.I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
|
📌 Commit a9a771bd90354375bccbf63162bc28cf75a94cba has been approved by |
|
⌛ Testing commit a9a771bd90354375bccbf63162bc28cf75a94cba with merge 0eeaf61b8720a53b880dfeefcbdac34ff0997c8c... |
|
The job Click to expand the log.I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
|
💔 Test failed - checks-azure |
a9a771b to
d8612f3
Compare
|
Okay, trying without any modifications to that test. @bors r+ |
|
📌 Commit d8612f3 has been approved by |
[beta] backports This pull request backports the following pull requests, which have all been beta-accepted by the compiler team. * Handle non_exhaustive in borrow checking #66722 * Do not ICE on trait aliases with missing obligations #66392 * Do not ICE in `if` without `else` in `async fn` #66391 * Fix ICE when trying to suggest `Type<>` instead of `Type()` #66390 * Do not ICE on recovery from unmet associated type bound obligation #66388 * find_deprecation: deprecation attr may be ill-formed meta. #66381 * parser: don't use `unreachable!()` in `fn unexpected`. #66361 * Undo an assert causing an ICE until we fix the underlying problem #66250 * Do not ICE with a precision flag in formatting str and no format arguments #66093 * Fix two OOM issues related to `ConstProp` #66394
|
💔 Test failed - checks-azure |
|
The job Click to expand the log.I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
|
@bors retry -- hopefully spurious? None of the PRs we're backporting seem to have anything to do with debuginfo AFAICT. |
[beta] backports This pull request backports the following pull requests, which have all been beta-accepted by the compiler team. * Handle non_exhaustive in borrow checking #66722 * Do not ICE on trait aliases with missing obligations #66392 * Do not ICE in `if` without `else` in `async fn` #66391 * Fix ICE when trying to suggest `Type<>` instead of `Type()` #66390 * Do not ICE on recovery from unmet associated type bound obligation #66388 * find_deprecation: deprecation attr may be ill-formed meta. #66381 * parser: don't use `unreachable!()` in `fn unexpected`. #66361 * Undo an assert causing an ICE until we fix the underlying problem #66250 * Do not ICE with a precision flag in formatting str and no format arguments #66093 * Fix two OOM issues related to `ConstProp` #66394
|
☀️ Test successful - checks-azure |
This pull request backports the following pull requests, which have all been beta-accepted by the
compiler team.
ifwithoutelseinasync fnDo not ICE inifwithoutelseinasync fn#66391Type<>instead ofType()Fix ICE when trying to suggestType<>instead ofType()#66390unreachable!()infn unexpected. parser: don't useunreachable!()infn unexpected. #66361ConstPropFix two OOM issues related toConstProp#66394