Conversation
|
(rust_highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
LukasKalbertodt
left a comment
LukasKalbertodt
left a comment
There was a problem hiding this comment.
The changes look good to me.
@rfcbot fcp merge (@rust-lang/libs can someone do this for me? I am not allowed to)
What is stabilized here? std::sync::Once::is_completed:
pub fn is_completed(&self) -> boolImplemented 1.5 years ago. The tracking issue did not bring up any concerns, so I think this is a pretty straight forward addition and I don't see why it shouldn't be stabilized.
|
The PR originally implementing this also mentioned that doing anything meaningful when the method returns false is likely wrong; do we want to add that to the docs prior to stabilization? |
jonas-schievink
added
relnotes
|
@Mark-Simulacrum I incorporated @nagisa's wording in an attempt to make that clearer. I'm hoping the updated verbiage is sufficient. I'm reluctant to explicitly say "don't do anything meaningful if this returns false" because I think that can be easily misunderstood to mean that the |
|
Yes that seems better. |
|
@rfcbot fcp merge |
|
Team member @Amanieu has proposed to merge this. The next step is review by the rest of the tagged team members: No concerns currently listed. Once a majority of reviewers approve (and at most 2 approvals are outstanding), this will enter its final comment period. If you spot a major issue that hasn't been raised at any point in this process, please speak up! See this document for info about what commands tagged team members can give me. |
rfcbot
added
proposed-final-comment-period
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
rfcbot
added
the
final-comment-period
|
🔔 This is now entering its final comment period, as per the review above. 🔔 |
rfcbot
removed
the
proposed-final-comment-period
rfcbot
added
finished-final-comment-period
|
The final comment period, with a disposition to merge, as per the review above, is now complete. As the automated representative of the governance process, I would like to thank the author for their work and everyone else who contributed. The RFC will be merged soon. |
|
@bors r+ |
|
📌 Commit 348278a has been approved by |
bors
added
S-waiting-on-bors
…albertodt Stabilize Once::is_completed Closes rust-lang#54890 This function has been around for some time. I haven't seen anyone raise any objections to it. I've personally found it useful myself. It would be nice to finally stabilize it and
Rollup of 5 pull requests Successful merges: - #68705 (Add LinkedList::remove()) - #68945 (Stabilize Once::is_completed) - #68978 (Make integer exponentiation methods unstably const) - #69266 (Fix race condition when allocating source files in SourceMap) - #69287 (Clean up E0317 explanation) Failed merges: r? @ghost
|
This PR has the GitHub milestone 1.43 but the stabilization attribute says 1.44.0. Which one is correct? |
…e-since, r=Centril Fix "since" field for `Once::is_complete`'s `#[stable]` attribute It was accidentally merged with the wrong version in rust-lang#68945. Thanks @jplatte for noticing. This also needs to be beta backported.
9 participants
Closes #54890
This function has been around for some time. I haven't seen anyone raise any objections to it. I've personally found it useful myself. It would be nice to finally stabilize it and