Fix race condition when allocating source files in SourceMap#69266
Merged
bors merged 1 commit intorust-lang:masterfrom Feb 20, 2020
Merged
Fix race condition when allocating source files in SourceMap#69266bors merged 1 commit intorust-lang:masterfrom
bors merged 1 commit intorust-lang:masterfrom
Conversation
rust-highfive
added
the
S-waiting-on-review
Contributor
Author
wesleywiser
approved these changes
Feb 18, 2020
Member
wesleywiser
left a comment
wesleywiser
left a comment
There was a problem hiding this comment.
One small comment. If you don't think it's worthwhile, feel free to r=me this.
Contributor
|
cc @matklad |
mlodato517
reviewed
Feb 18, 2020
Contributor
There was a problem hiding this comment.
Found a minor typo and am interested in trying to learn a little more about rust if you have the time to answer some questions :-) Also, I don't see any notes in CONTRIBUTING.md about reviewing PRs so I hope I'm not out of line in reviewing this. If there are some docs regarding when/how to review PRs - please link me to them so I don't make the mistake again.
Member
|
@mlodato517 If you have additional questions feel free to ask! Otherwise I'm going to mark those parts of your review resolved to keep this PR clean. |
Zoxc
force-pushed
the
fix-source-map-race
branch
from
cc4375b to
437f56e
Compare
Contributor
Author
|
@bors r=wesleywiser |
Collaborator
|
📌 Commit 437f56e has been approved by |
bors
added
S-waiting-on-bors
Dylan-DPC-zz
pushed a commit
to Dylan-DPC-zz/rust
that referenced
this pull request
Feb 20, 2020
…iser Fix race condition when allocating source files in SourceMap This makes allocating address space in the source map an atomic operation. `rustc` does not currently do this in parallel, so this bug can't trigger, but parsing files in parallel could trigger it, and that is something we want to do. Fixes rust-lang#69261. r? @wesleywiser
This was referenced Feb 20, 2020
bors
added a commit
that referenced
this pull request
Feb 20, 2020
Rollup of 5 pull requests Successful merges: - #68705 (Add LinkedList::remove()) - #68945 (Stabilize Once::is_completed) - #68978 (Make integer exponentiation methods unstably const) - #69266 (Fix race condition when allocating source files in SourceMap) - #69287 (Clean up E0317 explanation) Failed merges: r? @ghost
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This makes allocating address space in the source map an atomic operation.
rustcdoes not currently do this in parallel, so this bug can't trigger, but parsing files in parallel could trigger it, and that is something we want to do.Fixes #69261.
r? @wesleywiser