move hir_id_validation to rustc_passes + simplify hir::map code#70349
Merged
bors merged 2 commits intorust-lang:masterfrom Mar 25, 2020
Merged
move hir_id_validation to rustc_passes + simplify hir::map code#70349bors merged 2 commits intorust-lang:masterfrom
hir_id_validation to rustc_passes + simplify hir::map code#70349bors merged 2 commits intorust-lang:masterfrom
Conversation
rust-highfive
added
the
S-waiting-on-review
Zoxc
reviewed
Mar 24, 2020
| use crate::hir::map::Map; | ||
| use crate::ty::TyCtxt; | ||
| use rustc::hir::map::Map; | ||
| use rustc::ty::TyCtxt; |
Contributor
There was a problem hiding this comment.
Maybe put this file in a hir folder if you plan to move the collector there too
Contributor
Author
There was a problem hiding this comment.
Hmm; how about doing it if/when the collector is moved? I'm not sure whether I will move it atm.
Contributor
|
@bors r+ |
Collaborator
|
📌 Commit 12e4f9f has been approved by |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Mar 25, 2020
Rollup of 7 pull requests Successful merges: - rust-lang#70331 (Increase verbosity when using update syntax with private fields) - rust-lang#70349 (move `hir_id_validation` to `rustc_passes` + simplify `hir::map` code) - rust-lang#70361 (Update backtrace crate to 0.3.46) - rust-lang#70364 (resolve: Remove `rustc_attrs` as a standalone feature gate) - rust-lang#70369 (Fix smaller issues with invalid placeholder type errors) - rust-lang#70373 (normalize some imports & prefer direct ones) - rust-lang#70376 (Add test for rust-lang#66312) Failed merges: r? @ghost
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
r? @Zoxc