parse: recover on const fn() / async fn()#70421
Conversation
rust-highfive
added
the
S-waiting-on-review
|
cc also @petrochenkov |
Centril
force-pushed
the
recover-const-async-fn-ptr
branch
from
17875f2 to
af1146b
Compare
estebank
left a comment
estebank
left a comment
There was a problem hiding this comment.
I have a small nitpick to maybe take the chance to teach what async fns actually are. If you don't feel that's worth it, r=me.
| error: an `fn` pointer type cannot be `async` | ||
| --> $DIR/recover-const-async-fn-ptr.rs:6:11 | ||
| | | ||
| LL | type T3 = async fn(); | ||
| | -----^^^^^ | ||
| | | | ||
| | `async` because of this | ||
| | help: remove the `async` qualifier |
There was a problem hiding this comment.
Do you feel it would make sense to add some explanation of what async does to functions in the first place? Something along the lines of
error: an `fn` pointer type cannot be `async`
--> $DIR/recover-const-async-fn-ptr.rs:6:11
|
LL | type T3 = async fn();
| -----^^^^^
| |
| `async` because of this
| help: remove the `async` qualifier
= note: `async` functions only modify the return type of the function to be wrapped in a `std::future::Future<Output = ReturnType>`, an `async fn()` would be the same as `fn() -> Future<Output = ()>`
There was a problem hiding this comment.
That would have to be fn() -> Box<dyn Future<Output = ()>> or some such as fn() -> impl A is not valid. I think I'd prefer to keep things simple now, as I did this PR mostly as a refactoring (improving diagnostics is secondary).
| /// Emit an error for the given bad function pointer qualifier. | ||
| fn error_fn_ptr_bad_qualifier(&self, span: Span, qual_span: Span, qual: &str) { | ||
| self.struct_span_err(span, &format!("an `fn` pointer type cannot be `{}`", qual)) | ||
| .span_label(qual_span, format!("`{}` because of this", qual)) | ||
| .span_suggestion_short( | ||
| qual_span, | ||
| &format!("remove the `{}` qualifier", qual), | ||
| String::new(), | ||
| Applicability::MaybeIncorrect, | ||
| ) | ||
| .emit(); | ||
| } |
There was a problem hiding this comment.
Could we move this to parser/diagnostics.rs?
There was a problem hiding this comment.
I generally prefer to keep parsing of various things more self-contained, and diagnostics.rs is larger than ty.rs in any case. :)
|
@bors r=estebank |
|
📌 Commit af1146b has been approved by |
bors
added
S-waiting-on-bors
Rollup of 8 pull requests Successful merges: - rust-lang#70281 (Implement Hash for Infallible) - rust-lang#70421 (parse: recover on `const fn()` / `async fn()`) - rust-lang#70615 (Renamed `PerDefTables` to `Tables`) - rust-lang#70631 (Update cargo) - rust-lang#70634 (Remove some reexports in `rustc_middle`) - rust-lang#70658 (add `STILL_FURTHER_SPECIALIZABLE` flag) - rust-lang#70678 (Add missing markdown rust annotation) - rust-lang#70681 (Handle unterminated raw strings with no #s properly) Failed merges: r? @ghost
4 participants
Recover on
const fn()andasync fn()function pointers, suggesting to remove the qualifier.For example:
r? @estebank