Conversation
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @ecstatic-morse (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
rust-highfive
added
the
S-waiting-on-review
There was a problem hiding this comment.
Not relevant to this PR necessarily but we should probably encode the DefPathTable as an actual Table.
There was a problem hiding this comment.
Harder to do without splitting DefPathTable into several tables, though.
|
r? @eddyb |
|
r? @oli-obk |
|
@bors r+ This was much more self-contained than I would have thought from the title. |
|
📌 Commit dca3782 has been approved by |
bors
added
S-waiting-on-bors
Renamed `PerDefTables` to `Tables` Originally suggested by @eddyb
Rollup of 8 pull requests Successful merges: - rust-lang#70281 (Implement Hash for Infallible) - rust-lang#70421 (parse: recover on `const fn()` / `async fn()`) - rust-lang#70615 (Renamed `PerDefTables` to `Tables`) - rust-lang#70631 (Update cargo) - rust-lang#70634 (Remove some reexports in `rustc_middle`) - rust-lang#70658 (add `STILL_FURTHER_SPECIALIZABLE` flag) - rust-lang#70678 (Add missing markdown rust annotation) - rust-lang#70681 (Handle unterminated raw strings with no #s properly) Failed merges: r? @ghost
6 participants
Originally suggested by @eddyb