Cleanup and document -Z tls-model #71558
Merged
bors merged 2 commits intorust-lang:masterfrom Apr 28, 2020
Merged
Conversation
rust-highfive
added
the
S-waiting-on-review
Amanieu
reviewed
Apr 25, 2020
Member
Amanieu
left a comment
Amanieu
left a comment
There was a problem hiding this comment.
Some clarifications for the documentation.
Member
There was a problem hiding this comment.
Technically speaking, the TLS model is supposed to be a per-variable attribute rather than a global one. However we don't currently have such an attribute, only a global setting which sets the default TLS model for all variables.
Contributor
Author
|
Updated. |
Member
|
@bors r+ |
Collaborator
|
📌 Commit 66e41723c8694612efddd2f2e6d70abc557f61f3 has been approved by |
bors
added
S-waiting-on-bors
Collaborator
|
☔ The latest upstream changes (presumably #71579) made this pull request unmergeable. Please resolve the merge conflicts. |
bors
added
S-waiting-on-author
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Apr 26, 2020
Rollup of 5 pull requests Successful merges: - rust-lang#71421 (Add a function to turn Box<T> into Box<[T]>) - rust-lang#71537 (Remove support for self-opening) - rust-lang#71551 (Minor refactoring around IndexVec usage in generator transformation) - rust-lang#71569 ([miri] Throw UB if target size and data size don't match) - rust-lang#71576 (check that `AsRef` and `AsMut` are inlined) Failed merges: - rust-lang#71558 (Cleanup and document `-Z tls-model` ) r? @ghost
Introduce `enum TlsModel` instead.
Contributor
Author
|
@bors r=Amanieu |
Collaborator
|
📌 Commit 45dc435 has been approved by |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Apr 27, 2020
Rollup of 7 pull requests Successful merges: - rust-lang#67841 (Add Read/Write::can_read/write_vectored) - rust-lang#71524 (Minimize parameter of coerce_borrowed_pointer()) - rust-lang#71558 (Cleanup and document `-Z tls-model` ) - rust-lang#71578 (linkchecker: fix typo in main.rs) - rust-lang#71596 (Fix broken link in `QPath` documentation) - rust-lang#71604 (make recursive-zst test unleashed) - rust-lang#71605 (No need to whitelist E0750 anymore) Failed merges: r? @ghost
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
r? @Amanieu