Conversation
Comparing two array directly helps generate better assert message
rust-highfive
added
the
S-waiting-on-review
LukasKalbertodt
suggested changes
Jul 16, 2020
Contributor
LukasKalbertodt
left a comment
LukasKalbertodt
left a comment
There was a problem hiding this comment.
Thanks for fixing this!
| assert!( | ||
| combine(CLOEXEC_MSG_FOOTER) == combine(footer.try_into().unwrap()), | ||
| assert_eq!( | ||
| CLOEXEC_MSG_FOOTER, footer, |
Contributor
There was a problem hiding this comment.
I think rustfmt will dislike that. footer, should be in a newline.
Contributor
Author
There was a problem hiding this comment.
I thought so. But rustfmt wants the current format.
Contributor
There was a problem hiding this comment.
Wow... that is very unexpected to me. Interesting.
LukasKalbertodt
approved these changes
Jul 19, 2020
Contributor
|
@bors r+ rollup=iffy |
Collaborator
|
📌 Commit afbfe60 has been approved by |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jul 19, 2020
…arth Rollup of 4 pull requests Successful merges: - rust-lang#74333 (Deny unsafe operations in unsafe functions in libstd/alloc.rs) - rust-lang#74356 (Remove combine function) - rust-lang#74419 (Add a thumbv4t-none-eabi target) - rust-lang#74485 (More intra-doc links, add explicit exception list to linkchecker) Failed merges: - rust-lang#74486 (Improve Read::read_exact documentation) r? @ghost
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Comparing two array directly helps generate better assert message.
Resolve https://github.com/rust-lang/rust/pull/74271/files#r454538514