Improve Read::read_exact documentation#74486
Merged
bors merged 3 commits intorust-lang:masterfrom Jul 20, 2020
Merged
Conversation
rustbot
added
C-enhancement
Contributor
|
(rust_highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
jyn514
reviewed
Jul 19, 2020
Member
|
r=me with @jyn514's nit fixed |
Contributor
Author
|
@Mark-Simulacrum Done, I checked it locally to ensure the pointed method stayed the same, CI should confirm the whole thing compiles too :) |
Member
|
@bors r=Mark-Simulacrum rollup=always |
Collaborator
|
📌 Commit e88220f has been approved by |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jul 19, 2020
…arth Rollup of 4 pull requests Successful merges: - rust-lang#74333 (Deny unsafe operations in unsafe functions in libstd/alloc.rs) - rust-lang#74356 (Remove combine function) - rust-lang#74419 (Add a thumbv4t-none-eabi target) - rust-lang#74485 (More intra-doc links, add explicit exception list to linkchecker) Failed merges: - rust-lang#74486 (Improve Read::read_exact documentation) r? @ghost
Collaborator
|
☔ The latest upstream changes (presumably #74518) made this pull request unmergeable. Please resolve the merge conflicts. |
bors
added
S-waiting-on-author
Member
|
@bors r=Mark-Simulacrum rollup=always |
Collaborator
|
📌 Commit 471dd52 has been approved by |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jul 20, 2020
…arth Rollup of 9 pull requests Successful merges: - rust-lang#73618 (Documentation for the false keyword) - rust-lang#74486 (Improve Read::read_exact documentation) - rust-lang#74514 (Do not clobber RUSTDOCFLAGS) - rust-lang#74516 (do not try fetching the ancestors of errored trait impls) - rust-lang#74520 (include backtrace folder in rust-src component) - rust-lang#74523 (Improve documentation for `core::fmt` internals) - rust-lang#74527 (Add myself to toolstate change notifications for rustfmt) - rust-lang#74534 (Only skip impls of foreign unstable traits) - rust-lang#74536 (fix documentation surrounding the `in` and `for` keywords) Failed merges: r? @ghost
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #72186.
For now I simply added a link to
Read::readand held off changing the text inRead::read_exact. I can do it if it is deemed necessary.@rustbot modify labels: C-enhancement, T-libs