fix documentation surrounding the in and for keywords#74536
Merged
bors merged 4 commits intorust-lang:masterfrom Jul 20, 2020
Merged
fix documentation surrounding the in and for keywords#74536bors merged 4 commits intorust-lang:masterfrom
in and for keywords#74536bors merged 4 commits intorust-lang:masterfrom
Conversation
Contributor
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @joshtriplett (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
rust-highfive
added
the
S-waiting-on-review
Nicholas-Baron
changed the title
in and for keywordsin and for keywords
Clear up wording regarding the iterator and usage of `break`. Co-authored-by: Josh Triplett <josh@joshtriplett.org>
Member
|
@bors r+ rollup |
Collaborator
|
📌 Commit 09d5529 has been approved by |
bors
added
S-waiting-on-bors
Member
|
Thanks! |
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jul 20, 2020
…arth Rollup of 9 pull requests Successful merges: - rust-lang#73618 (Documentation for the false keyword) - rust-lang#74486 (Improve Read::read_exact documentation) - rust-lang#74514 (Do not clobber RUSTDOCFLAGS) - rust-lang#74516 (do not try fetching the ancestors of errored trait impls) - rust-lang#74520 (include backtrace folder in rust-src component) - rust-lang#74523 (Improve documentation for `core::fmt` internals) - rust-lang#74527 (Add myself to toolstate change notifications for rustfmt) - rust-lang#74534 (Only skip impls of foreign unstable traits) - rust-lang#74536 (fix documentation surrounding the `in` and `for` keywords) Failed merges: r? @ghost
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses #74529
The
inkeyword incorrectly referenced theIteratortrait. This reference was changed toIntoIteratorwithout changing the underlying link.Additionally, the
IntoIteratortrait was referenced towards the end of the documentation forfor. An additional reference was added earlier and broadened the existing documentation from any iterator to anything that can be turned into an iterator.