Documentation for the false keyword#73618

poliorcetics · 2020-06-22T13:17:31Z

Partial fix of #34601.

Short documentation for the false keyword mainly pointing to the true keyword.

rust-highfive · 2020-06-22T13:17:34Z

r? @kennytm

(rust_highfive has picked a reviewer for you, use r? to override)

poliorcetics · 2020-06-22T14:39:01Z

@rustbot modify labels: T-doc,C-enhancement

rust-highfive · 2020-06-22T14:58:58Z

The job x86_64-gnu-llvm-8 of your PR failed (pretty log, raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

##[section]Starting: Linux x86_64-gnu-llvm-8
##[section]Starting: Initialize job
Agent name: 'Azure Pipelines 2'
Agent machine name: 'fv-az578'
Current agent version: '2.170.1'
##[group]Operating System
16.04.6
LTS
LTS
##[endgroup]
##[group]Virtual Environment
Environment: ubuntu-16.04
Version: 20200614.1
Included Software: https://github.com/actions/virtual-environments/blob/ubuntu16/20200614.1/images/linux/Ubuntu1604-README.md
##[endgroup]
Agent running as: 'vsts'
Prepare build directory.
Set build variables.
Download all required tasks.
Download all required tasks.
Downloading task: Bash (3.163.3)
Checking job knob settings.
   Knob: AgentToolsDirectory = /opt/hostedtoolcache Source: ${AGENT_TOOLSDIRECTORY} 
   Knob: AgentPerflog = /home/vsts/perflog Source: ${VSTS_AGENT_PERFLOG} 
Start tracking orphan processes.
##[section]Finishing: Initialize job
##[section]Starting: Configure Job Name
==============================================================================
---
========================== Starting Command Output ===========================
[command]/bin/bash --noprofile --norc /home/vsts/work/_temp/a969e977-aefd-4648-a656-112a747cb09b.sh

##[section]Finishing: Disable git automatic line ending conversion
##[section]Starting: Checkout rust-lang/rust@refs/pull/73618/merge to s
Task         : Get sources
Description  : Get sources from a repository. Supports Git, TfsVC, and SVN repositories.
Version      : 1.0.0
Author       : Microsoft
---
##[command]git remote add origin https://github.com/rust-lang/rust
##[command]git config gc.auto 0
##[command]git config --get-all http.https://github.com/rust-lang/rust.extraheader
##[command]git config --get-all http.proxy
##[command]git -c http.extraheader="AUTHORIZATION: basic ***" fetch --force --tags --prune --progress --no-recurse-submodules --depth=2 origin +refs/heads/*:refs/remotes/origin/* +refs/pull/73618/merge:refs/remotes/pull/73618/merge
---
 ---> 31fea614d2f3
Step 5/8 : ENV RUST_CONFIGURE_ARGS       --build=x86_64-unknown-linux-gnu       --llvm-root=/usr/lib/llvm-8       --enable-llvm-link-shared       --set rust.thin-lto-import-instr-limit=10
 ---> Using cache
 ---> 4195cadf126d
Step 6/8 : ENV SCRIPT python2.7 ../x.py test --exclude src/tools/tidy &&            python2.7 ../x.py test src/test/mir-opt --pass=build                                   --target=armv5te-unknown-linux-gnueabi &&            python2.7 ../x.py test src/tools/tidy
 ---> 4e90f6b48f05
Step 7/8 : ENV NO_DEBUG_ASSERTIONS=1
 ---> Using cache
 ---> dfa0a356d899
---
Set({"src/librustc_parse_format"}) not skipped for "bootstrap::test::CrateLibrustc" -- not in ["src/tools/tidy"]
Set({"src/librustc_passes"}) not skipped for "bootstrap::test::CrateLibrustc" -- not in ["src/tools/tidy"]
Set({"src/librustc_plugin_impl"}) not skipped for "bootstrap::test::CrateLibrustc" -- not in ["src/tools/tidy"]
Set({"src/librustc_privacy"}) not skipped for "bootstrap::test::CrateLibrustc" -- not in ["src/tools/tidy"]
Set({"src/librustc_query_system"}) not skipped for "bootstrap::test::CrateLibrustc" -- not in ["src/tools/tidy"]
Set({"src/librustc_save_analysis"}) not skipped for "bootstrap::test::CrateLibrustc" -- not in ["src/tools/tidy"]
Set({"src/librustc_serialize"}) not skipped for "bootstrap::test::CrateLibrustc" -- not in ["src/tools/tidy"]
Set({"src/librustc_session"}) not skipped for "bootstrap::test::CrateLibrustc" -- not in ["src/tools/tidy"]
Set({"src/librustc_span"}) not skipped for "bootstrap::test::CrateLibrustc" -- not in ["src/tools/tidy"]
---
Set({"src/librustc_parse_format"}) not skipped for "bootstrap::doc::Rustc" -- not in ["src/tools/tidy"]
Set({"src/librustc_passes"}) not skipped for "bootstrap::doc::Rustc" -- not in ["src/tools/tidy"]
Set({"src/librustc_plugin_impl"}) not skipped for "bootstrap::doc::Rustc" -- not in ["src/tools/tidy"]
Set({"src/librustc_privacy"}) not skipped for "bootstrap::doc::Rustc" -- not in ["src/tools/tidy"]
Set({"src/librustc_query_system"}) not skipped for "bootstrap::doc::Rustc" -- not in ["src/tools/tidy"]
Set({"src/librustc_save_analysis"}) not skipped for "bootstrap::doc::Rustc" -- not in ["src/tools/tidy"]
Set({"src/librustc_serialize"}) not skipped for "bootstrap::doc::Rustc" -- not in ["src/tools/tidy"]
Set({"src/librustc_session"}) not skipped for "bootstrap::doc::Rustc" -- not in ["src/tools/tidy"]
Set({"src/librustc_span"}) not skipped for "bootstrap::doc::Rustc" -- not in ["src/tools/tidy"]
---
   Compiling rustc_parse_format v0.0.0 (/checkout/src/librustc_parse_format)
   Compiling chalk-engine v0.11.0
   Compiling rustc_ast_pretty v0.0.0 (/checkout/src/librustc_ast_pretty)
   Compiling rustc_hir v0.0.0 (/checkout/src/librustc_hir)
   Compiling rustc_query_system v0.0.0 (/checkout/src/librustc_query_system)
   Compiling chalk-solve v0.11.0
   Compiling rustc_hir_pretty v0.0.0 (/checkout/src/librustc_hir_pretty)
   Compiling rustc_parse v0.0.0 (/checkout/src/librustc_parse)
   Compiling rustc_ast_lowering v0.0.0 (/checkout/src/librustc_ast_lowering)
---
   Compiling rustc_parse_format v0.0.0 (/checkout/src/librustc_parse_format)
   Compiling chalk-ir v0.11.0
   Compiling rustc_ast_pretty v0.0.0 (/checkout/src/librustc_ast_pretty)
   Compiling rustc_hir v0.0.0 (/checkout/src/librustc_hir)
   Compiling rustc_query_system v0.0.0 (/checkout/src/librustc_query_system)
   Compiling chalk-engine v0.11.0
   Compiling rustc_hir_pretty v0.0.0 (/checkout/src/librustc_hir_pretty)
   Compiling chalk-solve v0.11.0
   Compiling rustc_parse v0.0.0 (/checkout/src/librustc_parse)
---
..............i..................................................................................... 1900/10374
.................................................................................................... 2000/10374
........................................i..i........................................................ 2100/10374
.................................................................................................... 2200/10374
..............................iiiii................................................................. 2300/10374
.................................................................................................... 2500/10374
.................................................................................................... 2600/10374
.................................................................................................... 2700/10374
.................................................................................................... 2800/10374
---
.................................................................................................... 5300/10374
.................................................................................................... 5400/10374
..................i................................................................................. 5500/10374
............i....................................................................................... 5600/10374
................................ii.ii........i...i.................................................. 5700/10374
.i...............................................................................................i.. 5900/10374
.................................................................................................... 6000/10374
...................................................ii.....................................i......... 6100/10374
.................................................................................................... 6200/10374
.................................................................................................... 6200/10374
.................................................................................................... 6300/10374
.................................................................................................... 6400/10374
..............ii...i..ii...........i................................................................ 6500/10374
.................................................................................................... 6700/10374
.................................................................................................... 6800/10374
.................................................................................................... 6800/10374
................................................i..ii............................................... 6900/10374
.................................................................................................... 7100/10374
.................................................................................................... 7200/10374
....i............................................................................................... 7300/10374
.................................................................................................... 7400/10374
---
.................................................................................................... 8300/10374
.................................................................................................... 8400/10374
.................................................i.................................................. 8500/10374
.................................................................................................... 8600/10374
....iiiiii.iiiiii.i................................................................................. 8700/10374
.................................................................................................... 8900/10374
.................................................................................................... 9000/10374
.................................................................................................... 9100/10374
.................................................................................................... 9200/10374
---
Suite("src/test/codegen") not skipped for "bootstrap::test::Codegen" -- not in ["src/tools/tidy"]
Check compiletest suite=codegen mode=codegen (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)

running 197 tests
iiii......i................ii.i..........i......................i...........i..i........i........i.. 100/197
..i.............i.i.i...iii..iiii....................................iii.................ii......

 finished in 6.119
Suite("src/test/codegen-units") not skipped for "bootstrap::test::CodegenUnits" -- not in ["src/tools/tidy"]
Check compiletest suite=codegen-units mode=codegen-units (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
---
Suite("src/test/assembly") not skipped for "bootstrap::test::Assembly" -- not in ["src/tools/tidy"]
Check compiletest suite=assembly mode=assembly (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)

running 22 tests
iiiiiiiiiiiiiiiiiiiiii

 finished in 0.133
Suite("src/test/incremental") not skipped for "bootstrap::test::Incremental" -- not in ["src/tools/tidy"]
Check compiletest suite=incremental mode=incremental (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
---
Suite("src/test/debuginfo") not skipped for "bootstrap::test::Debuginfo" -- not in ["src/tools/tidy"]
Check compiletest suite=debuginfo mode=debuginfo (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)

running 116 tests
iiiii..i.....i..i...i..i.i.i..i..i..ii.....ii....ii..........iiii.........i.....i...i.......ii.i.ii. 100/116
....iiii.....ii.

 finished in 13.764
Uplifting stage1 rustc (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
Copying stage2 rustc from stage1 (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu / x86_64-unknown-linux-gnu)
---

   Doc-tests core

running 2585 tests
......iiiii......................................................................................... 100/2585
.................................................................................................ii. 200/2585
.......................................i............................................................ 400/2585
...............................................................................................i..i. 500/2585
...............................................................................................i..i. 500/2585
.................iiii............................................................................... 600/2585
.................................................................................................... 800/2585
.................................................................................................... 900/2585
.................................................................................................... 1000/2585
.................................................................................................... 1100/2585
---
.................................................................................................... 500/769
...........................thread '<unnamed>' panicked at 'called `Result::unwrap()` on an `Err` value: RecvError', src/libstd/sync/mpsc/mod.rs:2740:32
....thread '<unnamed>' panicked at 'called `Result::unwrap()` on an `Err` value: "SendError(..)"', src/libstd/sync/mpsc/mod.rs:2765:28
.thread '<unnamed>' panicked at 'called `Result::unwrap()` on an `Err` value: RecvError', src/libstd/sync/mpsc/mod.rs:2777:31
......thread '<unnamed>' panicked at 'called `Result::unwrap()` on an `Err` value: RecvError', src/libstd/sync/mpsc/mod.rs:2644:23
..........................................thread '<unnamed>' panicked at 'called `Result::unwrap()` on an `Err` value: RecvError', src/libstd/sync/mpsc/mod.rs:1997:32
....thread '.<unnamed>' panicked at 'called `Result::unwrap()` on an `Err` value: RecvError', src/libstd/sync/mpsc/mod.rs:2034:31
......thread '<unnamed>' panicked at 'called `Result::unwrap()` on an `Err` value: RecvError', src/libstd/sync/mpsc/mod.rs:1916:23
.............................thread '<unnamed>' panicked at 'explicit panic', src/libstd/sync/mutex.rs:688:13
..thread '<unnamed>' panicked at 'test panic in inner thread to poison mutex', src/libstd/sync/mutex.rs:642:13
...thread '<unnamed>' panicked at 'test panic in inner thread to poison mutex', src/libstd/sync/mutex.rs:618:13
.thread '<unnamed>' panicked at 'explicit panic', src/libstd/sync/mutex.rs:749:13
---

running 1027 tests
i................................................................................................... 100/1027
.................................................................................................... 200/1027
...................iii......i......i...i.........i.................................................. 300/1027
..........................................................i....i.................................... 500/1027
...ii............................................................................................... 600/1027
.................................................................................................... 700/1027
.................................................................................................... 700/1027
...................................................iiii............................................. 800/1027
.................................................................................................... 900/1027
..........................................................................iiii...................... 1000/1027
test result: ok. 1007 passed; 0 failed; 20 ignored; 0 measured; 0 filtered out

 finished in 142.296
Set({"src/libterm"}) not skipped for "bootstrap::test::Crate" -- not in ["src/tools/tidy"]
---
Set({"src/librustc_parse_format"}) not skipped for "bootstrap::test::CrateLibrustc" -- not in ["src/tools/tidy"]
Set({"src/librustc_passes"}) not skipped for "bootstrap::test::CrateLibrustc" -- not in ["src/tools/tidy"]
Set({"src/librustc_plugin_impl"}) not skipped for "bootstrap::test::CrateLibrustc" -- not in ["src/tools/tidy"]
Set({"src/librustc_privacy"}) not skipped for "bootstrap::test::CrateLibrustc" -- not in ["src/tools/tidy"]
Set({"src/librustc_query_system"}) not skipped for "bootstrap::test::CrateLibrustc" -- not in ["src/tools/tidy"]
Set({"src/librustc_save_analysis"}) not skipped for "bootstrap::test::CrateLibrustc" -- not in ["src/tools/tidy"]
Set({"src/librustc_serialize"}) not skipped for "bootstrap::test::CrateLibrustc" -- not in ["src/tools/tidy"]
Set({"src/librustc_session"}) not skipped for "bootstrap::test::CrateLibrustc" -- not in ["src/tools/tidy"]
Set({"src/librustc_span"}) not skipped for "bootstrap::test::CrateLibrustc" -- not in ["src/tools/tidy"]
---
Set({"src/librustc_parse_format"}) not skipped for "bootstrap::doc::Rustc" -- not in ["src/tools/tidy"]
Set({"src/librustc_passes"}) not skipped for "bootstrap::doc::Rustc" -- not in ["src/tools/tidy"]
Set({"src/librustc_plugin_impl"}) not skipped for "bootstrap::doc::Rustc" -- not in ["src/tools/tidy"]
Set({"src/librustc_privacy"}) not skipped for "bootstrap::doc::Rustc" -- not in ["src/tools/tidy"]
Set({"src/librustc_query_system"}) not skipped for "bootstrap::doc::Rustc" -- not in ["src/tools/tidy"]
Set({"src/librustc_save_analysis"}) not skipped for "bootstrap::doc::Rustc" -- not in ["src/tools/tidy"]
Set({"src/librustc_serialize"}) not skipped for "bootstrap::doc::Rustc" -- not in ["src/tools/tidy"]
Set({"src/librustc_session"}) not skipped for "bootstrap::doc::Rustc" -- not in ["src/tools/tidy"]
Set({"src/librustc_span"}) not skipped for "bootstrap::doc::Rustc" -- not in ["src/tools/tidy"]
---
Suite("src/test/run-make-fulldeps") not skipped for "bootstrap::test::RunMakeFullDeps" -- not in ["src/tools/tidy"]
Check compiletest suite=run-make-fulldeps mode=run-make (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)

running 212 tests
......................i...ii........................................................................ 100/212
i........................................iiiiii......i..............iii............................. 200/212
........ii..

 finished in 63.007
Set({"src/doc/rustdoc"}) not skipped for "bootstrap::test::RustdocBook" -- not in ["src/tools/tidy"]
doc tests for: /checkout/src/doc/rustdoc/src/advanced-features.md
---
doc tests for: /checkout/src/doc/rustc/src/targets/index.md
doc tests for: /checkout/src/doc/rustc/src/what-is-rustc.md
 finished in 3.769
Set({"src/test/rustdoc-js-std"}) not skipped for "bootstrap::test::RustdocJSStd" -- not in ["src/tools/tidy"]
Checking "alias-1" ... OK
Checking "alias-2" ... OK
Checking "alias-3" ... OK
Checking "alias" ... OK
Checking "basic" ... OK
Checking "deduplication" ... OK
Checking "enum-option" ... OK
Checking "filter-crate" ... OK
Checking "fn-forget" ... OK
Checking "from_u" ... OK
Checking "keyword" ... OK
Checking "macro-check" ... OK
Checking "macro-print" ... OK
Checking "multi-query" ... OK
Checking "never" ... OK
Checking "quoted" ... OK
Checking "return-specific-literal" ... OK
Checking "return-specific" ... OK
Checking "should-fail" ... OK
Checking "string-from_ut" ... OK
Checking "struct-vec" ... OK
Checking "vec-new" ... OK
Check compiletest suite=rustdoc-js mode=js-doc-test (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)

running 7 tests
.......
---
Suite("src/test/run-make") not skipped for "bootstrap::test::RunMake" -- not in ["src/tools/tidy"]
Check compiletest suite=run-make mode=run-make (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)

running 14 tests
.iiiiiiii.iii.

 finished in 0.537
Build completed successfully in 1:34:35
Build completed successfully in 1:34:35
+ python2.7 ../x.py test src/test/mir-opt --pass=build --target=armv5te-unknown-linux-gnueabi
Building stage0 std artifacts (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
    Finished release [optimized] target(s) in 0.22s
Copying stage0 std from stage0 (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu / x86_64-unknown-linux-gnu)
Building stage0 compiler artifacts (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @rust-lang/infra. (Feature Requests)

poliorcetics · 2020-06-22T15:08:47Z

This is the error:

2020-06-22T14:58:34.7710007Z Building stage0 tool compiletest (x86_64-unknown-linux-gnu)
2020-06-22T14:58:34.9722276Z     Finished release [optimized] target(s) in 0.19s
2020-06-22T14:58:34.9948392Z Check compiletest suite=mir-opt mode=mir-opt (x86_64-unknown-linux-gnu -> armv5te-unknown-linux-gnueabi)
2020-06-22T14:58:35.1711736Z 
2020-06-22T14:58:35.1712134Z running 110 tests
2020-06-22T14:58:43.6758586Z ..............................................................i..................................... 100/110
2020-06-22T14:58:44.4790181Z ..........
2020-06-22T14:58:44.4791879Z test result: ok. 109 passed; 0 failed; 1 ignored; 0 measured; 0 filtered out
2020-06-22T14:58:44.4792098Z 
2020-06-22T14:58:44.4797973Z 	finished in 9.485
2020-06-22T14:58:44.4852548Z Build completed successfully in 0:01:16
2020-06-22T14:58:44.4861227Z + python2.7 ../x.py test src/tools/tidy
2020-06-22T14:58:44.7099048Z     Finished dev [unoptimized] target(s) in 0.17s
2020-06-22T14:58:44.8789960Z Building stage0 tool tidy (x86_64-unknown-linux-gnu)
2020-06-22T14:58:45.0540868Z    Compiling tidy v0.1.0 (/checkout/src/tools/tidy)
2020-06-22T14:58:45.6805014Z     Finished release [optimized] target(s) in 0.80s
2020-06-22T14:58:45.6911437Z tidy check
2020-06-22T14:58:48.5364510Z * 607 error codes
2020-06-22T14:58:48.5365253Z * highest error code: E0764
2020-06-22T14:58:48.9013583Z * 291 features
2020-06-22T14:58:49.8030201Z thread 'main' panicked at 'cmd.exec() failed with Error during execution of `cargo metadata`:  Downloading crates ...
2020-06-22T14:58:49.8031384Z warning: spurious network error (2 tries remaining): failed to get 200 response from `https://crates.io/api/v1/crates/futures/0.1.28/download`, got 503
2020-06-22T14:58:49.8032007Z warning: spurious network error (1 tries remaining): failed to get 200 response from `https://crates.io/api/v1/crates/futures/0.1.28/download`, got 503
2020-06-22T14:58:49.8032528Z error: failed to download from `https://crates.io/api/v1/crates/futures/0.1.28/download`
2020-06-22T14:58:49.8032780Z 
2020-06-22T14:58:49.8032900Z Caused by:
2020-06-22T14:58:49.8033204Z   failed to get 200 response from `https://crates.io/api/v1/crates/futures/0.1.28/download`, got 503
2020-06-22T14:58:49.8033804Z ', src/tools/tidy/src/deps.rs:197:20
2020-06-22T14:58:49.8034286Z note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
2020-06-22T14:58:49.8037305Z 
2020-06-22T14:58:49.8037473Z 
2020-06-22T14:58:49.8038772Z command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-tools-bin/tidy" "/checkout/src" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo"
2020-06-22T14:58:49.8039211Z expected success, got: exit code: 101
2020-06-22T14:58:49.8039350Z 
2020-06-22T14:58:49.8039426Z 
2020-06-22T14:58:49.8042832Z failed to run: /checkout/obj/build/bootstrap/debug/bootstrap test src/tools/tidy
2020-06-22T14:58:49.8043160Z Build completed unsuccessfully in 0:00:05
2020-06-22T14:58:49.8089498Z == clock drift check ==
2020-06-22T14:58:49.8109861Z   local time: Mon Jun 22 14:58:49 UTC 2020
2020-06-22T14:58:49.9848862Z   network time: Mon, 22 Jun 2020 14:58:49 GMT
2020-06-22T14:58:49.9853495Z == end clock drift check ==
2020-06-22T14:58:52.9605408Z 
2020-06-22T14:58:52.9679961Z ##[error]Bash exited with code '1'.
2020-06-22T14:58:52.9693855Z ##[section]Finishing: Run build

Is it something I did ?

kennytm · 2020-06-22T16:15:14Z

no, just spurious network error

kennytm · 2020-06-22T16:16:50Z

r? @GuillaumeGomez

poliorcetics · 2020-06-24T11:55:20Z

@bors try

bors · 2020-06-24T11:55:22Z

@poliorcetics: 🔑 Insufficient privileges: not in try users

src/libstd/keyword_docs.rs

jyn514 · 2020-07-19T14:07:50Z

bors try

@poliorcetics this doesn't retry the PR build, it runs the full test suite on every platform. Most of the time just rebasing and force-pushing should be enough.

src/libstd/keyword_docs.rs

Co-authored-by: Joshua Nelson <joshua@yottadb.com>

jyn514 · 2020-07-19T14:30:32Z

@bors r+ rollup=always

bors · 2020-07-19T14:30:34Z

📌 Commit a459fc4 has been approved by jyn514

jyn514 · 2020-07-19T14:31:05Z

If @GuillaumeGomez has concerns we can always address them in a follow-up PR :)

Documentation for the false keyword Partial fix of rust-lang#34601. Short documentation for the false keyword mainly pointing to the `true` keyword.

@ghost

…arth Rollup of 9 pull requests Successful merges: - rust-lang#73618 (Documentation for the false keyword) - rust-lang#74486 (Improve Read::read_exact documentation) - rust-lang#74514 (Do not clobber RUSTDOCFLAGS) - rust-lang#74516 (do not try fetching the ancestors of errored trait impls) - rust-lang#74520 (include backtrace folder in rust-src component) - rust-lang#74523 (Improve documentation for `core::fmt` internals) - rust-lang#74527 (Add myself to toolstate change notifications for rustfmt) - rust-lang#74534 (Only skip impls of foreign unstable traits) - rust-lang#74536 (fix documentation surrounding the `in` and `for` keywords) Failed merges: r? @ghost

rust-highfive assigned kennytm Jun 22, 2020

rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jun 22, 2020

poliorcetics mentioned this pull request Jun 22, 2020

Add documentation for all keywords like the primitive types' documentation #34601

Closed

rustbot added C-enhancement Category: An issue proposing an enhancement or a PR with one. A-docs Area: Documentation for any part of the project, including the compiler, standard library, and tools labels Jun 22, 2020

rust-highfive assigned GuillaumeGomez and unassigned kennytm Jun 22, 2020

Short documentation for the false keyword

249e07b

poliorcetics force-pushed the false-keyword branch from e1483e3 to 249e07b Compare June 24, 2020 12:54

crlf0710 added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 10, 2020

jyn514 reviewed Jul 19, 2020

View reviewed changes

src/libstd/keyword_docs.rs Outdated Show resolved Hide resolved

jyn514 mentioned this pull request Jul 19, 2020

Intra-doc links do not resolve for value keywords #74515

Closed

Remove useless link to bool primitive

b7bf3c8

jyn514 reviewed Jul 19, 2020

View reviewed changes

src/libstd/keyword_docs.rs Outdated Show resolved Hide resolved

Apply suggestions from review

a459fc4

Co-authored-by: Joshua Nelson <joshua@yottadb.com>

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 19, 2020

Manishearth mentioned this pull request Jul 19, 2020

Rollup of 6 pull requests #74530

Closed

Manishearth mentioned this pull request Jul 20, 2020

Rollup of 9 pull requests #74543

Merged

Manishearth mentioned this pull request Jul 20, 2020

Rollup of 2 pull requests #74544

Closed

bors merged commit d527c7d into rust-lang:master Jul 20, 2020

poliorcetics deleted the false-keyword branch July 20, 2020 06:30

jyn514 mentioned this pull request Aug 3, 2020

Add support for "true"/"false" intra doc link #75101

Closed

cuviper added this to the 1.47.0 milestone May 2, 2024

Uh oh!

Conversation

poliorcetics commented Jun 22, 2020

Uh oh!

rust-highfive commented Jun 22, 2020

Uh oh!

poliorcetics commented Jun 22, 2020

Uh oh!

rust-highfive commented Jun 22, 2020

Uh oh!

poliorcetics commented Jun 22, 2020

Uh oh!

kennytm commented Jun 22, 2020

Uh oh!

kennytm commented Jun 22, 2020

Uh oh!

poliorcetics commented Jun 24, 2020

Uh oh!

bors commented Jun 24, 2020

Uh oh!

Uh oh!

jyn514 commented Jul 19, 2020

Uh oh!

Uh oh!

jyn514 commented Jul 19, 2020

Uh oh!

bors commented Jul 19, 2020

Uh oh!

jyn514 commented Jul 19, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

9 participants