Upload builds from GHA instead of Azure Pipelines#74565

emilyalbini · 2020-07-20T15:47:11Z

This PR does two things:

Enables RLA comments on PRs (needed after the switch to GHA in RLA).
Switches GitHub Actions as the CI authorized to upload non-macOS builds.

Note that Docker/LLVM caches will likely be busted.

emilyalbini · 2020-07-20T15:47:25Z

@bors rollup=never p=1000

Mark-Simulacrum · 2020-07-20T16:06:29Z

Will the dummy-credentials just be no-op uploads? I imagine we'll want to make sure that docker caches for example still work on Azure so we're not busting them continuously (or stop running jobs entirely instead of dummy-var'ing them).

emilyalbini · 2020-07-20T16:07:13Z

The dummy credentials are the existing gha buckets.

Mark-Simulacrum · 2020-07-20T16:08:33Z

Ah okay, that makes more sense. Unfortunate naming :/

r=me when ready

emilyalbini · 2020-07-20T16:14:58Z

@bors r=Mark-Simulacrum

This will likely fail one time.

bors · 2020-07-20T16:15:00Z

📌 Commit 750ad20 has been approved by Mark-Simulacrum

bors · 2020-07-20T17:26:43Z

⌛ Testing commit 750ad20 with merge a829ac63660d232007aa2944dc7fddc13d7e15b6...

bors · 2020-07-20T17:48:43Z

💔 Test failed - checks-azure

Mark-Simulacrum · 2020-07-20T19:12:19Z

2020-07-20T17:46:47.9653699Z + /scripts/validate-toolstate.sh
2020-07-20T17:46:47.9705032Z Cloning into 'rust-toolstate'...
2020-07-20T17:46:48.5729316Z <Nothing changed>
2020-07-20T17:46:48.7351930Z Traceback (most recent call last):
2020-07-20T17:46:48.7352697Z   File "../../src/tools/publish_toolstate.py", line 286, in <module>
2020-07-20T17:46:48.7353324Z     validate_maintainers(repo, github_token)
2020-07-20T17:46:48.7353970Z   File "../../src/tools/publish_toolstate.py", line 87, in validate_maintainers
2020-07-20T17:46:48.7355615Z     'Accept': 'application/vnd.github.hellcat-preview+json',
2020-07-20T17:46:48.7356332Z   File "/usr/lib/python3.6/urllib/request.py", line 223, in urlopen
2020-07-20T17:46:48.7356917Z     return opener.open(url, data, timeout)
2020-07-20T17:46:48.7357511Z   File "/usr/lib/python3.6/urllib/request.py", line 532, in open
2020-07-20T17:46:48.7358065Z     response = meth(req, response)
2020-07-20T17:46:48.7358662Z   File "/usr/lib/python3.6/urllib/request.py", line 642, in http_response
2020-07-20T17:46:48.7359637Z     'http', request, response, code, msg, hdrs)
2020-07-20T17:46:48.7360565Z   File "/usr/lib/python3.6/urllib/request.py", line 570, in error
2020-07-20T17:46:48.7361135Z     return self._call_chain(*args)
2020-07-20T17:46:48.7361767Z   File "/usr/lib/python3.6/urllib/request.py", line 504, in _call_chain
2020-07-20T17:46:48.7362328Z     result = func(*args)
2020-07-20T17:46:48.7362895Z   File "/usr/lib/python3.6/urllib/request.py", line 650, in http_error_default
2020-07-20T17:46:48.7363576Z     raise HTTPError(req.full_url, code, msg, hdrs, fp)
2020-07-20T17:46:48.7364203Z urllib.error.HTTPError: HTTP Error 401: Unauthorized

Doesn't seem spurious.

emilyalbini · 2020-07-20T21:01:48Z

Woops, configured the wrong token in Azure.

@bors retry

bors · 2020-07-20T21:12:18Z

⌛ Testing commit 750ad20 with merge 517e9a401fd3d516f151fb6d3151ae050fa90101...

bors · 2020-07-20T21:38:42Z

💔 Test failed - checks-azure

Mark-Simulacrum · 2020-07-20T21:40:04Z

Hm well now you're forbidden not unauthorized...

2020-07-20T21:36:43.3315998Z   File "../../src/tools/publish_toolstate.py", line 286, in <module>
2020-07-20T21:36:43.3316489Z     validate_maintainers(repo, github_token)
2020-07-20T21:36:43.3316982Z   File "../../src/tools/publish_toolstate.py", line 87, in validate_maintainers
2020-07-20T21:36:43.3318330Z     'Accept': 'application/vnd.github.hellcat-preview+json',
2020-07-20T21:36:43.3318845Z   File "/usr/lib/python3.6/urllib/request.py", line 223, in urlopen
2020-07-20T21:36:43.3319312Z     return opener.open(url, data, timeout)
2020-07-20T21:36:43.3319759Z   File "/usr/lib/python3.6/urllib/request.py", line 532, in open
2020-07-20T21:36:43.3320200Z     response = meth(req, response)
2020-07-20T21:36:43.3320894Z   File "/usr/lib/python3.6/urllib/request.py", line 642, in http_response
2020-07-20T21:36:43.3321668Z     'http', request, response, code, msg, hdrs)
2020-07-20T21:36:43.3322148Z   File "/usr/lib/python3.6/urllib/request.py", line 570, in error
2020-07-20T21:36:43.3322573Z     return self._call_chain(*args)
2020-07-20T21:36:43.3323031Z   File "/usr/lib/python3.6/urllib/request.py", line 504, in _call_chain
2020-07-20T21:36:43.3323468Z     result = func(*args)
2020-07-20T21:36:43.3323901Z   File "/usr/lib/python3.6/urllib/request.py", line 650, in http_error_default
2020-07-20T21:36:43.3324433Z     raise HTTPError(req.full_url, code, msg, hdrs, fp)
2020-07-20T21:36:43.3324907Z urllib.error.HTTPError: HTTP Error 403: Forbidden

emilyalbini · 2020-07-20T22:11:00Z

Gah.

@bors retry

bors · 2020-07-21T16:43:45Z

⌛ Testing commit 055221dfb5a9b062366123399b29e9b283642344 with merge c09da559ee8ae6cc1103a32cbcaa6d55f625a53b...

bors · 2020-07-21T18:58:42Z

💔 Test failed - checks-azure

Manishearth · 2020-07-21T19:04:00Z

Logon failed, use ctrl+c to cancel basic credential prompt.
fatal: could not read Username for 'https://github.com': terminal prompts disabled
Sleeping for 3 seconds before retrying push
From https://github.com/pietroalbini/rust-toolstate
 * branch            master     -> FETCH_HEAD
HEAD is now at b08d1af (windows CI update)
[master d1e8608] (windows CI update)
 1 file changed, 1 insertion(+)
Logon failed, use ctrl+c to cancel basic credential prompt.
fatal: could not read Username for 'https://github.com': terminal prompts disabled
Sleeping for 3 seconds before retrying push
From https://github.com/pietroalbini/rust-toolstate
 * branch            master     -> FETCH_HEAD
HEAD is now at b08d1af (windows CI update)
[master 893428f] (windows CI update)
 1 file changed, 1 insertion(+)
Logon failed, use ctrl+c to cancel basic credential prompt.
fatal: could not read Username for 'https://github.com': terminal prompts disabled
Sleeping for 3 seconds before retrying push
From https://github.com/pietroalbini/rust-toolstate
 * branch            master     -> FETCH_HEAD
HEAD is now at b08d1af (windows CI update)
thread 'main' panicked at 'Failed to update toolstate repository with new data', src\bootstrap\toolstate.rs:447:9
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
failed to run: D:\a\1\s\build\bootstrap\debug\bootstrap test check-tools
Build completed unsuccessfully in 0:00:22
== clock drift check ==
  local time: Tue Jul 21 18:57:12 CUT 2020
  network time: Tue, 21 Jul 2020 18:57:12 GMT
== end clock drift check ==

emilyalbini · 2020-07-21T21:08:41Z

I swear I'm good at this. Let's try with the production token and with the username/password switch reverted.

@bors r=Mark-Simulacrum

bors · 2020-07-21T21:08:42Z

📌 Commit 750ad20 has been approved by Mark-Simulacrum

bors · 2020-07-21T23:29:31Z

⌛ Testing commit 750ad20 with merge aca77cd...

bors · 2020-07-22T02:51:51Z

☀️ Test successful - checks-actions, checks-azure
Approved by: Mark-Simulacrum
Pushing aca77cd to master...

@Mark-Simulacrum

…imulacrum Disable Azure Pipelines except for macOS Following up on rust-lang#74565, this PR disables most of Azure Pipelines except for macOS auto builds, practically switching us to GitHub Actions 🎉 r? @Mark-Simulacrum

…ulacrum [beta] backports * Forbid non-derefable types explicitly in unsizing casts rust-lang#75136 * forbid `#[track_caller]` on main rust-lang#75130 * Fix #[track_caller] shims for trait objects. rust-lang#74784 * rustc_target: Add a target spec option for disabling `--eh-frame-hdr` rust-lang#74631 * Disable Azure Pipelines except for macOS rust-lang#74620 * Upload builds from GHA instead of Azure Pipelines rust-lang#74565 * Add the aarch64-apple-darwin target rust-lang#74541 * Use `ReEmpty(U0)` as the implicit region bound in typeck rust-lang#74509 * rustbuild: drop tool::should_install rust-lang#74457 * lint: use `transparent_newtype_field` to avoid ICE rust-lang#74340 * Don't panic if the lhs of a div by zero is not statically known rust-lang#74221 * improper_ctypes_definitions: allow `Box` rust-lang#74448 * typeck: check for infer before type impls trait rust-lang#73965

emilyalbini added 2 commits July 20, 2020 17:12

ci: allow RLA to pick the right PR number

5e11ae4

ci: upload non-macOS from GHA instead of Azure Pipelines

750ad20

rust-highfive assigned Mark-Simulacrum Jul 20, 2020

rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jul 20, 2020

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 20, 2020

bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jul 20, 2020

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 20, 2020

Mark-Simulacrum mentioned this pull request Jul 20, 2020

Rollup of 13 pull requests #74569

Merged

bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jul 20, 2020

bors removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jul 20, 2020

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 21, 2020

bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jul 21, 2020

emilyalbini force-pushed the build-on-gha branch from 055221d to 750ad20 Compare July 21, 2020 21:08

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 21, 2020

bors added the merged-by-bors This PR was explicitly merged by bors. label Jul 22, 2020

bors merged commit aca77cd into rust-lang:master Jul 22, 2020

bors mentioned this pull request Jul 22, 2020

Enable perf try builder #74600

Merged

emilyalbini deleted the build-on-gha branch July 22, 2020 08:47

emilyalbini mentioned this pull request Jul 22, 2020

Disable Azure Pipelines except for macOS #74620

Merged

emilyalbini added beta-nominated Nominated for backporting to the compiler in the beta channel. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. beta-accepted Accepted for backporting to the compiler in the beta channel. labels Jul 22, 2020

Mark-Simulacrum removed the beta-nominated Nominated for backporting to the compiler in the beta channel. label Aug 7, 2020

Mark-Simulacrum mentioned this pull request Aug 7, 2020

[beta] backports #75261

Merged

cuviper added this to the 1.47.0 milestone May 2, 2024

Uh oh!

Conversation

emilyalbini commented Jul 20, 2020

Uh oh!

emilyalbini commented Jul 20, 2020

Uh oh!

Mark-Simulacrum commented Jul 20, 2020

Uh oh!

emilyalbini commented Jul 20, 2020

Uh oh!

Mark-Simulacrum commented Jul 20, 2020

Uh oh!

emilyalbini commented Jul 20, 2020

Uh oh!

bors commented Jul 20, 2020

Uh oh!

bors commented Jul 20, 2020

Uh oh!

bors commented Jul 20, 2020

Uh oh!

Mark-Simulacrum commented Jul 20, 2020

Uh oh!

emilyalbini commented Jul 20, 2020

Uh oh!

bors commented Jul 20, 2020

Uh oh!

bors commented Jul 20, 2020

Uh oh!

Mark-Simulacrum commented Jul 20, 2020

Uh oh!

emilyalbini commented Jul 20, 2020

Uh oh!

bors commented Jul 21, 2020

Uh oh!

bors commented Jul 21, 2020

Uh oh!

Manishearth commented Jul 21, 2020

Uh oh!

emilyalbini commented Jul 21, 2020

Uh oh!

bors commented Jul 21, 2020

Uh oh!

bors commented Jul 21, 2020

Uh oh!

bors commented Jul 22, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants