Skip to content

rustc_target: Add a target spec option for disabling --eh-frame-hdr#74631

Merged
bors merged 1 commit intorust-lang:masterfrom
petrochenkov:ehdr2
Jul 23, 2020
Merged

rustc_target: Add a target spec option for disabling --eh-frame-hdr#74631
bors merged 1 commit intorust-lang:masterfrom
petrochenkov:ehdr2

Conversation

@petrochenkov
Copy link
Contributor

@petrochenkov petrochenkov commented Jul 22, 2020

Disable --eh-frame-hdr for targets that use an ld-like linker, but don't support that option.
Do it through a target spec option rather than through hard-coding in linker.rs.
The option is still enabled by default though.

cc #73564
Fixes #73564 (comment)
Fixes #74625
Fixes rust-embedded/msp430-rt#12

@rust-highfive
Copy link
Contributor

rust-highfive commented Jul 22, 2020

r? @oli-obk

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jul 22, 2020
This was referenced Jul 22, 2020
Closed
Closed
Merged
@dylanmckay dylanmckay mentioned this pull request Jul 22, 2020
Closed
@jonas-schievink
Copy link
Contributor

jonas-schievink commented Jul 22, 2020

@bors r+

@bors
Copy link
Collaborator

bors commented Jul 22, 2020

📌 Commit 49b9a64 has been approved by jonas-schievink

@bors
Copy link
Collaborator

bors commented Jul 22, 2020

🌲 The tree is currently closed for pull requests below priority 5, this pull request will be tested once the tree is reopened

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 22, 2020
Manishearth added a commit to Manishearth/rust that referenced this pull request Jul 22, 2020
@Manishearth
Rollup merge of rust-lang#74631 - petrochenkov:ehdr2, r=jonas-schievink
dbe2726 
rustc_target: Add a target spec option for disabling `--eh-frame-hdr`

Disable `--eh-frame-hdr` for targets that use an `ld`-like linker, but don't support that option.
Do it through a target spec option rather than through hard-coding in `linker.rs`.
The option is still enabled by default though.

cc rust-lang#73564
Fixes rust-lang#73564 (comment)
Fixes rust-lang#74625
Fixes rust-embedded/msp430-rt#12
@Manishearth Manishearth mentioned this pull request Jul 22, 2020
Closed
Manishearth added a commit to Manishearth/rust that referenced this pull request Jul 22, 2020
@Manishearth
Rollup merge of rust-lang#74631 - petrochenkov:ehdr2, r=jonas-schievink
b9c6a74 
rustc_target: Add a target spec option for disabling `--eh-frame-hdr`

Disable `--eh-frame-hdr` for targets that use an `ld`-like linker, but don't support that option.
Do it through a target spec option rather than through hard-coding in `linker.rs`.
The option is still enabled by default though.

cc rust-lang#73564
Fixes rust-lang#73564 (comment)
Fixes rust-lang#74625
Fixes rust-embedded/msp430-rt#12
@Manishearth Manishearth mentioned this pull request Jul 22, 2020
Closed
Manishearth added a commit to Manishearth/rust that referenced this pull request Jul 22, 2020
@Manishearth
Rollup merge of rust-lang#74631 - petrochenkov:ehdr2, r=jonas-schievink
b9d7efe 
rustc_target: Add a target spec option for disabling `--eh-frame-hdr`

Disable `--eh-frame-hdr` for targets that use an `ld`-like linker, but don't support that option.
Do it through a target spec option rather than through hard-coding in `linker.rs`.
The option is still enabled by default though.

cc rust-lang#73564
Fixes rust-lang#73564 (comment)
Fixes rust-lang#74625
Fixes rust-embedded/msp430-rt#12
@Manishearth Manishearth mentioned this pull request Jul 22, 2020
Closed
Manishearth added a commit to Manishearth/rust that referenced this pull request Jul 22, 2020
@Manishearth
Rollup merge of rust-lang#74631 - petrochenkov:ehdr2, r=jonas-schievink
05df78f 
rustc_target: Add a target spec option for disabling `--eh-frame-hdr`

Disable `--eh-frame-hdr` for targets that use an `ld`-like linker, but don't support that option.
Do it through a target spec option rather than through hard-coding in `linker.rs`.
The option is still enabled by default though.

cc rust-lang#73564
Fixes rust-lang#73564 (comment)
Fixes rust-lang#74625
Fixes rust-embedded/msp430-rt#12
@Manishearth Manishearth mentioned this pull request Jul 22, 2020
Closed
@Manishearth Manishearth mentioned this pull request Jul 22, 2020
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Jul 23, 2020
@bors
Auto merge of rust-lang#74662 - Manishearth:rollup-jdt7t71, r=Manishe…
e8b55a4 
…arth

Rollup of 9 pull requests

Successful merges:

 - rust-lang#73783 (Detect when `'static` obligation might come from an `impl`)
 - rust-lang#73868 (Advertise correct stable version for const control flow)
 - rust-lang#74460 (rustdoc: Always warn when linking from public to private items)
 - rust-lang#74538 (Guard against non-monomorphized type_id intrinsic call)
 - rust-lang#74541 (Add the aarch64-apple-darwin target )
 - rust-lang#74600 (Enable perf try builder)
 - rust-lang#74618 (Do not ICE on assoc type with bad placeholder)
 - rust-lang#74631 (rustc_target: Add a target spec option for disabling `--eh-frame-hdr`)
 - rust-lang#74643 (build: Remove unnecessary `cargo:rerun-if-env-changed` annotations)

Failed merges:

r? @ghost
@bors bors merged commit 7b28e7b into rust-lang:master Jul 23, 2020
@petrochenkov
Copy link
Contributor Author

petrochenkov commented Jul 23, 2020

Beta-nominating as a regression fix, although I'm not sure the affected targets are usable on stable.

@petrochenkov petrochenkov added the beta-nominated Nominated for backporting to the compiler in the beta channel. label Jul 23, 2020
@jonas-schievink jonas-schievink added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label Jul 23, 2020
@spastorino
Copy link
Member

spastorino commented Jul 23, 2020

Thanks for adding T-compiler label @jonas-schievink. We missed this one on today's meeting because of the lack of T-compiler label. Anyway I check all the beta-nominations looking for nominations without team, the thing is I do that on wednesday and this one was tagged right after me going over all nominations.

Anyway, we will cover this one on our next meeting.

@pnkfelix
Copy link
Contributor

pnkfelix commented Jul 30, 2020

discussed in T-compiler meeting.

@rustbot modify labels: beta-accepted

@rustbot rustbot added the beta-accepted Accepted for backporting to the compiler in the beta channel. label Jul 30, 2020
@Mark-Simulacrum Mark-Simulacrum removed the beta-nominated Nominated for backporting to the compiler in the beta channel. label Aug 7, 2020
@Mark-Simulacrum Mark-Simulacrum mentioned this pull request Aug 7, 2020
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Aug 7, 2020
@bors
Auto merge of rust-lang#75261 - Mark-Simulacrum:beta-next, r=Mark-Sim…
63ca028 
…ulacrum

[beta] backports

* Forbid non-derefable types explicitly in unsizing casts rust-lang#75136
* forbid `#[track_caller]` on main rust-lang#75130
* Fix #[track_caller] shims for trait objects. rust-lang#74784
* rustc_target: Add a target spec option for disabling `--eh-frame-hdr` rust-lang#74631
* Disable Azure Pipelines except for macOS rust-lang#74620
* Upload builds from GHA instead of Azure Pipelines rust-lang#74565
* Add the aarch64-apple-darwin target rust-lang#74541
* Use `ReEmpty(U0)` as the implicit region bound in typeck rust-lang#74509
* rustbuild: drop tool::should_install rust-lang#74457
* lint: use `transparent_newtype_field` to avoid ICE rust-lang#74340
* Don't panic if the lhs of a div by zero is not statically known rust-lang#74221
* improper_ctypes_definitions: allow `Box` rust-lang#74448
* typeck: check for infer before type impls trait rust-lang#73965
@cuviper cuviper added this to the 1.47.0 milestone May 2, 2024
@petrochenkov petrochenkov deleted the ehdr2 branch February 22, 2025 18:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@oli-obk oli-obk

Labels

beta-accepted Accepted for backporting to the compiler in the beta channel. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.47.0

Development

Successfully merging this pull request may close these issues.

Linker Problem following the example

10 participants

@petrochenkov @rust-highfive @jonas-schievink @bors @spastorino @pnkfelix @cuviper @oli-obk @Mark-Simulacrum @rustbot