Merged
Conversation
Co-authored-by: Cldfire <cldfire@3grid.net>
They are now unnecessary for projects written in Rust, since backtrace-rs used by the standard library has only Rust dependencies.
This has been put in place to patch over an ICE caused when we encounter a non-static lifetime in a const generic during borrow checking. This restriction may be relaxed in the future, but we need more discussion before then, and in the meantime we should still deal with this ICE. Fixes issue rust-lang#60814
This commit extends current well-formedness checking to apply to foreign function declarations, re-using the existing machinery for regular functions. In doing this, later parts of the compiler (such as the `improper_ctypes` lint) can rely on being operations not failing as a result of invalid code which would normally be caught earlier. Signed-off-by: David Wood <david@davidtw.co>
Fix debug assertion in typeck Fixes rust-lang#72410
Impl Default for ranges
Couldn't find an issue about it.
`Range` and friends probably can implement `Default` if `Idx: Default`. For example, the following would be possible:
```rust
#[derive(Default)]
struct Foo(core::ops::RangeToInclusive<u64>);
let _ = [1, 2, 3].get(core::ops::Range::default());
core::ops::RangeFrom::<u8>::default().take(20).for_each(|x| { dbg!(x); });
fn stuff<T: Default>() { let instance = T::default(); ... more stuff }
stuff::<core::ops::RangeTo<f32>>();
```
Maybe there are some concerns about safety or misunderstandings?
…gn-fn-decl, r=ecstatic-morse wf: check foreign fn decls for well-formedness Fixes rust-lang#73252 and fixes rust-lang#73253. This PR extends current well-formedness checking to apply to foreign function declarations, re-using the existing machinery for regular functions. In doing this, later parts of the compiler (such as the `improper_ctypes` lint) can rely on being operations not failing as a result of invalid code which would normally be caught earlier.
…akis disallow non-static lifetimes in const generics Disallow non-static lifetimes in const generics in order to to patch over an ICE caused when we encounter a non-static lifetime in a const generic during borrow checking. This restriction may be relaxed in the future, but we need more discussion before then, and in the meantime we should still deal with this ICE. Fixes issue rust-lang#60814
…=eddyb test caching opt_const_param_of on disc Followup to rust-lang#74113, implements parts of rust-lang#74360 Tried caching `opt_const_param_of` on disk and adding an early exit if `tcx.dep_kind(def_id) != DefKind::AnonConst`. Ended up causing a perf regression instead, so we just remove the FIXME and a short note to `opt_const_param_of`. r? @eddyb
…omez Ayu theme: Use different background color for Run button Make it clearer that there is a button Run there. Demo in rust-lang#74501 (comment) .
…meGomez Fix search input focus in ayu theme Closes rust-lang#74496. Before:  After: 
Update sanitizer docs * Document AddressSanitizer memory leak detection defaults. * Remove CC & CFLAGS from MemorySanitizer example - they are now unnecessary for pure Rust projects (backtrace-rs moved away from libbacktrace).
…be_uninit_extra, r=kennytm Fix duplicate maybe_uninit_extra attribute Introduced in rust-lang#72414
…tau, r=dtolnay Stabilize TAU constant. Closes rust-lang#66770.
…up, r=Manishearth Improve "important traits" popup display on mobile I implemented what @XAMPPRocky suggested in the [internals thread topic](https://internals.rust-lang.org/t/feedback-on-important-traits-rustdoc-feature/12752/18). I can confirm it works nicely. r? @Manishearth @Manishearth: By the way: I realized that when you click on the "i", you have to click again to make the popup disappear. Do you want me to extend the popup removal to any click outside the popup?
Fix an ICE on an invalid `binding @ ...` in a tuple struct pattern Fixes rust-lang#74539.
update backtrace-rs Hopefully fixes rust-lang#74484 r? @alexcrichton
Member
Author
Collaborator
|
📌 Commit df8d169 has been approved by |
bors
added
the
S-waiting-on-bors
Collaborator
|
⌛ Testing commit df8d169 with merge 1d31d85f63b411275ad79b0b3494ecda6888e932... |
Collaborator
|
💔 Test failed - checks-actions |
bors
added
S-waiting-on-review
Member
Author
|
@bors retry toolstate permission denied cc @Mark-Simulacrum |
bors
added
S-waiting-on-bors
Collaborator
|
⌛ Testing commit df8d169 with merge 2880f171fe36733789c95a80dc538ec811ed3913... |
Member
|
@bors retry I suspect we need #74565 to land first before this, right? @pietroalbini -- do you know? My assumption is that if we've switched tokens in the UI and that's leading to problems here or so. |
Collaborator
Member
|
@Mark-Simulacrum I should have hopefully granted the right permissions. |
Collaborator
|
☀️ Test successful - checks-actions, checks-azure |
rust-highfive
added a commit
to rust-lang-nursery/rust-toolstate
that referenced
this pull request
Jul 21, 2020
Tested on commit rust-lang/rust@734233d. Direct link to PR: <rust-lang/rust#74569> 🎉 miri on windows: test-fail → test-pass (cc @oli-obk @eddyb @RalfJung). 🎉 miri on linux: test-fail → test-pass (cc @oli-obk @eddyb @RalfJung).
This was referenced Jul 21, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
19 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Successful merges:
binding @ ...in a tuple struct pattern #74557 (Fix an ICE on an invalidbinding @ ...in a tuple struct pattern)Failed merges:
r? @ghost