Convert core/src/str/pattern.rs to Intra-doc links#75782
Merged
bors merged 2 commits intorust-lang:masterfrom Aug 22, 2020
Merged
Convert core/src/str/pattern.rs to Intra-doc links#75782bors merged 2 commits intorust-lang:masterfrom
bors merged 2 commits intorust-lang:masterfrom
Conversation
Contributor
|
(rust_highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
Contributor
|
r? @jyn514 😇 |
jyn514
changed the title
jyn514
reviewed
Aug 21, 2020
Member
jyn514
left a comment
jyn514
left a comment
There was a problem hiding this comment.
Looks great! I love all the new links :D
library/core/src/str/pattern.rs
Outdated
Member
There was a problem hiding this comment.
Suggested change
| /// [`char::Searcher`] is a `DoubleEndedSearcher` because searching for a | |
| /// [`char::Searcher`] is a [`DoubleEndedSearcher`] because searching for a |
Member
Author
There was a problem hiding this comment.
We are already on DoubleEndedSearcher, so that wouldn't make much sense to add a link to the item we're documenting. ;)
Member
There was a problem hiding this comment.
Oops, this is what happens when you only read the links and not the surrounding code 😆
jyn514
added
A-intra-doc-links
GuillaumeGomez
force-pushed
the
more-links
branch
from
7427536 to
385a1b2
Compare
Member
|
@bors r+ rollup |
Collaborator
|
📌 Commit 385a1b2 has been approved by |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Aug 22, 2020
Rollup of 12 pull requests Successful merges: - rust-lang#75705 (Move to intra-doc links for /library/core/src/intrinsics.rs) - rust-lang#75711 (Split `astconv.rs` into its own submodule) - rust-lang#75718 (Don't count variants/fields/consts/associated types in doc-coverage doc examples) - rust-lang#75725 (Use intra-doc-links in `alloc`) - rust-lang#75745 (Remove duplication in `fold_item`) - rust-lang#75753 (Another motivation for CFG: return-oriented programming) - rust-lang#75769 (Minor, remove double nesting of a test module) - rust-lang#75771 (Extend normalization in const-eval-query-stack test) - rust-lang#75781 (More inline asm register name fixups for LLVM) - rust-lang#75782 (Convert core/src/str/pattern.rs to Intra-doc links) - rust-lang#75787 (Use intra-doc-links in `core::ops::*`) - rust-lang#75788 (MIR call terminator represents diverging calls too) Failed merges: - rust-lang#75773 (Introduce expect snapshot testing library into rustc) r? @ghost
jyn514
removed
the
T-rustdoc
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #75080.