Use more intra-doc-links in core::fmt#75853
Merged
bors merged 1 commit intorust-lang:masterfrom Oct 5, 2020
Merged
Conversation
rust-highfive
added
the
S-waiting-on-review
LeSeulArtichaut
added
S-blocked
jyn514
added
A-intra-doc-links
Collaborator
|
☔ The latest upstream changes (presumably #73819) made this pull request unmergeable. Please resolve the merge conflicts. |
Member
|
This can be merged once you rebase :) assuming that |
jyn514
added
S-waiting-on-author
LeSeulArtichaut
force-pushed
the
core-intra-docs-3
branch
from
7711caf to
af39af7
Compare
LeSeulArtichaut
added
S-blocked
Member
|
triage: Is this still blocked? |
camelid
requested changes
Oct 4, 2020
Member
camelid
left a comment
camelid
left a comment
There was a problem hiding this comment.
It seems like all of these are auto-imported, which might resolve the blockage?
library/core/src/fmt/mod.rs
Outdated
Member
There was a problem hiding this comment.
Isn't this auto-imported?
Suggested change
| /// [`write!`]: crate::write! |
library/core/src/fmt/mod.rs
Outdated
Member
There was a problem hiding this comment.
Same here.
Suggested change
| /// [`write!`]: crate::write! |
library/core/src/fmt/mod.rs
Outdated
Comment on lines
+1889
to
1890
Member
There was a problem hiding this comment.
This too:
Suggested change
| /// [`format_args!`]: crate::format_args | |
| /// |
Member
|
This should be ready to go after a rebase :) |
jyn514
added
S-waiting-on-author
LeSeulArtichaut
force-pushed
the
core-intra-docs-3
branch
from
af39af7 to
17d3c0a
Compare
Contributor
Author
|
Rebased |
Member
|
@bors r+ rollup |
Collaborator
|
📌 Commit 17d3c0a has been approved by |
bors
added
S-waiting-on-bors
Member
|
Aren't all these links unnecessary though, since they're in the prelude? |
Member
|
Sure, we can fix them in a follow-up. I mostly want to finally get this merged 😆 |
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Oct 5, 2020
Rollup of 11 pull requests Successful merges: - rust-lang#75853 (Use more intra-doc-links in `core::fmt`) - rust-lang#75928 (Remove trait_selection error message in specific case) - rust-lang#76329 (Add check for doc alias attribute at crate level) - rust-lang#77219 (core::global_allocator docs link to std::alloc::GlobalAlloc) - rust-lang#77395 (BTreeMap: admit the existence of leaf edges in comments) - rust-lang#77407 (Improve build-manifest to work with the improved promote-release) - rust-lang#77426 (Include scope id in SocketAddrV6::Display) - rust-lang#77439 (Fix missing diagnostic span for `impl Trait` with const generics, and add various tests for `min_const_generics` and `const_generics`) - rust-lang#77471 (BTreeMap: refactoring around edges, missed spots) - rust-lang#77512 (Allow `Abort` terminators in all const-contexts) - rust-lang#77514 (Replace some once(x).chain(once(y)) with [x, y] IntoIter) Failed merges: r? `@ghost`
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a follow-up to #75819, which encountered some broken links due to #75176, so this PR contains the links that are blocked on #75176.
r? @jyn514