Fix missing diagnostic span for impl Trait with const generics, and add various tests for min_const_generics and const_generics#77439
Merged
bors merged 7 commits intorust-lang:masterfrom Oct 5, 2020
Conversation
rust-highfive
added
the
S-waiting-on-review
varkor
changed the title
impl Trait with const generics, and add various tests for min_const_genericsimpl Trait with const generics, and add various tests for min_const_generics and const_generics
Contributor
Author
|
I've also tweaked a diagnostic for consistency. |
Contributor
|
r=me after reblessing |
lcnr
approved these changes
Oct 2, 2020
Contributor
lcnr
left a comment
lcnr
left a comment
There was a problem hiding this comment.
lgtm,
I would prefer to merge the identical tests for const_generics and min_const_generics and instead use revisions here, as we otherwise probably end up with duplicates once const_generics is stable.
src/test/ui/const-generics/min_const_generics/const-argument-if-length.rs
Outdated
Show resolved
Hide resolved
varkor
force-pushed
the
min_const_generics-tests
branch
from
78ea2e3 to
3631d29
Compare
lcnr
reviewed
Oct 3, 2020
src/test/ui/const-generics/min_const_generics/const-argument-if-length.rs
Show resolved
Hide resolved
lcnr
approved these changes
Oct 3, 2020
src/test/ui/const-generics/min_const_generics/impl-trait-with-const-arguments.rs
Outdated
Show resolved
Hide resolved
Contributor
Author
|
@bors r=lcnr,estebank |
Collaborator
|
📌 Commit 6647eee has been approved by |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Oct 5, 2020
Rollup of 11 pull requests Successful merges: - rust-lang#75853 (Use more intra-doc-links in `core::fmt`) - rust-lang#75928 (Remove trait_selection error message in specific case) - rust-lang#76329 (Add check for doc alias attribute at crate level) - rust-lang#77219 (core::global_allocator docs link to std::alloc::GlobalAlloc) - rust-lang#77395 (BTreeMap: admit the existence of leaf edges in comments) - rust-lang#77407 (Improve build-manifest to work with the improved promote-release) - rust-lang#77426 (Include scope id in SocketAddrV6::Display) - rust-lang#77439 (Fix missing diagnostic span for `impl Trait` with const generics, and add various tests for `min_const_generics` and `const_generics`) - rust-lang#77471 (BTreeMap: refactoring around edges, missed spots) - rust-lang#77512 (Allow `Abort` terminators in all const-contexts) - rust-lang#77514 (Replace some once(x).chain(once(y)) with [x, y] IntoIter) Failed merges: r? `@ghost`
16 tasks
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Jun 13, 2022
…rrors Add some more regression tests for rust-lang#67945 Closes rust-lang#67945, added two tests from rust-lang#67945 (comment), other snippets were already added in rust-lang#71952 and rust-lang#77439 r? `@compiler-errors`
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #61410.
Adds
min_const_genericstests for:&'static [_]causes ICE #73727Adds
const_genericstests for:(I only added separate
min_const_genericsandconst_genericstests if they were handled differently by the two features.)We need to figure out how to deduplicate when
const_genericsis stabilised, but we can discuss that later. For now, we should be checking neither feature breaks, so require regression tests for both. I've given them identical names when I've added both, which should make it easier to spot them later.r? @lcnr