[beta] Revert "Promote missing_fragment_specifier to hard error #75516"#77456
Merged
bors merged 4 commits intorust-lang:betafrom Oct 3, 2020
Merged
[beta] Revert "Promote missing_fragment_specifier to hard error #75516"#77456bors merged 4 commits intorust-lang:betafrom
bors merged 4 commits intorust-lang:betafrom
Conversation
Contributor
|
Updates src/tools/cargo. cc @ehuss |
Contributor
|
@Mark-Simulacrum: no appropriate reviewer found, use r? to override |
Contributor
|
rust-highfive
added
the
S-waiting-on-review
Member
Author
Member
Author
That looks like a false positive from the update (well, revert) of cargotest, so can be ignored. |
Member
|
@bors r+ rollup=never |
Collaborator
|
📌 Commit 2b214e6 has been approved by |
bors
added
S-waiting-on-bors
Contributor
|
Yea, I've been meaning to fix that (rust-lang/highfive#253). |
Collaborator
Collaborator
|
☀️ Test successful - checks-actions, checks-azure |
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Nov 7, 2020
…chenkov [beta] Revert "Promote missing_fragment_specifier to hard error rust-lang#75516" This reverts "Promote missing_fragment_specifier to hard error rust-lang#75516" on just beta. I would like us to explore a more principled fix, perhaps along the lines `@petrochenkov` suggested in rust-lang#76605, on master when we have more time to test it but I don't want us shipping the breakage in the meantime. I don't personally feel comfortable immediately backporting anything more than a revert here. cc `@matklad` This matches rust-lang#77456 for 1.47 but targets 1.48 (current beta) instead. r? `@petrochenkov`
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reverts "Promote missing_fragment_specifier to hard error #75516" on just beta. I would like us to explore a more principled fix, perhaps along the lines @petrochenkov suggested in #76605, on master when we have more time to test it but I don't want us shipping the breakage in the meantime. I don't personally feel comfortable immediately backporting anything more than a revert here.
cc @matklad