[beta] Revert "Promote missing_fragment_specifier to hard error #75516"#78146
Merged
bors merged 3 commits intorust-lang:betafrom Nov 7, 2020
Merged
[beta] Revert "Promote missing_fragment_specifier to hard error #75516"#78146bors merged 3 commits intorust-lang:betafrom
bors merged 3 commits intorust-lang:betafrom
Conversation
Contributor
|
rust-highfive
added
the
S-waiting-on-review
Member
Author
|
@bors rollup=never |
Contributor
|
👍 from me on reverting |
Contributor
|
@bors r+ |
Collaborator
|
📌 Commit 62bcdae821e466500edc05ec9b4c5b8311ebfa3c has been approved by |
bors
added
S-waiting-on-bors
Collaborator
|
⌛ Testing commit 62bcdae821e466500edc05ec9b4c5b8311ebfa3c with merge 9bfd49783341567fe637193d584d344fdc8ba76b... |
Collaborator
|
💔 Test failed - checks-actions |
bors
added
S-waiting-on-review
petrochenkov
added
S-waiting-on-author
Contributor
|
@bors r- retry |
bors
added
S-waiting-on-bors
Contributor
|
Looks like some UI tests need an update? |
petrochenkov
added
S-waiting-on-author
Mark-Simulacrum
force-pushed
the
revert-76605
branch
3 times, most recently
from
8e3766d to
c279138
Compare
This reverts commit 5ba9610.
Mark-Simulacrum
force-pushed
the
revert-76605
branch
from
c279138 to
653c9ee
Compare
Member
Author
|
@bors r=petrochenkov |
Collaborator
|
📌 Commit 653c9ee has been approved by |
bors
added
S-waiting-on-bors
Member
Author
|
@bors rollup=never |
Collaborator
Collaborator
|
☀️ Test successful - checks-actions |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reverts "Promote missing_fragment_specifier to hard error #75516" on just beta. I would like us to explore a more principled fix, perhaps along the lines @petrochenkov suggested in #76605, on master when we have more time to test it but I don't want us shipping the breakage in the meantime. I don't personally feel comfortable immediately backporting anything more than a revert here.
cc @matklad
This matches #77456 for 1.47 but targets 1.48 (current beta) instead.
r? @petrochenkov