Merged
Conversation
Contributor
|
r? @eddyb (rust_highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
spastorino
force-pushed
the
separate-unsized-locals
branch
from
927b11a to
d3a17af
Compare
eddyb
reviewed
Oct 20, 2020
Member
RalfJung
reviewed
Oct 20, 2020
RalfJung
reviewed
Oct 20, 2020
RalfJung
reviewed
Oct 20, 2020
RalfJung
reviewed
Oct 20, 2020
src/test/ui/unsized-locals/unsized-locals-using-unsized-fn-params.rs
Outdated
Show resolved
Hide resolved
Member
Author
|
@RalfJung have addressed all your comments, let me know if there's something else to fix. |
RalfJung
reviewed
Oct 21, 2020
RalfJung
reviewed
Oct 21, 2020
Member
Author
|
@RalfJung all your new comments are addressed |
RalfJung
reviewed
Oct 21, 2020
spastorino
force-pushed
the
separate-unsized-locals
branch
2 times, most recently
from
7566c3d to
61d9745
Compare
RalfJung
reviewed
Oct 21, 2020
src/test/ui/unsized-locals/unsized-locals-using-unsized-fn-params.rs
Outdated
Show resolved
Hide resolved
Member
|
LGTM except for that question around the tests. However, I cannot review the analysis changes here, I have no familiarity with that code. Hopefully @pnkfelix can take care of that. :) |
RalfJung
reviewed
Oct 21, 2020
spastorino
force-pushed
the
separate-unsized-locals
branch
from
685a795 to
397777b
Compare
spastorino
force-pushed
the
separate-unsized-locals
branch
from
397777b to
cc9ab1c
Compare
Member
Author
|
Rebased again to solve conflicts. |
Contributor
|
I think Felix has his hands full this week. I went over the code one more time, can't see any reason not to merge now @bors r+ |
Collaborator
|
📌 Commit cc9ab1c has been approved by |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Oct 28, 2020
Rollup of 10 pull requests Successful merges: - rust-lang#78152 (Separate unsized locals) - rust-lang#78297 (Suggest calling await on method call and field access) - rust-lang#78351 (Move "mutable thing in const" check from interning to validity) - rust-lang#78365 (check object safety of generic constants) - rust-lang#78379 (Tweak invalid `fn` header and body parsing) - rust-lang#78391 (Add const_fn in generics test) - rust-lang#78401 (resolve: private fields in tuple struct ctor diag) - rust-lang#78408 (Remove tokens from foreign items in `TokenStripper`) - rust-lang#78447 (Fix typo in comment) - rust-lang#78453 (Fix typo in comments) Failed merges: r? `@ghost`
JohnTitor
added a commit
to JohnTitor/glacier
that referenced
this pull request
Oct 29, 2020
Alexendoo
added a commit
to rust-lang/glacier
that referenced
this pull request
Oct 29, 2020
Address the changes by rust-lang/rust#78152
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #71694
Takes over again #72029 and #74971
cc @RalfJung @oli-obk @pnkfelix @eddyb as they've participated in previous reviews of this PR.