[beta] Prepare beta 1.53.0#84909

emilyalbini · 2021-05-04T14:25:34Z

Along with updating the channel and updating the bootstrap compiler, this also includes:

692454d - Fixes the diagnostics difference we had for some cycles already
9157430 - Disables the known broken RLS builder on AArch64 Windows
Update RELEASES.md for 1.52.0 #84183 - Update RELEASES.md for 1.52.0
Revert PR 83866 #84950 - Revert PR 83866
Update RLS and Rustfmt #84886 - Update RLS and Rustfmt

Changes we backported to 1.52.0 that we also need to include in 1.53.0 to avoid regressing:

rustdoc: revert deref recur to resume inclusion of impl ExtTrait<Local> for ExtType #84867 - rustdoc: revert deref recur to resume inclusion of impl ExtTrait for ExtType
[beta] remove assert_matches #84759 - [beta] remove assert_matches
Revert PR 81473 to resolve (on beta) issues 81626 and 81658. #83171 - Revert PR 81473 to resolve (on beta) issues 81626 and 81658.

r? @ghost

…lang#82465. (update: placated tidy)

This reverts commit eb18746.

This reverts commit 0a8e401.

Revert "Add missing brace" This reverts commit 85ad773. Revert "Simplify base_expr" This reverts commit 899aae4. Revert "Warn write-only fields" This reverts commit d3c69a4.

camelid · 2021-05-05T01:17:19Z

Just checking, is it intentional that this is filed against master rather than beta? According to src/version, master is currently 1.54.0 (not 1.53.0).

emilyalbini · 2021-05-05T07:59:02Z

Ugh thanks for pointing that out @camelid, we definitely need CI to prevent that from happening :(

That PR caused multiple test failures when Rust's channel is changed from nightly to anything else. The commit will have to be landed again after the test suite is fixed.

bors · 2021-05-05T16:40:42Z

⌛ Testing commit 3a1e414 with merge db7d6545ccda8d355958783fd0852d3161bb6db6...

bors · 2021-05-05T17:45:36Z

💔 Test failed - checks-actions

emilyalbini · 2021-05-05T17:52:46Z

@bors r=Mark-Simulacrum p=100

bors · 2021-05-05T17:52:47Z

📌 Commit 4894656 has been approved by Mark-Simulacrum

bors · 2021-05-05T20:07:33Z

⌛ Testing commit 4894656 with merge 65c2ab300af906f9a5eb543750cae3c34885035e...

rust-log-analyzer · 2021-05-05T20:39:14Z

The job dist-x86_64-msvc failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)

bors · 2021-05-05T20:41:35Z

💔 Test failed - checks-actions

emilyalbini · 2021-05-05T20:44:41Z

@bors retry spurious network

bors · 2021-05-05T21:19:38Z

⌛ Testing commit 4894656 with merge e58c811...

bors · 2021-05-06T00:00:18Z

☀️ Test successful - checks-actions
Approved by: Mark-Simulacrum
Pushing e58c811 to beta...

…rk-Simulacrum Revert PR 83866 rust-lang#83866 caused multiple test failures when Rust's channel is changed from nightly to anything else. The PR will have to be landed again after the test suite is fixed. The two kinds of test failures were: * Rustdoc tests failed because the links in the generated HTML didn't point at nightly anymore, see rust-lang#84909 (comment) * Rustdoc UI tests failed because the links included in error messages didn't point at nightly anymore, see rust-lang#84909 (comment) r? `@Mark-Simulacrum` cc `@jyn514`

…rk-Simulacrum Revert PR 83866 rust-lang#83866 caused multiple test failures when Rust's channel is changed from nightly to anything else. The PR will have to be landed again after the test suite is fixed. The two kinds of test failures were: * Rustdoc tests failed because the links in the generated HTML didn't point at nightly anymore, see rust-lang#84909 (comment) * Rustdoc UI tests failed because the links included in error messages didn't point at nightly anymore, see rust-lang#84909 (comment) r? ``@Mark-Simulacrum`` cc ``@jyn514``

this is beta 1.53.0

f01b35e

emilyalbini marked this pull request as draft May 4, 2021 14:26

This comment has been minimized.

Sign in to view

Update fulldeps test

0ffdf88

emilyalbini force-pushed the beta-next branch from 2c07751 to eb38388 Compare May 4, 2021 14:51

XAMPPRocky and others added 7 commits May 4, 2021 16:58

Update RELEASES.md for 1.52.0

b14eaf4

manually crafted revert of PR rust-lang#80653, to address issue rust-…

725a85a

…lang#82465. (update: placated tidy)

regression test for issue 82465.

c2c18bc

Revert "Add assert_matches!(expr, pat)."

e209666

This reverts commit eb18746.

Revert "Add debug_assert_matches macro."

607a225

This reverts commit 0a8e401.

Remove assert_matches users

d18f0a4

Remove assert_matches feature attributes.

ded409e

emilyalbini force-pushed the beta-next branch from eb38388 to ded409e Compare May 4, 2021 15:00

Revert PR 81473 to resolve (on beta) issues 81626 and 81658.

bd9c30d

Revert "Add missing brace" This reverts commit 85ad773. Revert "Simplify base_expr" This reverts commit 899aae4. Revert "Warn write-only fields" This reverts commit d3c69a4.

This comment has been minimized.

Sign in to view

bors added the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label May 4, 2021

jyn514 mentioned this pull request May 5, 2021

rustdoc: Don't link to stable/beta docs for primitives #84941

Closed

emilyalbini changed the base branch from master to beta May 5, 2021 07:58

This comment has been minimized.

Sign in to view

emilyalbini mentioned this pull request May 5, 2021

Revert PR 83866 #84950

Merged

emilyalbini force-pushed the beta-next branch from 7f5f664 to 71debca Compare May 5, 2021 10:04

This comment has been minimized.

Sign in to view

emilyalbini force-pushed the beta-next branch from 71debca to c90114d Compare May 5, 2021 10:41

This comment has been minimized.

Sign in to view

emilyalbini force-pushed the beta-next branch from c90114d to 6d3b8e8 Compare May 5, 2021 10:50

This comment has been minimized.

Sign in to view

Revert PR 83866

bbfdfa9

That PR caused multiple test failures when Rust's channel is changed from nightly to anything else. The commit will have to be landed again after the test suite is fixed.

bors added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label May 5, 2021

jyn514 mentioned this pull request May 5, 2021

Regression: Miscompilation due to bug in "mutable noalias" logic #84958

Closed

This comment has been minimized.

Sign in to view

bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels May 5, 2021

Ignore failures of RLS on aarch64 Windows

4894656

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 5, 2021

bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels May 5, 2021

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 5, 2021

bors added the merged-by-bors This PR was explicitly merged by bors. label May 6, 2021

bors merged commit e58c811 into rust-lang:beta May 6, 2021

rustbot added this to the 1.53.0 milestone May 6, 2021

emilyalbini deleted the beta-next branch May 6, 2021 07:47

Uh oh!

Conversation

emilyalbini commented May 4, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

camelid commented May 5, 2021

Uh oh!

emilyalbini commented May 5, 2021

Uh oh!

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

bors commented May 5, 2021

Uh oh!

This comment has been minimized.

bors commented May 5, 2021

Uh oh!

emilyalbini commented May 5, 2021

Uh oh!

bors commented May 5, 2021

Uh oh!

bors commented May 5, 2021

Uh oh!

rust-log-analyzer commented May 5, 2021

Uh oh!

bors commented May 5, 2021

Uh oh!

emilyalbini commented May 5, 2021

Uh oh!

bors commented May 5, 2021

Uh oh!

bors commented May 6, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

11 participants

emilyalbini commented May 4, 2021 •

edited

Loading