Merged
Conversation
And also add backticks around `MaybeUninit`.
That PR caused multiple test failures when Rust's channel is changed from nightly to anything else. The commit will have to be landed again after the test suite is fixed.
This commit implements both the native linking modifiers infrastructure as well as an initial attempt at the individual modifiers from the RFC. It also introduces a feature flag for the general syntax along with individual feature flags for each modifier.
…trochenkov Implement RFC 2951: Native link modifiers A first attempt at implementing rust-lang/rfcs#2951 / rust-lang/compiler-team#356. Tracking Issue: rust-lang#81490 Introduces feature flags for the general syntax (`native_link_modifiers`) and each modifier (`native_link_modifiers_{as_needed,bundle,verbatim,whole_archive}`). r? `@petrochenkov`
…, r=m-ou-se
Stablize {HashMap,BTreeMap}::into_{keys,values}
I would propose to stabilize `{HashMap,BTreeMap}::into_{keys,values}`( aka. `map_into_keys_values`).
Closes rust-lang#75294.
Simplify chdir implementation and minimize unsafe block
…=jonas-schievink ⬆️ rust-analyzer
…chenkov Only compute Obligation `cache_key` once in `register_obligation_at`
…etrochenkov E0583: Include secondary path in error message Fixes rust-lang#84819.
Fix typo in `MaybeUninit::array_assume_init` safety comment And also add backticks around `MaybeUninit`.
…rk-Simulacrum Revert PR 83866 rust-lang#83866 caused multiple test failures when Rust's channel is changed from nightly to anything else. The PR will have to be landed again after the test suite is fixed. The two kinds of test failures were: * Rustdoc tests failed because the links in the generated HTML didn't point at nightly anymore, see rust-lang#84909 (comment) * Rustdoc UI tests failed because the links included in error messages didn't point at nightly anymore, see rust-lang#84909 (comment) r? ``@Mark-Simulacrum`` cc ``@jyn514``
Author
|
@bors r+ rollup=never p=5 (created a partially-disjoint rollup so we can get the queue moving while I triage the earlier rollup later ) |
Collaborator
|
📌 Commit ccc820e has been approved by |
bors
added
the
S-waiting-on-bors
Collaborator
|
⌛ Testing commit ccc820e with merge 6d7df30b2cf6942fa11abd0e3005b3e757bdd94d... |
Collaborator
|
💔 Test failed - checks-actions |
bors
added
S-waiting-on-review
Collaborator
Author
|
@bors retry |
bors
added
S-waiting-on-bors
Collaborator
|
⌛ Testing commit ccc820e with merge e1e5a9ebfa70ab8559f0df878ab393c282bb2b2c... |
Contributor
|
https://github.com/rust-lang-ci/rust/actions/runs/817115841
|
Member
|
@bors retry |
Collaborator
Collaborator
Collaborator
|
☀️ Test successful - checks-actions |
This was referenced May 6, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
16 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Successful merges:
cache_keyonce inregister_obligation_at#84923 (Only compute Obligationcache_keyonce inregister_obligation_at)MaybeUninit::array_assume_initsafety comment #84949 (Fix typo inMaybeUninit::array_assume_initsafety comment)Failed merges:
r? @ghost
@rustbot modify labels: rollup
Create a similar rollup