Make PTR::as_ref and similar methods const.#91823
Merged
bors merged 1 commit intorust-lang:masterfrom Dec 21, 2021
lilasta:const_ptr_as_ref
Merged
Make PTR::as_ref and similar methods const.#91823bors merged 1 commit intorust-lang:masterfrom lilasta:const_ptr_as_ref
PTR::as_ref and similar methods const.#91823bors merged 1 commit intorust-lang:masterfrom
lilasta:const_ptr_as_ref
Conversation
Contributor
|
(rust-highfive has picked a reviewer for you, use r? to override) |
3 tasks
Member
|
r? @lcnr |
Contributor
|
seems good to me does libs have to sign off these changes? r? rust-lang/libs |
Member
|
For unstable const, approval from one member of wg-const-eval is sufficient. Stabilization of the const requires consensus of T-libs-api. |
Contributor
|
alright 👍 @bors r+ rollup |
Collaborator
|
📌 Commit a4b3fe0 has been approved by |
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Dec 21, 2021
…askrgr Rollup of 7 pull requests Successful merges: - rust-lang#90345 (Stabilise entry_insert) - rust-lang#91412 (Improve suggestions for importing out-of-scope traits reexported as `_`) - rust-lang#91770 (Suggest adding a `#[cfg(test)]` to to a test module) - rust-lang#91823 (Make `PTR::as_ref` and similar methods `const`.) - rust-lang#92127 (Move duplicates removal when generating results instead of when displaying them) - rust-lang#92129 (JoinHandle docs: add missing 'the') - rust-lang#92131 (Sync rustc_codegen_cranelift) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Dylan-DPC
added a commit
to Dylan-DPC/rust
that referenced
this pull request
Jul 30, 2023
`const`-stablilize `NonNull::as_ref` A bunch of pointer to reference methods have been made unstably const some time ago in rust-lang#91823 under the feature gate `const_ptr_as_ref`. Out of these, `NonNull::as_ref` can be implemented as a `const fn` in stable rust today, so i hereby propose to const stabilize this function only. Tracking issue: rust-lang#91822 `@rustbot` label +T-libs-api -T-libs
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Jul 30, 2023
`const`-stablilize `NonNull::as_ref` A bunch of pointer to reference methods have been made unstably const some time ago in rust-lang#91823 under the feature gate `const_ptr_as_ref`. Out of these, `NonNull::as_ref` can be implemented as a `const fn` in stable rust today, so i hereby propose to const stabilize this function only. Tracking issue: rust-lang#91822 ``@rustbot`` label +T-libs-api -T-libs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tracking issue: #91822
Feature gate:
#![feature(const_ptr_as_ref)]