Sync rustc_codegen_cranelift#92131

bjorn3 · 2021-12-20T18:05:33Z

The main highlight this sync is improved support for inline assembly. Thanks @nbdd0121! Inline assembly is still disabled by default for builds in the main rust repo though. Cranelift will now also be built from the crates.io releases rather than the git repo. Git repos are incompatible with vendoring.

r? @ghost

@rustbot label +A-codegen +A-cranelift +T-compiler

…ce}`.

…clif-2021-09-19

These were left over in migrations to subtrees, which should generally be treated as-if it was local. Also fixes a warning caused by this change.

Sync rustc_codegen_cranelift Nothing exciting this time. Mostly internal refactorings. r? `@ghost` `@rustbot` label +A-codegen +A-cranelift +T-compiler

TryInto is part of the 2021 edition prelude

Co-authored-by: bjorn3 <bjorn3@users.noreply.github.com>

This version no longer has the old x86 backend

Turn vtable_allocation() into a query This PR removes the untracked vtable-const-allocation cache from the `tcx` and turns the `vtable_allocation()` method into a query. The change is pretty straightforward and should be backportable without too much effort. Fixes rust-lang#89598.

As per the libs team decision in rust-lang#58935. Closes rust-lang#58935

Instead use the default_call_conv field on TargetFrontendConfig to get the default CallConv.

Fixes rust-lang#1212

Remove `SymbolStr` This was originally proposed in rust-lang#74554 (comment). As well as removing the icky `SymbolStr` type, it allows the removal of a lot of `&` and `*` occurrences. Best reviewed one commit at a time. r? `@oli-obk`

…clif-2021-12-20

bjorn3 · 2021-12-20T18:06:34Z

@bors r+

bors · 2021-12-20T18:06:35Z

📌 Commit 3426a73 has been approved by bjorn3

est31 · 2021-12-20T18:07:14Z

Git repos are incompatible with vendoring.

What do you mean? https://doc.rust-lang.org/cargo/commands/cargo-vendor.html#description

This cargo subcommand will vendor all crates.io and git dependencies for a project into the specified directory at .

bjorn3 · 2021-12-20T18:08:43Z

They are incompatible with the current vendoring implementation in rustbuild at least. See #90764.

bors · 2021-12-20T23:08:42Z

⌛ Testing commit 3426a73 with merge 01dd87732bac1603a0647e380b839bf0eb3356ba...

bors · 2021-12-20T23:10:30Z

💔 Test failed - checks-actions

matthiaskrgr · 2021-12-20T23:31:49Z

@bors retry docker.io 503

rust-log-analyzer · 2021-12-21T01:28:58Z

A job failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)

Attempting with retry: docker build --rm -t rust-ci -f /gha/_work/rust/rust/src/ci/docker/host-aarch64/aarch64-gnu/Dockerfile /gha/_work/rust/rust/src/ci/docker
Sending build context to Docker daemon  506.4kB

Step 1/6 : FROM ubuntu:20.04
Head https://registry-1.docker.io/v2/library/ubuntu/manifests/20.04: received unexpected HTTP status: 503 Service Unavailable
Sending build context to Docker daemon  506.4kB

Step 1/6 : FROM ubuntu:20.04
Step 1/6 : FROM ubuntu:20.04
Head https://registry-1.docker.io/v2/library/ubuntu/manifests/20.04: received unexpected HTTP status: 503 Service Unavailable
Sending build context to Docker daemon  506.4kB

Step 1/6 : FROM ubuntu:20.04
Step 1/6 : FROM ubuntu:20.04
Head https://registry-1.docker.io/v2/library/ubuntu/manifests/20.04: received unexpected HTTP status: 503 Service Unavailable
Sending build context to Docker daemon  506.4kB

Step 1/6 : FROM ubuntu:20.04
Step 1/6 : FROM ubuntu:20.04
Head https://registry-1.docker.io/v2/library/ubuntu/manifests/20.04: received unexpected HTTP status: 503 Service Unavailable
Sending build context to Docker daemon  506.4kB

Step 1/6 : FROM ubuntu:20.04
Step 1/6 : FROM ubuntu:20.04
Head https://registry-1.docker.io/v2/library/ubuntu/manifests/20.04: received unexpected HTTP status: 503 Service Unavailable
##[error]Process completed with exit code 1.
Post job cleanup.

…askrgr Rollup of 7 pull requests Successful merges: - rust-lang#90345 (Stabilise entry_insert) - rust-lang#91412 (Improve suggestions for importing out-of-scope traits reexported as `_`) - rust-lang#91770 (Suggest adding a `#[cfg(test)]` to to a test module) - rust-lang#91823 (Make `PTR::as_ref` and similar methods `const`.) - rust-lang#92127 (Move duplicates removal when generating results instead of when displaying them) - rust-lang#92129 (JoinHandle docs: add missing 'the') - rust-lang#92131 (Sync rustc_codegen_cranelift) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup

eddyb and others added 30 commits September 18, 2021 01:42

ty::layout: intern FnAbis as &'tcx.

1b8e830

ty::layout: replicate layout_of setup for `fn_abi_of_{fn_ptr,instan…

849b4c4

…ce}`.

Querify fn_abi_of_{fn_ptr,instance}.

e857fab

Merge commit '61667dedf55e3e5aa584f7ae2bd0471336b92ce9' into sync_cg_…

5d3b8e7

…clif-2021-09-19

Merge branch 'sync_from_rust'

5599473

Adjust to SourceType::InTree in several places

29e0897

These were left over in migrations to subtrees, which should generally be treated as-if it was local. Also fixes a warning caused by this change.

Migrate to 2021

208fc42

Introduce Rvalue::ShallowInitBox

1b34e2d

Auto merge of rust-lang#89092 - bjorn3:sync_cg_clif-2021-09-19, r=bjorn3

500e22e

Sync rustc_codegen_cranelift Nothing exciting this time. Mostly internal refactorings. r? `@ghost` `@rustbot` label +A-codegen +A-cranelift +T-compiler

Sync from rust 04006d8

89fedb1

Rustup to rustc 1.57.0-nightly (05044c2 2021-09-26)

9e48f99

Fix unused import warning

adc2793

TryInto is part of the 2021 edition prelude

Update Cranelift

166ff13

Update dependencies

bc61fb2

Move encode_metadata out of CrateStore.

745dee9

Move EncodedMetadata to rustc_metadata.

04f3839

Update compiler/rustc_codegen_cranelift/scripts/filter_profile.rs

881208f

Co-authored-by: bjorn3 <bjorn3@users.noreply.github.com>

Update Cranelift

eded369

This version no longer has the old x86 backend

Sync from rust a8387ae

d76afa7

Rustup to rustc 1.57.0-nightly (c02371c 2021-10-01)

0887a2e

Rustfmt

dbeafcc

Move rustc_middle::middle::cstore to rustc_session.

03c02be

Turn tcx.vtable_allocation() into a query.

095064b

Sync from rust bb918d0

376dd76

Rustup to rustc 1.57.0-nightly (54bb4fe 2021-10-08)

d195107

Add const_eval_select intrinsic

0134088

Update Cranelift

b2fed29

Update Cranelift

2bb3f76

Remove alloc::prelude

44cce7a

As per the libs team decision in rust-lang#58935. Closes rust-lang#58935

bjorn3 and others added 8 commits December 18, 2021 15:33

Slightly reduce the amount of fx.module references

fdd0f8a

Remove triple method from FunctionCx

a795a03

Instead use the default_call_conv field on TargetFrontendConfig to get the default CallConv.

Add cron job to test against latest cranelift version every day

8726625

Fixes rust-lang#1212

Sync from rust 84f962a

bb6d83d

Rustup to rustc 1.59.0-nightly (e95e084 2021-12-19)

f557a7e

Fix taking address of truly unsized type field of unsized adt

97e5045

Merge commit '97e504549371d7640cf011d266e3c17394fdddac' into sync_cg_…

3426a73

…clif-2021-12-20

rustbot added T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. A-codegen Area: Code generation A-cranelift Things relevant to the [future] cranelift backend labels Dec 20, 2021

bors added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Dec 20, 2021

bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Dec 20, 2021

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 20, 2021

matthiaskrgr mentioned this pull request Dec 21, 2021

Rollup of 7 pull requests #92152

Merged

bors merged commit ee45a53 into rust-lang:master Dec 21, 2021

rustbot added this to the 1.59.0 milestone Dec 21, 2021

bjorn3 deleted the sync_cg_clif-2021-12-20 branch December 21, 2021 13:42

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Sync rustc_codegen_cranelift#92131