Remove in_band_lifetimes from rustc_codegen_ssa#91885
Merged
bors merged 1 commit intorust-lang:masterfrom Dec 15, 2021
Merged
Conversation
rustbot
added
the
T-compiler
Contributor
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @estebank (or someone else) soon. Please see the contribution instructions for more information. |
rust-highfive
added
the
S-waiting-on-review
21 tasks
Member
workingjubilee
left a comment
workingjubilee
left a comment
There was a problem hiding this comment.
Yeah, if you can manage to pull out needless lifetimes labels for "nameless" ( 'a, 'b ) lifetimes then feel free to do so.
See rust-lang#91867 for more information.
LegionMammal978
force-pushed
the
less-inband-codegen_ssa
branch
from
7377bc0 to
eaf39cb
Compare
LegionMammal978
changed the title
inband_lifetimes from rustc_codegen_ssain_band_lifetimes from rustc_codegen_ssa
Member
|
Nice. |
Collaborator
|
📌 Commit eaf39cb has been approved by |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Dec 15, 2021
…askrgr Rollup of 7 pull requests Successful merges: - rust-lang#91880 (fix clippy::single_char_pattern perf findings) - rust-lang#91885 (Remove `in_band_lifetimes` from `rustc_codegen_ssa`) - rust-lang#91898 (Make `TyS::is_suggestable` check for non-suggestable types structually) - rust-lang#91915 (Add another regression test for unnormalized fn args with Self) - rust-lang#91916 (Fix a bunch of typos) - rust-lang#91918 (Constify `bool::then{,_some}`) - rust-lang#91920 (Use `tcx.def_path_hash` in `ExistentialPredicate.stable_cmp`) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See #91867 for more information.
In
compiler/rustc_codegen_ssa/src/coverageinfo/map.rs, there are several functions with an explicit'alifetime but only a single&'a selfparameter. These lifetimes should be redundant given lifetime elision, unless the existentialimpl Iteratorhas weird issues regarding that. Should the redundant lifetimes be removed?