Merged
Conversation
This avoids a needless query invocation
See rust-lang#91867 for more information.
fix clippy::single_char_pattern perf findings
…_ssa, r=workingjubilee Remove `in_band_lifetimes` from `rustc_codegen_ssa` See rust-lang#91867 for more information. In `compiler/rustc_codegen_ssa/src/coverageinfo/map.rs`, there are several functions with an explicit `'a` lifetime but only a single `&'a self` parameter. These lifetimes should be redundant given lifetime elision, unless the existential `impl Iterator` has weird issues regarding that. Should the redundant lifetimes be removed?
…e_return_type, r=lcnr Make `TyS::is_suggestable` check for non-suggestable types structually Not sure if I went overboard checking substs in dyn types, etc. Let me know if I should simplify this function. Fixes rust-lang#91832
…crum Add another regression test for unnormalized fn args with Self Closes rust-lang#91899
Fix a bunch of typos I hope that none of these files is not supposed to be modified. FYI, I opened separate PRs for typos in submodules, in the respective repositories * rust-lang/stdarch#1267 * rust-lang/backtrace-rs#455
…-constification-begins, r=oli-obk
Constify `bool::then{,_some}`
Note on `~const Drop`: it has no effect when called from runtime functions, when called from const contexts, the trait system ensures that the type can be dropped in const contexts.
Use `tcx.def_path_hash` in `ExistentialPredicate.stable_cmp` This avoids a needless query invocation
rustbot
added
T-compiler
Member
Author
|
@bors r+ rollup=never p=7 |
Collaborator
|
📌 Commit 990cf5b has been approved by |
bors
added
the
S-waiting-on-bors
Collaborator
Collaborator
|
☀️ Test successful - checks-actions |
This was referenced Dec 15, 2021
Collaborator
|
Finished benchmarking commit (c5ecc15): comparison url. Summary: This change led to very large relevant improvements 🎉 in compiler performance.
If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf. @rustbot label: -perf-regression |
Member
|
Likely noise due to rust-lang/rustc-perf#1126. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
11 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Successful merges:
in_band_lifetimesfromrustc_codegen_ssa#91885 (Removein_band_lifetimesfromrustc_codegen_ssa)TyS::is_suggestablecheck for non-suggestable types structually #91898 (MakeTyS::is_suggestablecheck for non-suggestable types structually)bool::then{,_some}#91918 (Constifybool::then{,_some})tcx.def_path_hashinExistentialPredicate.stable_cmp#91920 (Usetcx.def_path_hashinExistentialPredicate.stable_cmp)Failed merges:
r? @ghost
@rustbot modify labels: rollup
Create a similar rollup