Skip to content

[test] Add test cases for untested functions for VecDeque#96107

Merged
bors merged 1 commit intorust-lang:masterfrom
Gumichocopengin8:test/vec-deque
Apr 25, 2022
Merged

[test] Add test cases for untested functions for VecDeque#96107
bors merged 1 commit intorust-lang:masterfrom
Gumichocopengin8:test/vec-deque

Conversation

@Gumichocopengin8
Copy link
Contributor

@Gumichocopengin8 Gumichocopengin8 commented Apr 16, 2022

Added test cases of the following functions

  • get
  • get_mut
  • swap
  • reserve_exact
  • try_reserve_exact
  • try_reserve
  • contains
  • rotate_left
  • rotate_right
  • binary_search
  • binary_search_by
  • binary_search_by_key

@rustbot rustbot added the T-libs Relevant to the library team, which will review and decide on the PR/issue. label Apr 16, 2022
@rust-highfive
Copy link
Contributor

rust-highfive commented Apr 16, 2022

Hey! It looks like you've submitted a new PR for the library teams!

If this PR contains changes to any rust-lang/rust public library APIs then please comment with r? rust-lang/libs-api @rustbot label +T-libs-api -T-libs to request review from a libs-api team reviewer. If you're unsure where your change falls no worries, just leave it as is and the reviewer will take a look and make a decision to forward on if necessary.

Examples of T-libs-api changes:

  • Stabilizing library features
  • Introducing insta-stable changes such as new implementations of existing stable traits on existing stable types
  • Introducing new or changing existing unstable library APIs (excluding permanently unstable features / features without a tracking issue)
  • Changing public documentation in ways that create new stability guarantees
  • Changing observable runtime behavior of library APIs

@rust-highfive
Copy link
Contributor

rust-highfive commented Apr 16, 2022

r? @Mark-Simulacrum

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Apr 16, 2022
Gumichocopengin8
Gumichocopengin8 commented Apr 16, 2022
View reviewed changes
@Gumichocopengin8
Copy link
Contributor Author

Gumichocopengin8 commented Apr 16, 2022

I think Mark is busy.
r? @m-ou-se could you review this PR?

@Mark-Simulacrum
Copy link
Member

Mark-Simulacrum commented Apr 16, 2022

I should be able to go through my review queue this weekend.

@Gumichocopengin8
Copy link
Contributor Author

Gumichocopengin8 commented Apr 16, 2022

@Mark-Simulacrum Thanks!

Mark-Simulacrum
Mark-Simulacrum reviewed Apr 16, 2022
View reviewed changes
@Mark-Simulacrum
Copy link
Member

Mark-Simulacrum commented Apr 16, 2022

@rustbot author

Use @rustbot review to put this back in my review queue.

@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 16, 2022
@Gumichocopengin8
Copy link
Contributor Author

Gumichocopengin8 commented Apr 17, 2022

@rustbot review

@Mark-Simulacrum Mark-Simulacrum added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Apr 17, 2022
@Gumichocopengin8
Copy link
Contributor Author

Gumichocopengin8 commented Apr 23, 2022

@Mark-Simulacrum Could you please review this?

@Mark-Simulacrum
Copy link
Member

Mark-Simulacrum commented Apr 24, 2022

r=me with commits squashed -- I don't think we need a separate commit per function being tested.

For the future, once things are in the review queue (S-waiting-on-review), there's generally no benefit to pinging, and it does add noise to everyone's inboxes and such -- all of our reviewers are generally pretty busy and we have a dedicated group of folks helping with triage who will poke if things seem to not be moving along. Review latency of ~7 days is not unusual, unfortunately.

@Mark-Simulacrum Mark-Simulacrum added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 24, 2022
@Gumichocopengin8
Copy link
Contributor Author

Gumichocopengin8 commented Apr 24, 2022

Thank you for letting me know and sorry for disturbing several times. I'll be patient.

@Gumichocopengin8
Copy link
Contributor Author

Gumichocopengin8 commented Apr 24, 2022

@rustbot review
Squashed commits to 1 commit

@Mark-Simulacrum
Copy link
Member

Mark-Simulacrum commented Apr 24, 2022

@bors r+ rollup

No worries!

@bors
Copy link
Collaborator

bors commented Apr 24, 2022

📌 Commit a40cd2a has been approved by Mark-Simulacrum

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Apr 24, 2022
@matthiaskrgr matthiaskrgr mentioned this pull request Apr 24, 2022
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Apr 24, 2022
@bors
Auto merge of rust-lang#96369 - matthiaskrgr:rollup-q18w4v2, r=matthi…
1f631e8 
…askrgr

Rollup of 6 pull requests

Successful merges:

 - rust-lang#95395 (Better error message for `_` in function signature in `impl Trait for Ty`)
 - rust-lang#96090 (Implement MIR opt unit tests)
 - rust-lang#96107 ([test] Add test cases for untested functions for VecDeque)
 - rust-lang#96212 (Use revisions instead of nll compare mode for `/regions/` ui tests)
 - rust-lang#96215 (Drop support for legacy PM with LLVM 15)
 - rust-lang#96366 (bootstrap: Remove dead code in rustdoc shim)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit b7e67a6 into rust-lang:master Apr 25, 2022
@rustbot rustbot added this to the 1.62.0 milestone Apr 25, 2022
@Gumichocopengin8 Gumichocopengin8 deleted the test/vec-deque branch April 25, 2022 00:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Mark-Simulacrum Mark-Simulacrum Awaiting requested review from Mark-Simulacrum

Assignees

@Mark-Simulacrum Mark-Simulacrum

Labels

S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs Relevant to the library team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.62.0

Development

Successfully merging this pull request may close these issues.

6 participants

@Gumichocopengin8 @rust-highfive @Mark-Simulacrum @bors @m-ou-se @rustbot