Use revisions instead of nll compare mode for /regions/ ui tests#96212
Merged
bors merged 1 commit intorust-lang:masterfrom Apr 25, 2022
Merged
Use revisions instead of nll compare mode for /regions/ ui tests#96212bors merged 1 commit intorust-lang:masterfrom
/regions/ ui tests#96212bors merged 1 commit intorust-lang:masterfrom
Conversation
rustbot
added
the
T-compiler
rust-highfive
added
the
S-waiting-on-review
jackh726
requested changes
Apr 19, 2022
Member
jackh726
left a comment
jackh726
left a comment
There was a problem hiding this comment.
Still have some more tests to get through.
A number of diagnostic regressions, some of these can probably be combined into a single issue.
Also, when you add in a new line with //[nll]~, but the previous line has the error annotation at the end of the line, can you instead move both to be on separate lines?
src/test/ui/regions/region-invariant-static-error-reporting.base.stderr
Outdated
Show resolved
Hide resolved
src/test/ui/regions/region-multiple-lifetime-bounds-on-fns-where-clause.polonius.stderr
Outdated
Show resolved
Hide resolved
src/test/ui/regions/region-multiple-lifetime-bounds-on-fns-where-clause.rs
Outdated
Show resolved
Hide resolved
src/test/ui/regions/regions-close-object-into-object-2.nll.stderr
Outdated
Show resolved
Hide resolved
src/test/ui/regions/regions-close-object-into-object-5.base.stderr
Outdated
Show resolved
Hide resolved
src/test/ui/regions/regions-close-over-type-parameter-multiple.rs
Outdated
Show resolved
Hide resolved
src/test/ui/regions/regions-close-param-into-object.base.stderr
Outdated
Show resolved
Hide resolved
marmeladema
force-pushed
the
nll-revisions-regions
branch
from
e445e68 to
816f0f2
Compare
Contributor
Author
Done! |
Member
|
Can you rebase on master to get #96236 |
Member
|
(not sure it changes anything) |
marmeladema
force-pushed
the
nll-revisions-regions
branch
from
816f0f2 to
12510d2
Compare
Contributor
Author
Just did but unfortunately it doesn't change anything |
Member
|
Just finished reviewing and looks fine. Just need to address the previous reviews. |
jackh726
added
S-waiting-on-author
This was referenced Apr 23, 2022
Contributor
Author
|
@jackh726 I created a bunch of issues, I think we're good to go. |
marmeladema
force-pushed
the
nll-revisions-regions
branch
from
12510d2 to
e10aa15
Compare
Member
|
@bors r+ |
Collaborator
|
📌 Commit e10aa15 has been approved by |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Apr 24, 2022
…askrgr Rollup of 6 pull requests Successful merges: - rust-lang#95395 (Better error message for `_` in function signature in `impl Trait for Ty`) - rust-lang#96090 (Implement MIR opt unit tests) - rust-lang#96107 ([test] Add test cases for untested functions for VecDeque) - rust-lang#96212 (Use revisions instead of nll compare mode for `/regions/` ui tests) - rust-lang#96215 (Drop support for legacy PM with LLVM 15) - rust-lang#96366 (bootstrap: Remove dead code in rustdoc shim) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Created #96211 for the duplicated mismatched types errors
r? @jackh726