Streamwise Periodic restarts using flow.meta + Multizone PerSurface output#1527

TobiKattmann · 2022-01-25T15:49:07Z

Hi,

main thing of this PR is supposed to be the working restarts for prescribed massflow in streamwise periodic simulations (primal and adjoint). The massflow is achieved by dialing a pressure drop which is written and read to/from the flow.meta file. That file was used mainly for fixed CL stuff as far as I am aware of. The story is not done though really with this one change. There is still the restart-should-contain-everything-in-the-first-iteration-for-the-adjoint-taping issue which is currently not the case ... and not super straightforward to solve -> see c113541 description for more info. (EDIT: I will not tackle the massflow adjoint part in this PR, as with the PerSurf output it contains enough stuff which I like to have merged)
I added a weight to heat-solid zone OF's
when pressure_drop is used, the first two entries of MARKER_ANALYZE are used as out-inlet but more than two markers are allowed. This comes in handy with FLOW_COEFF_SURF imo
Adding per surface output for multizone cases. Was not working before in the way that _SURF[0] fields were reported to be ignored. A regression test is updated for that.
Little fix to the regression system where Testcase.py had unsuitable default values such that failing reg tests were reported passing

So I will continue fiddling a little bit with massflow restarts but i already successfully optimized with that setup so it is not completely useless.

Related Work

#773

PR Checklist

I am submitting my contribution to the develop branch.
My contribution generates no new compiler warnings (try with the '-Wall -Wextra -Wno-unused-parameter -Wno-empty-body' compiler flags, or simply --warnlevel=2 when using meson).
My contribution is commented and consistent with SU2 style.
I have added a test case that demonstrates my contribution, if necessary.
I have updated appropriate documentation (Tutorials, Docs Page, config_template.cpp) , if necessary.

…arkers allowed

…h that setting. Note though that the comment in the pressure update computation of the streamwise periodicity still holds: Currently the pressure update for massflow is omitted in the first iteration, as the function is called in the Preprocessing phase which leads to multiple calls during 1 iteration. Ideally this whole method is called in another place or a setup has to be found which prevents multiple calls.

Not working yet. E.g. FLOW_COEFF_SURF[0] is not longer reported as ignored hist output filed but all values for these in the history file are zero. Not sure why tbh

SU2_CFD/src/output/CMultizoneOutput.cpp

CConfig checks whether the DV_MARKERs appear in the marker list. But for multizone cases it can happen, that the marker to be deformed are just in the zonal configs. The check would fail although everything is alright. To check it right one would need to check this after all zonal cfgs were read and then check it once with a loop over all cfgs to see whether DV_MARKER appears somewhere there.

…to massflow_flowmeta

In multizone everything is done again + attaching the zone indices. So one had to do the AddHistPerSurf and SetHistPerSurf for multizone again.

…ow).

SU2_CFD/src/output/CMultizoneOutput.cpp

…to massflow_flowmeta

When using WALL_TIME as the first SCREEN_OUTPUT field, in Testcase.py, the code would never reach the iter_missing=True block as the line would produce a ValueError for every line. And because the default was iter_missing=False and passed=True ... the test reports passed. Setting the defaults to the non-passed version fixes that issue.

TestCases/TestCase.py

….. which I believe is not clever programming, especially for regression tests.

TobiKattmann · 2022-02-01T15:33:46Z

I am not really sure whether the chore-tag was correct here, it adds features that should have been there in the first place but feature-tag prob is the better description

pcarruscag

Good addition 👍 minor comments below.

pcarruscag · 2022-02-02T11:47:18Z

Common/src/CConfig.cpp

+    if(!found && (nZone==1)) {
      SU2_MPI::Error("DV_MARKER contains marker names that do not exist in the lists of BCs in the config file.", CURRENT_FUNCTION);


Warn instead of error then? (when nZone != 1)

good point, done in 75746ac

SU2_CFD/src/output/CMultizoneOutput.cpp

SU2_CFD/src/solvers/CSolver.cpp

pcarruscag · 2022-02-02T11:55:37Z

SU2_CFD/src/output/CMultizoneOutput.cpp

+      vector<string> Marker;
+      if (group == "FLOW_COEFF_SURF")
+        Marker = Marker_Analyze;


find a way to avoid copying a vector of strings

... found a working *|& permutation that does the job in 2cbbe23

SU2_CFD/src/output/CMultizoneOutput.cpp

Co-authored-by: Pedro Gomes <38071223+pcarruscag@users.noreply.github.com>

.github/workflows/regression.yml

Common/src/CConfig.cpp

Co-authored-by: Pedro Gomes <38071223+pcarruscag@users.noreply.github.com>

TestCases/parallel_regression.py

This is due to the previously merged PR #1530 where an NDIME error in the mesh was fixed (where the reg test values already changed) and as this PR makes the same case a restarted one... the values have to be adapted again

TobiKattmann · 2022-02-02T21:57:57Z

Thanks all the review comments (for the second time today 😉 ) @pcarruscag 💐 Merging this in now 👍

TobiKattmann added 4 commits January 24, 2022 16:51

Multiply heat OF by specified weight.

46799db

Pressure_Drop computed with first two markers, additional follwoing w…

2811d45

…arkers allowed

Merge branch 'develop' of https://github.com/su2code/su2 into develop

9e702e7

pr-triage bot added the PR: draft label Jan 25, 2022

TobiKattmann added changelog:chore and removed PR: draft labels Jan 25, 2022

Fix builds for github due to warning.

cc00b17

pr-triage bot added the PR: draft label Jan 25, 2022

TobiKattmann and others added 2 commits January 25, 2022 18:43

Merge branch 'develop' into massflow_flowmeta

c62e553

Try to add *_SURF hist output for Multizone cases.

db52fb1

Not working yet. E.g. FLOW_COEFF_SURF[0] is not longer reported as ignored hist output filed but all values for these in the history file are zero. Not sure why tbh

TobiKattmann commented Jan 28, 2022

View reviewed changes

SU2_CFD/src/output/CMultizoneOutput.cpp Outdated Show resolved Hide resolved

TobiKattmann added 5 commits January 30, 2022 13:57

Merge branch 'massflow_flowmeta' of https://github.com/su2code/su2 in…

c3a1241

…to massflow_flowmeta

Multizone PerSurf Hist output now working

7ba1efc

In multizone everything is done again + attaching the zone indices. So one had to do the AddHistPerSurf and SetHistPerSurf for multizone again.

Adapt reg test for mutlizone per Surf output (on screen that is for n…

5241071

…ow).

Polishing of PerSurf Multizone output

16611fd

TobiKattmann commented Feb 1, 2022

View reviewed changes

SU2_CFD/src/output/CMultizoneOutput.cpp Outdated Show resolved Hide resolved

TobiKattmann commented Feb 1, 2022

View reviewed changes

SU2_CFD/src/output/CMultizoneOutput.cpp Outdated Show resolved Hide resolved

TobiKattmann commented Feb 1, 2022

View reviewed changes

SU2_CFD/src/output/CMultizoneOutput.cpp Outdated Show resolved Hide resolved

Apply suggestions from code review

bdc59ff

TobiKattmann changed the title ~~Streamwise Periodic restarts using flow.meta~~ Streamwise Periodic restarts using flow.meta + Multizone PerSurface output Feb 1, 2022

TobiKattmann added 3 commits February 1, 2022 12:38

Add now written PerSurf values to Reg test_vals.

7e5893c

Merge branch 'massflow_flowmeta' of https://github.com/su2code/su2 in…

d6924f4

…to massflow_flowmeta

Change a reg test to restart with flow.meta

982e9fc

TobiKattmann mentioned this pull request Feb 1, 2022

Add flow.meta restart files su2code/TestCases#92

Merged

TobiKattmann added 3 commits February 1, 2022 14:55

Tmp change of github workflow to load correct Testcases.

8f7f84c

Rmv WALL_TIME from screen out to make reg test work.

63804a8

TobiKattmann commented Feb 1, 2022

View reviewed changes

TestCases/TestCase.py Show resolved Hide resolved

Revert passed=False as the code assumes True until proven otherwise .…

ed6b29c

….. which I believe is not clever programming, especially for regression tests.

TobiKattmann marked this pull request as ready for review February 1, 2022 15:30

pr-triage bot added PR: unreviewed and removed PR: draft labels Feb 1, 2022

TobiKattmann added changelog:feature and removed changelog:chore labels Feb 1, 2022

pcarruscag reviewed Feb 2, 2022

View reviewed changes

TobiKattmann and others added 3 commits February 2, 2022 13:11

Cleanup suggestions from code review

f7f4c6d

Co-authored-by: Pedro Gomes <38071223+pcarruscag@users.noreply.github.com>

Additional warning for mutlizone, if DV_MARKERs not found.

75746ac

Co-authored-by: Pedro Gomes <38071223+pcarruscag@users.noreply.github.com>

Pass vector of strings by reference.

2cbbe23

TobiKattmann commented Feb 2, 2022

View reviewed changes

.github/workflows/regression.yml Outdated Show resolved Hide resolved

revert tmp changes to .github/workflows/regression.yml

4baa963

pcarruscag reviewed Feb 2, 2022

View reviewed changes

Common/src/CConfig.cpp Outdated Show resolved Hide resolved

pcarruscag approved these changes Feb 2, 2022

View reviewed changes

pr-triage bot added PR: reviewed-approved and removed PR: unreviewed labels Feb 2, 2022

Only Write screen output on Master node

6e06a34

Co-authored-by: Pedro Gomes <38071223+pcarruscag@users.noreply.github.com>

pr-triage bot added PR: unreviewed and removed PR: reviewed-approved labels Feb 2, 2022

Merge remote-tracking branch 'origin/develop' into massflow_flowmeta

be3bb45

TobiKattmann commented Feb 2, 2022

View reviewed changes

TestCases/parallel_regression.py Outdated Show resolved Hide resolved

TobiKattmann added 2 commits February 2, 2022 18:30

Update reg test value

a4d0060

This is due to the previously merged PR #1530 where an NDIME error in the mesh was fixed (where the reg test values already changed) and as this PR makes the same case a restarted one... the values have to be adapted again

Merge branch 'develop' into massflow_flowmeta

fd9a4d5

TobiKattmann merged commit ab8330f into develop Feb 2, 2022

TobiKattmann deleted the massflow_flowmeta branch February 2, 2022 21:58

pr-triage bot added PR: merged and removed PR: unreviewed labels Feb 2, 2022

TobiKattmann mentioned this pull request Feb 4, 2022

Fix adjoint for streamwise periodic massflow + General handling of adjoints of additional solution variables #1536

Merged

5 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Streamwise Periodic restarts using flow.meta + Multizone PerSurface output#1527

Streamwise Periodic restarts using flow.meta + Multizone PerSurface output#1527
TobiKattmann merged 28 commits intodevelopfrom
massflow_flowmeta

TobiKattmann commented Jan 25, 2022 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

TobiKattmann commented Feb 1, 2022

Uh oh!

pcarruscag left a comment

Uh oh!

pcarruscag Feb 2, 2022

Uh oh!

TobiKattmann Feb 2, 2022

Uh oh!

Uh oh!

Uh oh!

pcarruscag Feb 2, 2022

Uh oh!

TobiKattmann Feb 2, 2022

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

TobiKattmann commented Feb 2, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

		if(!found && (nZone==1)) {
		SU2_MPI::Error("DV_MARKER contains marker names that do not exist in the lists of BCs in the config file.", CURRENT_FUNCTION);

Conversation

TobiKattmann commented Jan 25, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Related Work

PR Checklist

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

TobiKattmann commented Feb 1, 2022

Uh oh!

pcarruscag left a comment

Choose a reason for hiding this comment

Uh oh!

pcarruscag Feb 2, 2022

Choose a reason for hiding this comment

Uh oh!

TobiKattmann Feb 2, 2022

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

pcarruscag Feb 2, 2022

Choose a reason for hiding this comment

Uh oh!

TobiKattmann Feb 2, 2022

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

TobiKattmann commented Feb 2, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

TobiKattmann commented Jan 25, 2022 •

edited

Loading