Skip to content

[WIP] Dual Time for NEMO solver + cleanups#1533

Closed
WallyMaier wants to merge 2 commits intodevelopfrom
nemo_time_cleanup
Closed

[WIP] Dual Time for NEMO solver + cleanups#1533
WallyMaier wants to merge 2 commits intodevelopfrom
nemo_time_cleanup

Conversation

@WallyMaier
Copy link
Contributor

@WallyMaier WallyMaier commented Feb 3, 2022

This PR addresses the dual-time solver of NEMO. A small lack of initialization of the solutions was causing problems.
There are also some small code clean-ups here and there.

Our current regression uses regular time-stepping, not sure if its worth adding an additional case for this.
I have yet to fully test this to make sure it works properly.

Related Work

#1391

PR Checklist

Put an X by all that apply. You can fill this out after submitting the PR. If you have any questions, don't hesitate to ask! We want to help. These are a guide for you to know what the reviewers will be looking for in your contribution.

  • I am submitting my contribution to the develop branch.
  • My contribution generates no new compiler warnings (try with the '-Wall -Wextra -Wno-unused-parameter -Wno-empty-body' compiler flags, or simply --warnlevel=2 when using meson).
  • My contribution is commented and consistent with SU2 style.
  • I have added a test case that demonstrates my contribution, if necessary.
  • I have updated appropriate documentation (Tutorials, Docs Page, config_template.cpp) , if necessary.

@WallyMaier WallyMaier changed the title Dual Time for NEMO solver + cleanups [WIP] Dual Time for NEMO solver + cleanups Feb 3, 2022
@pr-triage pr-triage bot removed the PR: unreviewed label Feb 3, 2022
@WallyMaier
Copy link
Contributor Author

closing and moving these changes to #1555

@WallyMaier WallyMaier closed this Mar 7, 2022
@WallyMaier WallyMaier deleted the nemo_time_cleanup branch March 8, 2022 21:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant