NEMO: Native Air-7 gas model implementation for inviscid flows#1555
NEMO: Native Air-7 gas model implementation for inviscid flows#1555WallyMaier merged 36 commits intodevelopfrom
Conversation
…to feature_NEMO_chem
|
Beyoncé's rule of programming, if you like it put a test on it. |
|
|
||
| /*--- Assign gas properties ---*/ | ||
| // Wall mass fractions for catalytic boundaries | ||
| Wall_Catalycity[0] = 0.999; |
There was a problem hiding this comment.
So did we make a decision on where to keep this data? I think in my very stale for the cat wall branch I had it as a config option, which I think is a good choice, but would it be better to store it here in fluid model? I think I remember getting push back for having it as a config option.
There was a problem hiding this comment.
Hmmm, I do recall the issue. I'm not sure what's the best way forward here. Either way, hardcoding values doesn't seem like the right move. (If I understand catalyticity correct....)
There was a problem hiding this comment.
Chatted about this, I think we agreed to use the free-stream values as the default, rather than having hard-coded values in fluid model, so I agree with removal here.
|
|
||
| //TODO: Implement Collision Integral Data for AIR-7 (JN) | ||
| /*--- Collision integral data ---*/ | ||
| //TODO: ELECTRONS HAvE NO OMEGAS....NEED TO ALTER LOOPS? or add dummy vector..... |
There was a problem hiding this comment.
I think the general reasoning is electrons are too small to contribute meaningfully to transport properties, so their collision integrals are effectively zero. A dummy vector makes sense I think.
There was a problem hiding this comment.
👍 Ill pull more from Scalabrin and park during the viscous implementation.
|
|
||
| if (gas_model == "O2"){ | ||
|
|
||
| // THESE ARE UNUSED. SHOULD WE KEEP???? Good for future? |
TestCases/nonequilibrium/thermalbath/finitechemistry/weakly_ionized.cfg
Outdated
Show resolved
Hide resolved
TestCases/nonequilibrium/thermalbath/finitechemistry/weakly_ionized.cfg
Outdated
Show resolved
Hide resolved
TestCases/nonequilibrium/thermalbath/finitechemistry/weakly_ionized.cfg
Outdated
Show resolved
Hide resolved
3 participants
Proposed Changes
@jtneedels and I have worked on implementing the Air-7 gas model to the NEMO native fluid model. This allows for simulations of inviscid weakly ionized flows with the addition of NO+ and e-.
I am open to adding a test case for this, similar to the thermal bath case, since they run extremely fast, though I am open to idea.
Work is ongoing to extend this viscous simulations.
Updates from #1533 are added here as well.
PR Checklist