Skip to content

Further Explicit Adjoints Locking and Lock-Free Adjoints Access#2161

Merged
jblueh merged 6 commits intodevelopfrom
more_explicit_locking
Nov 8, 2023
Merged

Further Explicit Adjoints Locking and Lock-Free Adjoints Access#2161
jblueh merged 6 commits intodevelopfrom
more_explicit_locking

Conversation

@jblueh
Copy link
Contributor

@jblueh jblueh commented Nov 7, 2023

Proposed Changes

  • Protect AD::GetDerivative() call trees by AD::BeginUseAdjoints(), AD::EndUseAdjoints().
  • GetAdjointSolution_time_n() and GetAdjointSolution_time_n1() use lock-free adjoints access now.

Related Work

continues #2146
related to #1984

PR Checklist

  • I am submitting my contribution to the develop branch.
  • My contribution generates no new compiler warnings (try with --warnlevel=3 when using meson).
  • My contribution is commented and consistent with SU2 style (https://su2code.github.io/docs_v7/Style-Guide/).
  • I used the pre-commit hook to prevent dirty commits and used pre-commit run --all to format old commits.
  • I have added a test case that demonstrates my contribution, if necessary.
  • I have updated appropriate documentation (Tutorials, Docs Page, config_template.cpp), if necessary.

@jblueh jblueh merged commit 5e82645 into develop Nov 8, 2023
@jblueh jblueh deleted the more_explicit_locking branch November 8, 2023 18:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants