Fix zed irresponsive on symlinked directory events outside the editor#50746

prayanshchh · 2026-03-04T20:47:09Z

Closes #48729, closes #27263, closes #45954

This PR aims to make zed responsive on symlinked directory events outside the editor.

Before you mark this PR as ready for review, make sure that you have:

Added a solid test coverage and/or screenshots from doing manual testing
Done a self-review taking into account security and performance aspects
Aligned any UI changes with the UI checklist

new-linked-folder is inside /zed-test/zed-project

output of ls -ld new-linked-folder
lrwxr-xr-x 1 prayanshchhablani staff 42 28 Mar 23:20 new-linked-folder -> /Users/prayanshchhablani/new-target-folder

this shows new-linked-folder is a symlink folder whose target is new-target-folder which is outside the root dir of the project opened in zed.

Screen.Recording.2026-04-02.at.3.54.02.PM.mov

Release Notes:

Fixed file watching of symlinks that point outside of the project/watched directory. Zed should now properly respond to changes in files in symlinked directories

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 1370f3ca27

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

yeskunall · 2026-03-12T06:26:54Z

@prayanshchh I think the bigger issue is #45954, which would also handle #48729. Have you taken a look at #45954? Wdyt?

prayanshchh · 2026-03-12T06:39:06Z

I agree, I didn't see this issue, will change this PR to resolve that one

probably-neb · 2026-03-17T02:57:10Z

Let us know when this is ready @prayanshchh!

merge

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 790324d847

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

prayanshchh · 2026-04-02T10:33:52Z

this is ready @probably-neb

prayanshchh · 2026-04-10T17:42:30Z

just checking, I am seeing more users facing the symlink issue can we get this reviewed?

auwi-nordic · 2026-04-10T17:55:29Z

This PR may address the same issue as my PR here?
#46338

No opinion about which one is better, just thought I'd mention it

auwi-nordic · 2026-04-10T17:59:38Z

This PR may also relate to issue #27263 ?

prayanshchh · 2026-04-12T06:32:20Z

This PR may address the same issue as my PR here? #46338

No opinion about which one is better, just thought I'd mention it

no worries lemme just push tests for this and lets review each other's PR just for fun..if u are down

prayanshchh · 2026-04-12T06:32:48Z

This PR may also relate to issue #27263 ?

yes

probably-neb · 2026-04-15T06:47:43Z

sorry for the delay on the follow up review! I got this one and #46338 mixed up

auwi-nordic · 2026-04-15T07:53:46Z

@prayanshchh FYI, probably-ned mentioned he'll be merging this PR rather than mine, as the solution here is better, which I agree with. You don't have to review the implementation in my PR, but you can check if there are tests you want to bring over.

prayanshchh · 2026-04-15T10:52:06Z

will do!

prayanshchh · 2026-04-15T10:52:25Z

sorry for the delay on the follow up review! I got this one and #46338 mixed up

np!

prayanshchh · 2026-04-20T15:08:31Z

lmk if something more is needed from this.

Malix-Labs · 2026-04-20T15:52:04Z

Could ~~"Closes #48729 #27263 #45954"~~ be written in the description instead?

Edit

Sorry, it needs to be :

Closes #48729, closes #27263, closes #45954

probably-neb · 2026-04-21T08:20:16Z

Great work. Thanks!

…zed-industries#50746) Closes zed-industries#48729, closes zed-industries#27263, closes zed-industries#45954 This PR aims to make zed responsive on symlinked directory events outside the editor. Before you mark this PR as ready for review, make sure that you have: - [ ] Added a solid test coverage and/or screenshots from doing manual testing - [x] Done a self-review taking into account security and performance aspects - [ ] Aligned any UI changes with the [UI checklist](https://github.com/zed-industries/zed/blob/main/CONTRIBUTING.md#uiux-checklist) new-linked-folder is inside /zed-test/zed-project output of ls -ld new-linked-folder `lrwxr-xr-x 1 prayanshchhablani staff 42 28 Mar 23:20 new-linked-folder -> /Users/prayanshchhablani/new-target-folder` this shows new-linked-folder is a symlink folder whose target is new-target-folder which is outside the root dir of the project opened in zed. https://github.com/user-attachments/assets/ffebafc3-2fc4-4293-bdbf-3a894a45e276 Release Notes: - Fixed file watching of symlinks that point outside of the project/watched directory. Zed should now properly respond to changes in files in symlinked directories

prayanshchh added 2 commits March 5, 2026 02:13

canonicalize watch

1fcf25b

add log

1370f3c

cla-bot Bot added the cla-signed The user has signed the Contributor License Agreement label Mar 4, 2026

fix log error

dab4506

chatgpt-codex-connector Bot reviewed Mar 4, 2026

View reviewed changes

Comment thread crates/fs/src/fs.rs Outdated

maxdeviant changed the title ~~Fix Zed config in a symlinked directory not applied when modified~~ Fix settings in a symlinked directory not applied when modified Mar 5, 2026

address bot comment

ae0aa5b

zelenenka added the guild Pull requests by someone in Zed Guild. NOTE: the label application is automated via github actions label Mar 16, 2026

probably-neb marked this pull request as draft March 17, 2026 02:56

probably-neb self-assigned this Mar 17, 2026

prayanshchh added 3 commits April 1, 2026 09:48

Merge remote-tracking branch 'upstream/main' into fix/symlink_dir

5dfbb30

merge

new changes fixing symlink dir changes made outside the editor

177031d

formatted diff

790324d

prayanshchh marked this pull request as ready for review April 1, 2026 14:19

zed-codeowner-coordinator Bot requested review from a team, cameron1024 and smitbarmase and removed request for a team April 1, 2026 14:19

zed-codeowner-coordinator Bot assigned cameron1024 Apr 1, 2026

chatgpt-codex-connector Bot reviewed Apr 1, 2026

View reviewed changes

Comment thread crates/worktree/src/worktree.rs Outdated

Comment thread crates/worktree/src/worktree.rs

address_comments

5104271

prayanshchh changed the title ~~Fix settings in a symlinked directory not applied when modified~~ Fix zed irresponsive on symlinked directory events outside the editor Apr 2, 2026

prayanshchh mentioned this pull request Apr 10, 2026

Symlinked directory does not update with changes made outside the editor #45954

Closed

prayanshchh added 7 commits April 12, 2026 12:17

symlink target existing inside the root

91dcf1b

test1

17b43de

cleaner diff

d47b519

Remove accidental docs from branch

706e7aa

format

2c03c69

test for symlink changes outside dir

178f91d

fmt

2b0221b

probably-neb mentioned this pull request Apr 15, 2026

Fix symlinked directories not being watched #46338

Closed

probably-neb requested changes Apr 15, 2026

View reviewed changes

Comment thread crates/settings/src/settings_file.rs

Comment thread crates/worktree/src/worktree.rs Outdated

prayanshchh added 2 commits April 16, 2026 21:26

new tests

9e17a56

improve normalization of events before process_events

ddcb475

probably-neb unassigned cameron1024 Apr 20, 2026

yeskunall mentioned this pull request Apr 20, 2026

A Zed config in a symlinked directory is not applied when I change it #48729

Closed

Merge branch 'main' into fix/symlink_dir

1df56c9

probably-neb approved these changes Apr 20, 2026

View reviewed changes

probably-neb merged commit 7620b78 into zed-industries:main Apr 21, 2026
33 checks passed

Uh oh!

Conversation

prayanshchh commented Mar 4, 2026 • edited by probably-neb Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

yeskunall commented Mar 12, 2026

Uh oh!

prayanshchh commented Mar 12, 2026

Uh oh!

probably-neb commented Mar 17, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

prayanshchh commented Apr 2, 2026

Uh oh!

prayanshchh commented Apr 10, 2026

Uh oh!

auwi-nordic commented Apr 10, 2026

Uh oh!

auwi-nordic commented Apr 10, 2026

Uh oh!

prayanshchh commented Apr 12, 2026

Uh oh!

prayanshchh commented Apr 12, 2026

Uh oh!

Uh oh!

Uh oh!

probably-neb commented Apr 15, 2026

Uh oh!

auwi-nordic commented Apr 15, 2026

Uh oh!

prayanshchh commented Apr 15, 2026

Uh oh!

prayanshchh commented Apr 15, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

prayanshchh commented Apr 20, 2026

Uh oh!

Malix-Labs commented Apr 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Edit

Uh oh!

probably-neb commented Apr 21, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

prayanshchh commented Mar 4, 2026 •

edited by probably-neb

Loading

prayanshchh commented Apr 15, 2026 •

edited

Loading

Malix-Labs commented Apr 20, 2026 •

edited

Loading