Skip to content

repl: Correctly discover user's kernels#50978

Merged
MrSubidubi merged 5 commits intozed-industries:mainfrom
raideno:fix-kernels-not-appearing-on-notebook
Apr 20, 2026
Merged

repl: Correctly discover user's kernels#50978
MrSubidubi merged 5 commits intozed-industries:mainfrom
raideno:fix-kernels-not-appearing-on-notebook

Conversation

@raideno
Copy link
Copy Markdown
Contributor

@raideno raideno commented Mar 7, 2026

Closes #50977

Before you mark this PR as ready for review, make sure that you have:

  • Added a solid test coverage and/or screenshots from doing manual testing
  • Done a self-review taking into account security and performance aspects
  • Aligned any UI changes with the UI checklist

Before:
image

After:
image

Release Notes:

  • Fixed kernels discovery in python notebook editor.

@cla-bot
Copy link
Copy Markdown

cla-bot Bot commented Mar 7, 2026

We require contributors to sign our Contributor License Agreement, and we don't have @raideno on file. You can sign our CLA at https://zed.dev/cla. Once you've signed, post a comment here that says '@cla-bot check'.

@zed-community-bot zed-community-bot Bot added the first contribution the author's first pull request to Zed. NOTE: the label application is automated via github actions label Mar 7, 2026
@raideno
Copy link
Copy Markdown
Contributor Author

raideno commented Mar 7, 2026

@cla-bot check

@cla-bot
Copy link
Copy Markdown

cla-bot Bot commented Mar 7, 2026

We require contributors to sign our Contributor License Agreement, and we don't have @raideno on file. You can sign our CLA at https://zed.dev/cla. Once you've signed, post a comment here that says '@cla-bot check'.

@cla-bot
Copy link
Copy Markdown

cla-bot Bot commented Mar 7, 2026

The cla-bot has been summoned, and re-checked this pull request!

@raideno
Copy link
Copy Markdown
Contributor Author

raideno commented Mar 7, 2026

@cla-bot check

@cla-bot cla-bot Bot added the cla-signed The user has signed the Contributor License Agreement label Mar 7, 2026
@cla-bot
Copy link
Copy Markdown

cla-bot Bot commented Mar 7, 2026

The cla-bot has been summoned, and re-checked this pull request!

@maxdeviant maxdeviant changed the title fix: correctly discover user's kernels repl: Correctly discover user's kernels Mar 7, 2026
Comment thread crates/repl/src/notebook/notebook_ui.rs Outdated
Comment thread crates/repl/src/notebook/notebook_ui.rs Outdated
@raideno raideno requested review from MostlyKIGuess and rgbkrk March 12, 2026 10:18
@raideno
Copy link
Copy Markdown
Contributor Author

raideno commented Mar 18, 2026

@rgbkrk please, could you review the changes whenever you have time ? thanks a lot.

Comment thread crates/repl/src/notebook/notebook_ui.rs Outdated
Copy link
Copy Markdown
Member

@MrSubidubi MrSubidubi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks! And congratulations to your first contribution!

@MrSubidubi MrSubidubi enabled auto-merge (squash) April 20, 2026 22:01
@MrSubidubi MrSubidubi merged commit a8b8449 into zed-industries:main Apr 20, 2026
31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla-signed The user has signed the Contributor License Agreement first contribution the author's first pull request to Zed. NOTE: the label application is automated via github actions

Projects

None yet

Development

Successfully merging this pull request may close these issues.

repl: Python environments not being discovered by notebook editor

4 participants