Fix recaptcha missing due to plugin change#11883
Merged
mekarpeles merged 1 commit intointernetarchive:masterfrom Feb 17, 2026
Merged
Fix recaptcha missing due to plugin change#11883mekarpeles merged 1 commit intointernetarchive:masterfrom
mekarpeles merged 1 commit intointernetarchive:masterfrom
Conversation
Collaborator
|
I don't think I can test but I strongly agree. This is also the general approach I'm moving towards via this plugins refactor (which we should carefully check) |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a broken registration button by removing unnecessary plugin existence checks that were preventing recaptcha from being properly initialized. The issue was that the is_plugin_enabled() function was checking whether plugins were dynamically loaded, but the recaptcha configuration is always available in the config file.
Changes:
- Removed
is_plugin_enabled()helper function and its usage in both account creation and book addition flows - Simplified recaptcha initialization by directly checking for valid config keys instead of checking plugin loading status
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| openlibrary/plugins/upstream/addbook.py | Removed is_plugin_enabled() function and simplified get_recaptcha() to check only recaptcha_exempt() before accessing config |
| openlibrary/plugins/upstream/account.py | Removed is_plugin_enabled() method from account_create class and simplified get_recap() to directly access config keys |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #11879 . Remove reliance on the dynamic construction of import paths, which feels like an anti-pattern.
Technical
Testing
Confirmed the recaptcha code appears on https://testing.openlibrary.org/account/create
Screenshot
Stakeholders
@mekarpeles @RayBB