Rollup of 18 pull requests#155373

jhpratt · 2026-04-16T02:32:33Z

Successful merges:

Emit fatal on invalid const args with nested defs #154595 (Emit fatal on invalid const args with nested defs)
report the varargs_without_pattern lint in deps #154599 (report the varargs_without_pattern lint in deps)
core::unicode: Replace Cased table with Lt #154699 (core::unicode: Replace Cased table with Lt)
resolve: Remove inaccessible_ctor_reexport resolver field #155353 (resolve: Remove inaccessible_ctor_reexport resolver field)
Add --remap-path-scope as unstable in rustdoc #155357 (Add --remap-path-scope as unstable in rustdoc)
clippy fix: non_canonical_clone_impl #150649 (clippy fix: non_canonical_clone_impl)
abort in core #154604 (abort in core)
Add --quiet flag to x.py and bootstrap to suppress output #154616 (Add --quiet flag to x.py and bootstrap to suppress output)
rustdoc: preserve doc(cfg) on locally re-exported type aliases #154970 (rustdoc: preserve doc(cfg) on locally re-exported type aliases)
Clean up AttributeLintKind and refactor diagnostic attribute linting #155215 (Clean up AttributeLintKind and refactor diagnostic attribute linting)
Check diagnostic output in incremental cpass and rpass revisions #155228 (Check diagnostic output in incremental cpass and rpass revisions)
Adjust release notes for post-merge feedback #155266 (Adjust release notes for post-merge feedback)
Disallow ZST allocations with TypedArena. #155326 (Disallow ZST allocations with TypedArena.)
docs: Use 0b1 instead of NonZero::MIN in NonZero::bit_width doctests #155334 (docs: Use 0b1 instead of NonZero::MIN in NonZero::bit_width doctests)
Handle nonnull pattern types in size skeleton #155340 (Handle nonnull pattern types in size skeleton)
Add push_mut and new Layout methods to release notes #155347 (Add push_mut and new Layout methods to release notes)
remove calls to AliasTyKind::def_id #155356 (remove calls to AliasTyKind::def_id)
Reduce diagnostic type visibilities. #155364 (Reduce diagnostic type visibilities.)

Shaves off 368 bytes from the total size of all Unicode data tables.

When a type alias is locally re-exported from a private module (an implicit inline), rustdoc drops its `cfg` attributes because it treats it like a standard un-inlined re-export. Since type aliases have no inner fields to carry the `cfg` badge (unlike structs or enums), the portability info is lost entirely. This patch explicitly preserves the target's `cfg` metadata when the generated item is a `TypeAliasItem`, ensuring the portability badge renders correctly without breaking standard cross-crate re-export behavior.

This avoids having to add several unhelpful annotations when enabling diagnostic checks for `cpass` and `rpass` revisions.

This allows warnings to be annotated, and verifies that no unexpected warnings occur.

* Adds musl CVE fix to compiler section * Removes Cargo section per feedback in the PR

`DroplessArena::alloc` already disallows ZST allocation. `TypedArena::alloc` allows it but: - (a) it's never used, and - (b) writing to `NonNull::dangling()` seems dubious, even if the write is zero-sized. This commit just changes it to panic on a ZST. This eliminates an untested code path, and we shouldn't be allocating ZSTs anyway. It also eliminates an unused ZST code path in `clear_last_chunk`. Tests are also updated accordingly.

…tests

Co-authored-by: Josh Stone <cuviper@gmail.com>

This adds a `--quiet` flag to x.py and bootstrap to suppress some of the output when compiling Rust. It conflicts with `--verbose`, matching the behavior of `cargo` which does not allow `--verbose` and `--quiet`. It works by passing quiet flags down to the underlying cargo, or LLVM build processes. Note that for LLVM, we only can suppress logs when we explicitly configure it with ninja. Otherwise we won't know what flag to pass along to whichever build system cmake decides to use. This can be helpful with AI workloads in the Rust codebase to help shrink down the output to reduce token usage, which can help prevent context pollution and lower costs. This patch was partially generated with Gemini, but I've reviewed the changes it made.

@WaffleLapkin

…_id, r=WaffleLapkin remove calls to AliasTyKind::def_id ref rust-lang#154941 I asked the LSP where `AliasTyKind::def_id` and then checked where the `AliasTyKind::def_id` was trivial to change. Could only find 2 places, and I am not sure about the `opaque_types.rs` (open to feedback!! :) ). All the others need refactoring or will end up with a logic as complex as `AliasTyKind::def_id` This is the list checked: - [X] compiler/rustc_borrowck/src/region_infer/opaque_types/member_constraints.rs — 1 - [X] compiler/rustc_borrowck/src/region_infer/opaque_types/mod.rs — 1 - [X] compiler/rustc_hir_analysis/src/check/compare_impl_item/refine.rs — 5 - [X] compiler/rustc_hir_analysis/src/check/mod.rs — 1 - [X] compiler/rustc_infer/src/infer/outlives/for_liveness.rs — 2 - [X] compiler/rustc_infer/src/infer/outlives/obligations.rs — 1 - [X] compiler/rustc_infer/src/infer/outlives/verify.rs — 3 - [X] compiler/rustc_middle/src/ty/print/pretty.rs — 1 - [X] compiler/rustc_middle/src/ty/sty.rs — 1 - [X] compiler/rustc_next_trait_solver/src/solve/assembly/mod.rs — 3 - [X] compiler/rustc_next_trait_solver/src/solve/effect_goals.rs — 3 - [X] compiler/rustc_pattern_analysis/src/rustc.rs — 1 - [X] compiler/rustc_public/src/unstable/convert/stable/ty.rs — 1 - [X] compiler/rustc_trait_selection/src/error_reporting/infer/mod.rs — 2 - [X] compiler/rustc_trait_selection/src/error_reporting/infer/note_and_explain.rs — 4 - [X] compiler/rustc_trait_selection/src/error_reporting/traits/suggestions.rs — 2 - [X] compiler/rustc_trait_selection/src/traits/effects.rs — 1 - [X] compiler/rustc_trait_selection/src/traits/query/normalize.rs — 1 - [X] compiler/rustc_ty_utils/src/opaque_types.rs — 7 - [X] compiler/rustc_ty_utils/src/ty.rs — 1 - [X] compiler/rustc_type_ir/src/outlives.rs — 1 - [X] compiler/rustc_type_ir/src/predicate.rs — 1 - [X] compiler/rustc_type_ir/src/relate.rs — 5 - [X] compiler/rustc_type_ir/src/ty_kind.rs — 2 r? @WaffleLapkin

@Kivooeo

…bilities, r=Kivooeo Reduce diagnostic type visibilities. Most diagnostic types are only used within their own crate, and so have a `pub(crate)` visibility. We have some diagnostic types that are unnecessarily `pub`. This is bad because (a) information hiding, and (b) if a `pub(crate)` type becomes unused the compiler will warn but it won't warn for a `pub` type. This commit eliminates unnecessary `pub` visibilities for some diagnostic types, and also some related things due to knock-on effects. (I found these types with some ad hoc use of `grep`.) r? @Kivooeo

jhpratt · 2026-04-16T02:33:07Z

@bors r+ rollup=never p=5

rust-bors · 2026-04-16T02:33:11Z

📌 Commit 837292d has been approved by jhpratt

It is now in the queue for this repository.

Rollup of 18 pull requests Successful merges: - #154595 (Emit fatal on invalid const args with nested defs) - #154599 (report the `varargs_without_pattern` lint in deps) - #154699 (`core::unicode`: Replace `Cased` table with `Lt`) - #155353 (resolve: Remove `inaccessible_ctor_reexport` resolver field) - #155357 (Add `--remap-path-scope` as unstable in rustdoc) - #150649 (clippy fix: non_canonical_clone_impl) - #154604 (abort in core) - #154616 (Add `--quiet` flag to x.py and bootstrap to suppress output) - #154970 (rustdoc: preserve `doc(cfg)` on locally re-exported type aliases) - #155215 (Clean up `AttributeLintKind` and refactor diagnostic attribute linting) - #155228 (Check diagnostic output in incremental `cpass` and `rpass` revisions) - #155266 (Adjust release notes for post-merge feedback) - #155326 (Disallow ZST allocations with `TypedArena`.) - #155334 (docs: Use `0b1` instead of `NonZero::MIN` in `NonZero::bit_width` doctests) - #155340 (Handle nonnull pattern types in size skeleton) - #155347 (Add push_mut and new Layout methods to release notes) - #155356 (remove calls to AliasTyKind::def_id) - #155364 (Reduce diagnostic type visibilities.)

rust-log-analyzer · 2026-04-16T05:49:52Z

The job aarch64-apple failed! Check out the build log: (web) (plain enhanced) (plain)

Click to see the possible cause of the failure (guessed by this bot)


---- [rustdoc-html] tests/rustdoc-html/reexport/type-alias-reexport.rs stdout ----
------rustdoc stdout------------------------------

------rustdoc stderr------------------------------
error[E0432]: unresolved import `self::inner::One`
##[error]  --> /Users/runner/work/rust/rust/tests/rustdoc-html/reexport/type-alias-reexport.rs:32:23
   |
32 | pub use self::inner::{One, Two};
   |                       ^^^ no `One` in `inner`
   |
note: found an item that was configured out
  --> /Users/runner/work/rust/rust/tests/rustdoc-html/reexport/type-alias-reexport.rs:10:14
   |
 9 |     #[cfg(target_os = "linux")]
---
------------------------------------------

error: rustdoc failed!
status: exit status: 1
command: cd "/Users/runner/work/rust/rust/build/aarch64-apple-darwin/test/rustdoc-html/reexport/type-alias-reexport" && env -u RUSTC_LOG_COLOR RUSTC_ICE="0" RUST_BACKTRACE="short" "/Users/runner/work/rust/rust/build/aarch64-apple-darwin/stage2/bin/rustdoc" "-L" "/Users/runner/work/rust/rust/build/aarch64-apple-darwin/stage2/lib/rustlib/aarch64-apple-darwin/lib" "-L" "/Users/runner/work/rust/rust/build/aarch64-apple-darwin/test/rustdoc-html/reexport/type-alias-reexport/auxiliary" "-o" "/Users/runner/work/rust/rust/build/aarch64-apple-darwin/test/rustdoc-html/reexport/type-alias-reexport" "--deny" "warnings" "/Users/runner/work/rust/rust/tests/rustdoc-html/reexport/type-alias-reexport.rs" "-A" "internal_features"
stdout: none
--- stderr -------------------------------
error[E0432]: unresolved import `self::inner::One`
##[error]  --> /Users/runner/work/rust/rust/tests/rustdoc-html/reexport/type-alias-reexport.rs:32:23
   |
32 | pub use self::inner::{One, Two};
   |                       ^^^ no `One` in `inner`
   |
note: found an item that was configured out
  --> /Users/runner/work/rust/rust/tests/rustdoc-html/reexport/type-alias-reexport.rs:10:14
   |
 9 |     #[cfg(target_os = "linux")]

rust-bors · 2026-04-16T05:50:15Z

💔 Test for 63faf88 failed: CI. Failed job:

auto - aarch64-apple (web logs, enhanced plaintext logs)

rust-bors · 2026-04-16T05:53:29Z

PR #154970, which is a member of this rollup, was unapproved.

hkBst and others added 30 commits January 27, 2026 13:00

clippy fix: non_canonical_clone_impl (except Infallible)

3a9981a

add abort_immediate

3a311ed

add missing core::process module docs

fb99fbe

core::unicode: Replace Cased table with Lt

e9b36bd

Shaves off 368 bytes from the total size of all Unicode data tables.

Merge malformed diagnostic attribute lint

e9d0e32

Merge "missing options" lints for diagnostic attributes

57fd974

move list parsing into its own function

217c073

Delete unused AttributeLintKind variant

0dd591a

Format the duplicate macro

f468cef

Fix some irrelevant warnings in tests/incremental

c79fcfc

This avoids having to add several unhelpful annotations when enabling diagnostic checks for `cpass` and `rpass` revisions.

Extract check_compiler_output_for_incr

8565c4a

Check diagnostic output in incremental cpass and rpass revisions

316fcbd

This allows warnings to be annotated, and verifies that no unexpected warnings occur.

report the varargs_without_pattern lint in deps

7c4cf96

Adjust release notes for post-merge feedback

edee654

* Adds musl CVE fix to compiler section * Removes Cargo section per feedback in the PR

Emit fatal on invalid const args with nested defs

58af51e

Update test with revisions

6f1d601

Warn instead of error for some ructs_on_unimplemented errors

75273e2

Pass allowed options as parameter to diagnostic lints

72db94f

docs: Use 0b1 instead of NonZero::MIN in NonZero::bit_width doc…

81cab93

…tests

Fix error code example

d6bccac

Add regression test

82545d7

Handle non-null pattern types in size skeleton

8d64264

Emit fatal on defaults for generic params in binders if with nested defs

1fca34d

Add FIXME for the fatal errors

77419b4

Add push_mut to release notes

e910c38

Add insert_mut to release notes

fba9ef8

Co-authored-by: Josh Stone <cuviper@gmail.com>

Add new Layout methods to release notes

4095bbd

jhpratt added 2 commits April 15, 2026 22:32

rust-bors bot added the rollup A PR which is a rollup label Apr 16, 2026

rust-bors bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 16, 2026

This comment has been minimized.

Sign in to view

rust-bors bot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Apr 16, 2026

jhpratt mentioned this pull request Apr 16, 2026

rustdoc: preserve doc(cfg) on locally re-exported type aliases #154970

Open

jhpratt closed this Apr 16, 2026

rust-bors bot added the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Apr 16, 2026

rustbot removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Apr 16, 2026

jhpratt deleted the rollup-qjxAt4R branch April 16, 2026 05:53

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Rollup of 18 pull requests#155373