Normalize test fixtures - #61315
Merged
Merged
Normalize test fixtures#61315
Conversation
jasonmccreary
force-pushed
the
fixtures
branch
from
August 24, 2026 18:01
3f1fa23 to
9312aba
Compare
binaryfire
added a commit
to hypervel/components
that referenced
this pull request
Sep 12, 2026
Request ApproximateReceiveCount through MessageSystemAttributeNames when receiving an SQS job. The AWS SDK 3.395.0 input shapes reject the deprecated AttributeNames form, exposing the source-analysis failure in CI. The response still supplies the same Attributes map used by SqsJob::attempts(). Update the existing exact request expectations and keep the queue counts on their separate getQueueAttributes API. Align the queue package suggestion and public prerequisite with the existing SDK minimum, 3.322.9, whose service model supports the replacement parameter. No compatibility branch, suppression or public queue API change is needed. Discovered during review of the fixture normalization port: laravel/framework#61315 https://docs.aws.amazon.com/AWSSimpleQueueService/latest/APIReference/API_ReceiveMessage.html Validation: the CI error was reproduced with SDK 3.395.0. The SQS queue, job and pool-proxy tests pass with the corrected request. Repository formatting and full source/type-fixture analysis pass.
binaryfire
added a commit
to hypervel/components
that referenced
this pull request
Sep 12, 2026
Match the duration span separately from the task description and result. The previous matcher required milliseconds, so a migration taking more than a second could fail the test despite completing successfully. Hypervel also formats longer runtimes with minutes, hours and localized units. Preserve the existing exact task and result expectations. Verify the fix with the existing migration suite and a temporary clock override that reproduces the old mismatch without sleeping or adding permanent test infrastructure. Corrects the test port from: laravel/framework#61315 Validation: the normal and simulated-slow migration suite, related migration and console tests, formatting and full static analysis pass.
binaryfire
added a commit
to hypervel/components
that referenced
this pull request
Sep 12, 2026
Delete the unused flights migration moved during fixture normalization. No test loads this directory, and it is unreferenced in the upstream tests too. The active Migrator suite already checks the skipped age migration and its schema result; MigratorEventsTest separately checks the skipped event. Retain that existing coverage instead of adding a duplicate test solely to justify an unused fixture. laravel/framework#55011 laravel/framework#61315 Validation: migrator, migration integration, event and console component tests pass, along with repository formatting and full static analysis.
binaryfire
added a commit
to hypervel/components
that referenced
this pull request
Sep 12, 2026
Remove the duplicate route-level InvokeDeferredCallbacks registration and its unused import. The middleware is already global, and the HTTP kernel invokes both route and global terminable middleware. The test now follows the same request setup as its neighboring HTTP cases. Keep the synchronous job and deferred-callback assertion, which still verifies that running the job cannot discard the request's callback. Refines the upstream test port completed with: laravel/framework#61315 laravel/framework#61422 Validation: the complete deferred-callback test class, repository formatting and full static analysis pass.
binaryfire
added a commit
to hypervel/components
that referenced
this pull request
Sep 12, 2026
Use PascalCase names for the pure, string-backed and integer-backed HTTP test enums, matching the repository convention. Update their consumers together while preserving every backed value and request data key. These fixtures test backed-value conversion and pure-enum rejection; no external value is derived from the case names. Existing assertions cover the same behavior without adding more tests. Completes the convention cleanup in: laravel/framework#61315 laravel/framework#61422 Validation: the complete HttpRequestTest, stale-reference search, repository formatting and full static analysis pass.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This normalizes the test "fixtures" to be consistently co-located under a
Fixtures/folder. This folder contains both properly namespaced classes, as well as "stub" files (migrations, templates, etc) used by the test suite."Fixtures" was chosen as it was already the most used convention within the test suite, is a common testing term, honors PSR-4, and avoids potential confusion with the "stub" files that can be published.