Dedupe common test fixtures - #61422
Merged
Merged
Conversation
binaryfire
added a commit
to hypervel/components
that referenced
this pull request
Sep 12, 2026
Remove the duplicate route-level InvokeDeferredCallbacks registration and its unused import. The middleware is already global, and the HTTP kernel invokes both route and global terminable middleware. The test now follows the same request setup as its neighboring HTTP cases. Keep the synchronous job and deferred-callback assertion, which still verifies that running the job cannot discard the request's callback. Refines the upstream test port completed with: laravel/framework#61315 laravel/framework#61422 Validation: the complete deferred-callback test class, repository formatting and full static analysis pass.
binaryfire
added a commit
to hypervel/components
that referenced
this pull request
Sep 12, 2026
Use PascalCase names for the pure, string-backed and integer-backed HTTP test enums, matching the repository convention. Update their consumers together while preserving every backed value and request data key. These fixtures test backed-value conversion and pure-enum rejection; no external value is derived from the case names. Existing assertions cover the same behavior without adding more tests. Completes the convention cleanup in: laravel/framework#61315 laravel/framework#61422 Validation: the complete HttpRequestTest, stale-reference search, repository formatting and full static analysis pass.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the last in a series of PRs to "clean up" the test suite by standardizing its conventions. Along the way, a few dozen fixtures were flagged as "byte identical". This dedupes those fixtures, as well as merges a few fixtures which matched within the 90th percentile.