add cfg(target_object_format = "...")#155126
Open
folkertdev wants to merge 1 commit intorust-lang:mainfrom
Open
add cfg(target_object_format = "...")#155126folkertdev wants to merge 1 commit intorust-lang:mainfrom
cfg(target_object_format = "...")#155126folkertdev wants to merge 1 commit intorust-lang:mainfrom
Conversation
rustbot
added
A-test-infra-minicore
This comment has been minimized.
This comment has been minimized.
folkertdev
force-pushed
the
target-object-format
branch
2 times, most recently
from
5b32d9f to
2212a27
Compare
Collaborator
|
This PR modifies cc @jieyouxu Some changes occurred in cfg and check-cfg configuration cc @Urgau These commits modify compiler targets. |
rustbot
added
S-waiting-on-review
Urgau
reviewed
Apr 10, 2026
This comment has been minimized.
This comment has been minimized.
folkertdev
force-pushed
the
target-object-format
branch
3 times, most recently
from
560902f to
36c6115
Compare
Collaborator
|
This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed. Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers. |
This comment has been minimized.
This comment has been minimized.
Urgau
reviewed
Apr 11, 2026
folkertdev
force-pushed
the
target-object-format
branch
from
36c6115 to
332a55c
Compare
This comment has been minimized.
This comment has been minimized.
folkertdev
force-pushed
the
target-object-format
branch
from
332a55c to
171dea8
Compare
This comment has been minimized.
This comment has been minimized.
folkertdev
force-pushed
the
target-object-format
branch
from
171dea8 to
6bcd172
Compare
Contributor
Author
|
Finally made it through CI |
Urgau
approved these changes
Apr 11, 2026
Member
There was a problem hiding this comment.
LGTM, r=me (unless you want to wait for @JonathanBrouwer)
Contributor
Author
|
@bors r=Urgau |
Contributor
rust-bors
bot
added
S-waiting-on-bors
JonathanBrouwer
added a commit
to JonathanBrouwer/rust
that referenced
this pull request
Apr 11, 2026
…=Urgau add `cfg(target_object_format = "...")` tracking issue: rust-lang#152586 I'm implementing the predicate as `target_object_format`, because that's what is useful to me (for testing `#[link_section = "..."]` where `mach-o` has some extra restrictions) and maps cleanly to the `BinaryFormat` enum that is used internally. There is still room for a future `target_executable_format` when there is a use case. cc @joshtriplett as the lang sponsor of this feature, @workingjubilee as the author of the proposal. r? JonathanBrouwer a sidequest from the sidequest that is rust-lang#155065
JonathanBrouwer
added a commit
to JonathanBrouwer/rust
that referenced
this pull request
Apr 11, 2026
…=Urgau add `cfg(target_object_format = "...")` tracking issue: rust-lang#152586 I'm implementing the predicate as `target_object_format`, because that's what is useful to me (for testing `#[link_section = "..."]` where `mach-o` has some extra restrictions) and maps cleanly to the `BinaryFormat` enum that is used internally. There is still room for a future `target_executable_format` when there is a use case. cc @joshtriplett as the lang sponsor of this feature, @workingjubilee as the author of the proposal. r? JonathanBrouwer a sidequest from the sidequest that is rust-lang#155065
jhpratt
added a commit
to jhpratt/rust
that referenced
this pull request
Apr 12, 2026
…=Urgau add `cfg(target_object_format = "...")` tracking issue: rust-lang#152586 I'm implementing the predicate as `target_object_format`, because that's what is useful to me (for testing `#[link_section = "..."]` where `mach-o` has some extra restrictions) and maps cleanly to the `BinaryFormat` enum that is used internally. There is still room for a future `target_executable_format` when there is a use case. cc @joshtriplett as the lang sponsor of this feature, @workingjubilee as the author of the proposal. r? JonathanBrouwer a sidequest from the sidequest that is rust-lang#155065
rust-bors bot
pushed a commit
that referenced
this pull request
Apr 12, 2026
Rollup of 7 pull requests Successful merges: - #155084 (Initial functions to start on transmute v2) - #155126 (add `cfg(target_object_format = "...")`) - #155165 (Portable SIMD subtree update) - #153871 (fix spurious test failure in `metadata_access_times`) - #155150 (replace <name> @ ty::AliasTy matches with just using args: <name>_args) - #155159 (Fix min-specialization ICE from ignored region resolution failure) - #155167 (Reduce size of `ImportData`)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
tracking issue: #152586
I'm implementing the predicate as
target_object_format, because that's what is useful to me (for testing#[link_section = "..."]wheremach-ohas some extra restrictions) and maps cleanly to theBinaryFormatenum that is used internally. There is still room for a futuretarget_executable_formatwhen there is a use case.cc @joshtriplett as the lang sponsor of this feature, @workingjubilee as the author of the proposal.
r? JonathanBrouwer a sidequest from the sidequest that is #155065