Rollup of 3 pull requests#155160
Closed
JonathanBrouwer wants to merge 6 commits intorust-lang:mainfrom
Closed
Conversation
* remove time assertion on SystemTime * skip test only if when a time change occurs
* Extend `core::char`'s documentation of casing issues * Fix typos * Fix typo Co-authored-by: GrigorenkoPV <GrigorenkoPV+github@yandex.ru> * Document maximum 3x character expansion This is guaranteed by Unicode. * Fix error in `str` casing method docs
…Simulacrum Extend `core::char`'s documentation of casing issues @rustbot label A-unicode A-docs
…=Urgau add `cfg(target_object_format = "...")` tracking issue: rust-lang#152586 I'm implementing the predicate as `target_object_format`, because that's what is useful to me (for testing `#[link_section = "..."]` where `mach-o` has some extra restrictions) and maps cleanly to the `BinaryFormat` enum that is used internally. There is still room for a future `target_executable_format` when there is a use case. cc @joshtriplett as the lang sponsor of this feature, @workingjubilee as the author of the proposal. r? JonathanBrouwer a sidequest from the sidequest that is rust-lang#155065
…-Simulacrum fix spurious test failure in `metadata_access_times` Fixes rust-lang#148408 The metadata_access_times test checks if the creation of a file occurs before another file, this check happens only on Linux. While on Win and Macos we check only that the created metadata is available. Given that the SystemTime is non monotonic as Instant this test could result in failures when the system clock changes.
Contributor
Author
|
@bors r+ rollup=never p=5 |
Contributor
This comment has been minimized.
This comment has been minimized.
Collaborator
|
The job Click to see the possible cause of the failure (guessed by this bot) |
Contributor
|
💔 Test for 9a81e54 failed: CI. Failed job:
|
Contributor
|
PR #154491, which is a member of this rollup, was unapproved. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Successful merges:
core::char's documentation of casing issues #154491 (Extendcore::char's documentation of casing issues)cfg(target_object_format = "...")#155126 (addcfg(target_object_format = "..."))metadata_access_times#153871 (fix spurious test failure inmetadata_access_times)r? @ghost
Create a similar rollup