fix(ui): restore classic padding on Astryx dialog headers - #1715
Merged
Conversation
Astro-Han
approved these changes
Aug 1, 2026
Astro-Han
left a comment
Contributor
There was a problem hiding this comment.
Reviewed the current head. Removing the five local padding overrides restores the Astryx dialog-header inset while leaving body padding, scrolling, and focus behavior unchanged. I found no issues in the patch.
GitHub checks have not run for this PR, so this approval covers the diff only. Please run the required checks before merge.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #1713.
The Astryx modal migration (#1674) dropped the dialog header inset and
the follow-up adapter removal (#1688) moved
padding={0}into the fivedialog call sites. Astryx's
DialogHeaderderives its padding from thedialog container's
--layout-padding-*variables, so withpadding={0}the provider icon, title, subtitle and close button render flush against
the modal edges in every dialog.
This removes
padding={0}from the five<Dialog>call sites(provider connection, bot onboarding, WeChat QR, MCP editor, keyboard
help). The header now picks up the Astryx theme default
(
--astryx-dialog-padding, 16px).Why call sites instead of a shared default: #1688 removed the
@maka/uicompatibility layer, so the padding decision now lives atthe call sites — there is no adapter left to fix. Each dialog keeps
LayoutContent padding={0}and its own body inset, so no body spacingchanges; scoping the fix to the header leaves every other inset
identical.
Verification
npm run lint— clean (2423 files)npm run format:check— clean (1321 files)npm run typecheck— all 10 workspaces pass.npm --workspace @maka/ui run build— pass