fix(storybook): filter non-component icon exports - #2544
Merged
Conversation
Contributor
Author
|
The Storybook failure is the existing Daily Review 480px bounds check; the icon catalog render passes on this run. #2546 carries the selector fix. |
me2seeks
force-pushed
the
fix/2541-icon-story
branch
from
August 9, 2026 02:56
ceae36b to
b0a4c08
Compare
Contributor
Author
|
Rebased onto #2546. The icon catalog is green now; the remaining Storybook failures are both the Daily Review 480px bounds check. |
This was referenced Aug 9, 2026
This was referenced Aug 9, 2026
This was referenced Aug 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#2538 added
ICON_SIZEto@maka/ui/icons, so that module is no longer component-only. The icon story still cast every namespace export toElementType, and production Storybook tried to render the size object as a component.This keeps the catalog self-updating, but filters the namespace to function and
forwardRefcomponent shapes before rendering it.Tested with:
Fixes #2541
中文对照
#2538 在
@maka/ui/icons中加入了ICON_SIZE,因此这个模块不再只导出组件。图标 Story 仍把命名空间里的每个导出都强制当成ElementType,导致生产 Storybook 把尺寸对象作为组件渲染。本次修改保留图标目录的自动追踪,只在渲染前接收函数组件和
forwardRef组件形态。已验证 Desktop Storybook 类型检查、生产构建,以及完整 Storybook smoke(48 个 manifest 检查、101 个 catalog Story)。