fix(desktop): bound settings selector menus - #2556
Merged
Merged
Conversation
7 tasks
Astro-Han
force-pushed
the
fix/storybook-daily-stable-layout
branch
from
August 9, 2026 05:50
f2d51dc to
3b5dd0a
Compare
Astro-Han
marked this pull request as ready for review
August 9, 2026 05:55
This was referenced Aug 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Keep Selector listbox layers inside settings rows by capping each popover to its anchor width. The existing narrow Daily Review story now reports named geometry failures and rectangles so future regressions remain actionable.
GitHub's Linux font metrics made the model option's intrinsic popover
144.1875pxwide while its anchor was134px. Because the layer aligns to the anchor's left edge, its right edge reached454.1875px, past the settings page boundary at452px. The same label measured narrower locally, which hid the overflow.Refs #2541
Verification
popoverWithinPage; popover right454.1875, page right452.134pxanchor to199.359375px; enabling it keeps both at134px.npx biome check apps/desktop/src/renderer/styles/settings/rows.css apps/desktop/stories/settings/settings-pages.stories.tsxnpm --workspace @maka/desktop run typecheck:storiesnpm --workspace @maka/desktop run build-storybookDependency
Checklist
Does this PR entail a change in behavior?