Skip to content

fix(desktop): bound settings selector menus - #2556

Merged
Astro-Han merged 2 commits into
mainfrom
fix/storybook-daily-stable-layout
Aug 9, 2026
Merged

fix(desktop): bound settings selector menus#2556
Astro-Han merged 2 commits into
mainfrom
fix/storybook-daily-stable-layout

Conversation

@Astro-Han

@Astro-Han Astro-Han commented Aug 9, 2026

Copy link
Copy Markdown
Contributor

Summary

Keep Selector listbox layers inside settings rows by capping each popover to its anchor width. The existing narrow Daily Review story now reports named geometry failures and rectangles so future regressions remain actionable.

GitHub's Linux font metrics made the model option's intrinsic popover 144.1875px wide while its anchor was 134px. Because the layer aligns to the anchor's left edge, its right edge reached 454.1875px, past the settings page boundary at 452px. The same label measured narrower locally, which hid the overflow.

Refs #2541

Verification

  • GitHub Storybook RED: popoverWithinPage; popover right 454.1875, page right 452.
  • Causal local probe with widened option text: disabling the new cap expands the popover from the 134px anchor to 199.359375px; enabling it keeps both at 134px.
  • npx biome check apps/desktop/src/renderer/styles/settings/rows.css apps/desktop/stories/settings/settings-pages.stories.tsx
  • npm --workspace @maka/desktop run typecheck:stories
  • npm --workspace @maka/desktop run build-storybook
  • Full local Storybook smoke: both Daily Review floor checks pass; only the known icon catalog failure fixed by fix(storybook): filter non-component icon exports #2544 remains.

Dependency

Checklist

  • Tests cover the change and fail without it
  • Lint, format, typecheck and the affected suites pass locally

Does this PR entail a change in behavior?

  • Yes — described under Summary above
  • No

@Astro-Han Astro-Han changed the title test(storybook): diagnose Daily Review bounds fix(desktop): bound settings selector menus Aug 9, 2026
@Astro-Han
Astro-Han force-pushed the fix/storybook-daily-stable-layout branch from f2d51dc to 3b5dd0a Compare August 9, 2026 05:50
@Astro-Han
Astro-Han marked this pull request as ready for review August 9, 2026 05:55
@Astro-Han
Astro-Han merged commit 1025eb2 into main Aug 9, 2026
12 checks passed
@Astro-Han
Astro-Han deleted the fix/storybook-daily-stable-layout branch August 9, 2026 06:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant