fix(desktop): restore composer drafts after #2574 remount - #2584
Merged
Conversation
Drop the session-keyed ChatLayout remount that wiped the in-composer draft Map, and point patch-era e2e/story selectors at stock Astryx DOM.
#2574 dropped the data-slot patch; nested sticky CSS still targeted it, so expanded call headers scrolled away. Bind sticky to role=button instead.
3 tasks
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ChatSurfaceLayoutwithkey={activeId}so scroll state would not leak. That also remounted the Composer and wiped its in-component draft Map. The PR comment claimed drafts lived outside the layout; they do not.role=buttoninstead ofdata-slot="chat-tool-call-row".maka-module-page-rowsinstead of[aria-label="技能列表"](List does not forwardaria-label)Test plan
extensions-skills-scroll-containmentpasses