fix(ui): drop ceremonial Astryx patches; two-tone shell floor - #2574
Merged
Conversation
Keep only real blocking patches (blank UA-CH, ai-sdk tool-call tracker). Product code uses stock ChatToolCalls + Astryx Button for linked sessions, and remounts ChatLayout on session switch instead of conversationKey. Shell sidebar shares the canvas base so the floating plate gap is not a third colour. Remove patch-guard tests and the floating-recipe CSS hook.
3 tasks
5 tasks
4 tasks
jackwener
added a commit
that referenced
this pull request
Aug 9, 2026
#2574 dropped the data-slot patch; nested sticky CSS still targeted it, so expanded call headers scrolled away. Bind sticky to role=button instead.
jackwener
added a commit
that referenced
this pull request
Aug 9, 2026
* fix(desktop): restore composer drafts after #2574 remount Drop the session-keyed ChatLayout remount that wiped the in-composer draft Map, and point patch-era e2e/story selectors at stock Astryx DOM. * fix(desktop): sticky tool-call rows on stock ChatToolCalls DOM #2574 dropped the data-slot patch; nested sticky CSS still targeted it, so expanded call headers scrolled away. Bind sticky to role=button instead.
3 tasks
jackwener
added a commit
that referenced
this pull request
Aug 9, 2026
Remove suites that pinned vendor class names, sticky px offsets, List aria-label, and CSS-grep structure after #2574 dropped ceremonial patches. Keep product journeys, classifier logic, and the real blank-UA-CH patch gate.
jackwener
added a commit
that referenced
this pull request
Aug 9, 2026
Remove suites that pinned vendor class names, sticky px offsets, List aria-label, and CSS-grep structure after #2574 dropped ceremonial patches. Keep product journeys, classifier logic, and the real blank-UA-CH patch gate.
jackwener
added a commit
that referenced
this pull request
Aug 9, 2026
* test: drop Astryx DOM geometry and CSS string contracts Remove suites that pinned vendor class names, sticky px offsets, List aria-label, and CSS-grep structure after #2574 dropped ceremonial patches. Keep product journeys, classifier logic, and the real blank-UA-CH patch gate. * test: drop more layout geometry and vendor class pins Second pass: Daily Review bounds play, Astryx Skeleton class checks, astryx-codeblock markup matches, MCP field Y-order, and workbar CSS pixel widths. Keep accessible values, journeys, and product signals. * fix(ci): allowlist Astryx tool-call and CodeBlock CSS hooks Removing test greps for astryx-chat-tool-calls / astryx-codeblock made check-dead-css treat product CSS overrides as dead. Mark them as runtime themeProps classes like the other Astryx hooks. * test(e2e): slash desktop suite to core product journeys Drop flaky/geometry/vendor-heavy specs (quote-companion, mermaid layout, mention grammar, workbar resize, providers/MCP/onboarding surfaces, etc.). Keep send+IME, draft survival, skill revision drafts, blank-UA-CH help, settings theme shell, and artifact list navigation. Prune unused fixtures. * fix(e2e): drop unused e2eHomeDir export after suite cull Knip typecheck failed: skill-delete e2e was the last consumer.
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
@astryxdesign/corepatch to blank UA-CH only (Electron mod-key /Kbdbug). Remove conversationKey, Listaria-label, ChatToolCallsonActivate/ group totals, andastryx-layer-surfacefloating-recipe hook.Buttonbeside stockChatToolCalls; session switch remountsChatLayoutwithkey(composer draft is session-keyed outside the layout).--agents-layout-bg/ base; content plate stays raised (fixes third-tone gap at the plate corner).floating-recipe,new-messages-indicator,ink-ladder-contract,astryx-list-accessible-name) and slimpatches/README.@ai-sdk/provider-utilspatch (streaming tool-call association for messy gateway shapes).Test plan
npm run build --workspace=@maka/uiandnode --test packages/ui/dist/__tests__/tool-trow-stability.test.js