test: drop Astryx DOM geometry and CSS string contracts - #2587
Merged
Conversation
Member
Author
Round 2 (pushed)Also removed / slimmed:
Still intentionally kept: mermaid chrome product journey, skill/token chips via astryx token attrs (user-visible chips), keyboard-help blank UA-CH patch gate. |
jackwener
force-pushed
the
chore/drop-astryx-dom-contracts
branch
from
August 9, 2026 07:57
e6b3dfe to
e953f57
Compare
Remove suites that pinned vendor class names, sticky px offsets, List aria-label, and CSS-grep structure after #2574 dropped ceremonial patches. Keep product journeys, classifier logic, and the real blank-UA-CH patch gate.
Second pass: Daily Review bounds play, Astryx Skeleton class checks, astryx-codeblock markup matches, MCP field Y-order, and workbar CSS pixel widths. Keep accessible values, journeys, and product signals.
Removing test greps for astryx-chat-tool-calls / astryx-codeblock made check-dead-css treat product CSS overrides as dead. Mark them as runtime themeProps classes like the other Astryx hooks.
jackwener
force-pushed
the
chore/drop-astryx-dom-contracts
branch
from
August 9, 2026 08:12
8251fe0 to
24fa21e
Compare
Drop flaky/geometry/vendor-heavy specs (quote-companion, mermaid layout, mention grammar, workbar resize, providers/MCP/onboarding surfaces, etc.). Keep send+IME, draft survival, skill revision drafts, blank-UA-CH help, settings theme shell, and artifact list navigation. Prune unused fixtures.
Knip typecheck failed: skill-delete e2e was the last consumer.
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
After #2574 / #2584, a class of tests still treated vendor Astryx DOM / CSS shape as product API. Those are brittle and not user journeys. This PR deletes them.
Removed
e2e/activity-card-sticky.spec.ts+activityCardWindowfixturecontract-css-helpers.ts/css-test-helpers.ts.astryx-side-nav-itemselector chains; keep classifier + paneldata-stale/pill render teststool-trow-stability“Astryx tool-call root” caseastryx-chat-tool-callsstreaming-handoffcount ofastryx-chat-tool-callsIntentionally kept
keyboard-help(the one remaining real Astryx patch)tool-activity-presentation, linked subagent rows, diff ± counts)play-executedcontractNet: −301 lines.
Test plan
stale-sessionsunit: classifier + pill wiring still runtool-trow-stability: diff counts + linked subagent cases still run