Skip to content

[fix][sec]Upgrade jackson to 2.17.2 - #23174

Merged
lhotari merged 2 commits into
apache:masterfrom
hrsakai:upgrade-jackson
Aug 16, 2024
Merged

[fix][sec]Upgrade jackson to 2.17.2#23174
lhotari merged 2 commits into
apache:masterfrom
hrsakai:upgrade-jackson

Conversation

@hrsakai

@hrsakai hrsakai commented Aug 15, 2024

Copy link
Copy Markdown
Contributor

Motivation

I run the following code:

JsonIgnore test code
class Foo {
    private int a = 10;

    @JsonIgnore
    private transient int b = 11;

    public int getA() {
        return a;
    }

    public void setA(int a) {
        this.a = a;
    }

    public int getB() {
        return b;
    }

    public void setB(int b) {
        this.b = b;
    }

    public static void main(String args[]) throws JsonProcessingException {
        ObjectMapper ob = new ObjectMapper();
        System.out.println(ob.writeValueAsString(new Foo()));
    }
}

result:

# expected
 {"a":10}

# 2.14.2
{"a":10}

# 2.15.2
{"a":10,"b":11}

# 2.17.2
{"a":10}

Modifications

  • Upgrade jackson to 2.17.2

Verifying this change

  • Make sure that the change passes the CI checks.

Documentation

  • doc
  • doc-required
  • doc-not-needed
  • doc-complete

Matching PR in forked repository

PR in forked repository:

@hrsakai hrsakai added the doc-not-needed Your PR changes do not impact docs label Aug 15, 2024
@hrsakai hrsakai added this to the 4.0.0 milestone Aug 15, 2024
@hrsakai hrsakai self-assigned this Aug 15, 2024
@hrsakai hrsakai changed the title Upgrade jackson to 2.17.2 [fix][sec]Upgrade jackson to 2.17.2 Aug 15, 2024
@codecov-commenter

codecov-commenter commented Aug 15, 2024

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.59%. Comparing base (bbc6224) to head (e60bff4).
Report is 529 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##             master   #23174      +/-   ##
============================================
+ Coverage     73.57%   74.59%   +1.02%     
- Complexity    32624    34172    +1548     
============================================
  Files          1877     1921      +44     
  Lines        139502   144480    +4978     
  Branches      15299    15809     +510     
============================================
+ Hits         102638   107775    +5137     
+ Misses        28908    28460     -448     
- Partials       7956     8245     +289     
Flag Coverage Δ
inttests 27.99% <100.00%> (+3.40%) ⬆️
systests 24.72% <100.00%> (+0.40%) ⬆️
unittests 73.94% <100.00%> (+1.10%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...ava/org/apache/pulsar/common/util/FieldParser.java 87.40% <100.00%> (ø)

... and 503 files with indirect coverage changes

@lhotari lhotari left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lhotari
lhotari merged commit b6815d2 into apache:master Aug 16, 2024
@hrsakai
hrsakai deleted the upgrade-jackson branch August 16, 2024 05:18
grssam pushed a commit to grssam/pulsar that referenced this pull request Sep 4, 2024
hanmz pushed a commit to hanmz/pulsar that referenced this pull request Feb 12, 2025
lhotari pushed a commit that referenced this pull request Mar 2, 2026
Riyasoni0 pushed a commit to datastax/pulsar that referenced this pull request Mar 9, 2026
(cherry picked from commit b6815d2)
(cherry picked from commit a35f537)
Riyasoni0 pushed a commit to datastax/pulsar that referenced this pull request Mar 9, 2026
(cherry picked from commit b6815d2)
(cherry picked from commit a35f537)
manas-ctds pushed a commit to datastax/pulsar that referenced this pull request Mar 10, 2026
(cherry picked from commit b6815d2)
(cherry picked from commit a35f537)
nodece pushed a commit to ascentstream/pulsar that referenced this pull request May 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants